From e051bec7a0fd0c1867865b14a330cfd2af863d2c Mon Sep 17 00:00:00 2001 From: Thomas Date: Thu, 5 Jun 2025 11:22:50 +0200 Subject: [PATCH] Fix a memory leak for not cropped media --- .../fedilab/android/mastodon/client/entities/api/Status.java | 1 + .../app/fedilab/android/mastodon/ui/drawer/StatusAdapter.java | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/app/fedilab/android/mastodon/client/entities/api/Status.java b/app/src/main/java/app/fedilab/android/mastodon/client/entities/api/Status.java index 1ed93997..1ff67480 100644 --- a/app/src/main/java/app/fedilab/android/mastodon/client/entities/api/Status.java +++ b/app/src/main/java/app/fedilab/android/mastodon/client/entities/api/Status.java @@ -115,6 +115,7 @@ public class Status implements Serializable, Cloneable { public List reactions; public String attachedNotification = null; + public int gifPosition = 0; public transient boolean isFetchMore = false; public transient boolean isFetching = false; diff --git a/app/src/main/java/app/fedilab/android/mastodon/ui/drawer/StatusAdapter.java b/app/src/main/java/app/fedilab/android/mastodon/ui/drawer/StatusAdapter.java index 0736a201..236dc0a3 100644 --- a/app/src/main/java/app/fedilab/android/mastodon/ui/drawer/StatusAdapter.java +++ b/app/src/main/java/app/fedilab/android/mastodon/ui/drawer/StatusAdapter.java @@ -3638,7 +3638,8 @@ public class StatusAdapter extends RecyclerView.Adapter doubleTapPlayerView.getPlayer().release(); } } - } else if (holder.binding.mediaContainer.getChildCount() > 0) { //Not cropped views + } + if (holder.binding.mediaContainer.getChildCount() > 0) { //Not cropped views for(int i = 0 ; i < holder.binding.mediaContainer.getChildCount() ; i++ ) { PlayerView doubleTapPlayerView = holder.binding.mediaContainer.getChildAt(i).findViewById(R.id.media_video); if (doubleTapPlayerView != null && doubleTapPlayerView.getPlayer() != null) {