Comparison was downcasing only one side, therefore if previously existing account had a non-lowercase spelling, it would be ignored when checking for duplicates. New rake task `mastodon:maintenance:find_duplicate_usernames` will help find constraint violations that might have occured from the presence of this bug. Bump version to 2.3.3
		
			
				
	
	
		
			14 lines
		
	
	
	
		
			437 B
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			14 lines
		
	
	
	
		
			437 B
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # frozen_string_literal: true
 | |
| 
 | |
| class UniqueUsernameValidator < ActiveModel::Validator
 | |
|   def validate(account)
 | |
|     return if account.username.nil?
 | |
| 
 | |
|     normalized_username = account.username.downcase.delete('.')
 | |
| 
 | |
|     scope = Account.where(domain: nil).where('lower(username) = ?', normalized_username)
 | |
|     scope = scope.where.not(id: account.id) if account.persisted?
 | |
| 
 | |
|     account.errors.add(:username, :taken) if scope.exists?
 | |
|   end
 | |
| end
 |