8fb6b02b54
This fixes the StatusLengthValidator tests to use StatusLengthValidator::MAX_CHARS to derive the length of the strings tested, and so makes them resilient to changes in MAX_CHARS (such as the one that made these tests fail, with it being changed from 500 to 512). This seems a bit odd for some types of tests, but appears to make sense here, where the testing goes beyond `status.length > MAX_CHARS`.
51 lines
2 KiB
Ruby
51 lines
2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe StatusLengthValidator do
|
|
describe '#validate' do
|
|
it 'does not add errors onto remote statuses'
|
|
it 'does not add errors onto local reblogs'
|
|
|
|
it 'adds an error when content warning is over MAX_CHARS characters' do
|
|
chars = StatusLengthValidator::MAX_CHARS + 1
|
|
status = double(spoiler_text: 'a' * chars, text: '', errors: double(add: nil), local?: true, reblog?: false)
|
|
subject.validate(status)
|
|
expect(status.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'adds an error when text is over MAX_CHARS characters' do
|
|
chars = StatusLengthValidator::MAX_CHARS + 1
|
|
status = double(spoiler_text: '', text: 'a' * chars, errors: double(add: nil), local?: true, reblog?: false)
|
|
subject.validate(status)
|
|
expect(status.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'adds an error when text and content warning are over MAX_CHARS characters total' do
|
|
chars1 = 20
|
|
chars2 = StatusLengthValidator::MAX_CHARS + 1 - chars1
|
|
status = double(spoiler_text: 'a' * chars1, text: 'b' * chars2, errors: double(add: nil), local?: true, reblog?: false)
|
|
subject.validate(status)
|
|
expect(status.errors).to have_received(:add)
|
|
end
|
|
|
|
it 'counts URLs as 23 characters flat' do
|
|
chars = StatusLengthValidator::MAX_CHARS - 1 - 23
|
|
text = ('a' * chars) + " http://#{'b' * 30}.com/example"
|
|
status = double(spoiler_text: '', text: text, errors: double(add: nil), local?: true, reblog?: false)
|
|
|
|
subject.validate(status)
|
|
expect(status.errors).to_not have_received(:add)
|
|
end
|
|
|
|
it 'counts only the front part of remote usernames' do
|
|
username = '@alice'
|
|
chars = StatusLengthValidator::MAX_CHARS - 1 - username.length
|
|
text = ('a' * 475) + " #{username}@#{'b' * 30}.com"
|
|
status = double(spoiler_text: '', text: text, errors: double(add: nil), local?: true, reblog?: false)
|
|
|
|
subject.validate(status)
|
|
expect(status.errors).to_not have_received(:add)
|
|
end
|
|
end
|
|
end
|