* Refactor signature verification a bit * Rescue signature verification if recorded public key is invalid Fixes #8822 * Always re-fetch AP signing key when HTTP Signature verification fails But when the account is not marked as stale, avoid fetching collections and media, and avoid webfinger round-trip. * Apply stoplight to key/account update as well as initial key retrieval
		
			
				
	
	
		
			62 lines
		
	
	
	
		
			2.1 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			62 lines
		
	
	
	
		
			2.1 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # frozen_string_literal: true
 | |
| 
 | |
| class ActivityPub::FetchRemoteAccountService < BaseService
 | |
|   include JsonLdHelper
 | |
| 
 | |
|   SUPPORTED_TYPES = %w(Application Group Organization Person Service).freeze
 | |
| 
 | |
|   # Does a WebFinger roundtrip on each call, unless `only_key` is true
 | |
|   def call(uri, id: true, prefetched_body: nil, break_on_redirect: false, only_key: false)
 | |
|     return ActivityPub::TagManager.instance.uri_to_resource(uri, Account) if ActivityPub::TagManager.instance.local_uri?(uri)
 | |
| 
 | |
|     @json = if prefetched_body.nil?
 | |
|               fetch_resource(uri, id)
 | |
|             else
 | |
|               body_to_json(prefetched_body, compare_id: id ? uri : nil)
 | |
|             end
 | |
| 
 | |
|     return if !supported_context? || !expected_type? || (break_on_redirect && @json['movedTo'].present?)
 | |
| 
 | |
|     @uri      = @json['id']
 | |
|     @username = @json['preferredUsername']
 | |
|     @domain   = Addressable::URI.parse(@uri).normalized_host
 | |
| 
 | |
|     return unless only_key || verified_webfinger?
 | |
| 
 | |
|     ActivityPub::ProcessAccountService.new.call(@username, @domain, @json, only_key: only_key)
 | |
|   rescue Oj::ParseError
 | |
|     nil
 | |
|   end
 | |
| 
 | |
|   private
 | |
| 
 | |
|   def verified_webfinger?
 | |
|     webfinger                            = Goldfinger.finger("acct:#{@username}@#{@domain}")
 | |
|     confirmed_username, confirmed_domain = split_acct(webfinger.subject)
 | |
| 
 | |
|     return webfinger.link('self')&.href == @uri if @username.casecmp(confirmed_username).zero? && @domain.casecmp(confirmed_domain).zero?
 | |
| 
 | |
|     webfinger                            = Goldfinger.finger("acct:#{confirmed_username}@#{confirmed_domain}")
 | |
|     @username, @domain                   = split_acct(webfinger.subject)
 | |
|     self_reference                       = webfinger.link('self')
 | |
| 
 | |
|     return false unless @username.casecmp(confirmed_username).zero? && @domain.casecmp(confirmed_domain).zero?
 | |
|     return false if self_reference&.href != @uri
 | |
| 
 | |
|     true
 | |
|   rescue Goldfinger::Error
 | |
|     false
 | |
|   end
 | |
| 
 | |
|   def split_acct(acct)
 | |
|     acct.gsub(/\Aacct:/, '').split('@')
 | |
|   end
 | |
| 
 | |
|   def supported_context?
 | |
|     super(@json)
 | |
|   end
 | |
| 
 | |
|   def expected_type?
 | |
|     equals_or_includes_any?(@json['type'], SUPPORTED_TYPES)
 | |
|   end
 | |
| end
 |