This PR adds a new notification cleaning mode, super perfectly tuned for accessibility, and removes the previous notification cleaning functionality as it's now redundant. * w.i.p. notif clearing mode * Better CSS for selected notification and shorter text if Stretch is off * wip for rebase ~ * all working in notif clearing mode, except the actual removal * bulk delete route for piggo * cleaning + refactor. endpoint gives 422 for some reason * formatting * use the right route * fix broken destroy_multiple * load more notifs after succ cleaning * satisfy eslint * Removed CSS for the old notif delete button * Tabindex=0 is mandatory In order to make it possible to tab to this element you must have tab index = 0. Removing this violates WCAG and makes it impossible to use the interface without good eyesight and a mouse. So nobody with certain mobility impairments, vision impairments, or brain injuries would be able to use this feature if you don't have tabindex=0 * Corrected aria-label Previous label implied a different behavior from what actually happens * aria role localization & made the overlay behave like a checkbox * checkboxes css and better contrast * color tuning for the notif overlay * fanceh checkboxes etc and nice backgrounds * SHUT UP TRAVIS
		
			
				
	
	
		
			96 lines
		
	
	
	
		
			2.3 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			96 lines
		
	
	
	
		
			2.3 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # frozen_string_literal: true
 | |
| 
 | |
| class Api::V1::NotificationsController < Api::BaseController
 | |
|   before_action -> { doorkeeper_authorize! :read }
 | |
|   before_action :require_user!
 | |
|   after_action :insert_pagination_headers, only: :index
 | |
| 
 | |
|   respond_to :json
 | |
| 
 | |
|   DEFAULT_NOTIFICATIONS_LIMIT = 15
 | |
| 
 | |
|   def index
 | |
|     @notifications = load_notifications
 | |
|     render json: @notifications, each_serializer: REST::NotificationSerializer, relationships: StatusRelationshipsPresenter.new(target_statuses_from_notifications, current_user&.account_id)
 | |
|   end
 | |
| 
 | |
|   def show
 | |
|     @notification = current_account.notifications.find(params[:id])
 | |
|     render json: @notification, serializer: REST::NotificationSerializer
 | |
|   end
 | |
| 
 | |
|   def clear
 | |
|     current_account.notifications.delete_all
 | |
|     render_empty
 | |
|   end
 | |
| 
 | |
|   def destroy
 | |
|     dismiss
 | |
|   end
 | |
| 
 | |
|   def dismiss
 | |
|     current_account.notifications.find_by!(id: params[:id]).destroy!
 | |
|     render_empty
 | |
|   end
 | |
| 
 | |
|   def destroy_multiple
 | |
|     current_account.notifications.where(id: params[:ids]).destroy_all
 | |
|     render_empty
 | |
|   end
 | |
| 
 | |
|   private
 | |
| 
 | |
|   def load_notifications
 | |
|     cache_collection paginated_notifications, Notification
 | |
|   end
 | |
| 
 | |
|   def paginated_notifications
 | |
|     browserable_account_notifications.paginate_by_max_id(
 | |
|       limit_param(DEFAULT_NOTIFICATIONS_LIMIT),
 | |
|       params[:max_id],
 | |
|       params[:since_id]
 | |
|     )
 | |
|   end
 | |
| 
 | |
|   def browserable_account_notifications
 | |
|     current_account.notifications.browserable(exclude_types)
 | |
|   end
 | |
| 
 | |
|   def target_statuses_from_notifications
 | |
|     @notifications.reject { |notification| notification.target_status.nil? }.map(&:target_status)
 | |
|   end
 | |
| 
 | |
|   def insert_pagination_headers
 | |
|     set_pagination_headers(next_path, prev_path)
 | |
|   end
 | |
| 
 | |
|   def next_path
 | |
|     unless @notifications.empty?
 | |
|       api_v1_notifications_url pagination_params(max_id: pagination_max_id)
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   def prev_path
 | |
|     unless @notifications.empty?
 | |
|       api_v1_notifications_url pagination_params(since_id: pagination_since_id)
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   def pagination_max_id
 | |
|     @notifications.last.id
 | |
|   end
 | |
| 
 | |
|   def pagination_since_id
 | |
|     @notifications.first.id
 | |
|   end
 | |
| 
 | |
|   def exclude_types
 | |
|     val = params.permit(exclude_types: [])[:exclude_types] || []
 | |
|     val = [val] unless val.is_a?(Enumerable)
 | |
|     val
 | |
|   end
 | |
| 
 | |
|   def pagination_params(core_params)
 | |
|     params.permit(:limit, exclude_types: []).merge(core_params)
 | |
|   end
 | |
| end
 |