ae871c4d46
* Make Array-creation behavior of Paginable more predictable Paginable.paginate_by_id usually returns ActiveRecord::Relation, but it returns an Array if min_id option is present. The behavior caused problems fixed with the following commits: -552e886b64-b63ede5005-64ef37b89dTo prevent from recurring similar problems, this commit introduces two changes: - The scope now always returns an Array whether min_id option is present or not. - The scope is renamed to to_a_paginated_by_id to clarify it returns an Array. * Transform Paginable.to_a_paginated_by_id from a scope to a class method https://api.rubyonrails.org/classes/ActiveRecord/Scoping/Named/ClassMethods.html#method-i-scope > The method is intended to return an ActiveRecord::Relation object, which > is composable with other scopes. Paginable.to_a_paginated_by_id returns an Array and is not appropriate as a scope.
128 lines
3.2 KiB
Ruby
128 lines
3.2 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class Api::V1::Admin::AccountsController < Api::BaseController
|
|
include Authorization
|
|
include AccountableConcern
|
|
|
|
LIMIT = 100
|
|
|
|
before_action -> { doorkeeper_authorize! :'admin:read', :'admin:read:accounts' }, only: [:index, :show]
|
|
before_action -> { doorkeeper_authorize! :'admin:write', :'admin:write:accounts' }, except: [:index, :show]
|
|
before_action :require_staff!
|
|
before_action :set_accounts, only: :index
|
|
before_action :set_account, except: :index
|
|
before_action :require_local_account!, only: [:enable, :approve, :reject]
|
|
|
|
after_action :insert_pagination_headers, only: :index
|
|
|
|
FILTER_PARAMS = %i(
|
|
local
|
|
remote
|
|
by_domain
|
|
active
|
|
pending
|
|
disabled
|
|
silenced
|
|
suspended
|
|
username
|
|
display_name
|
|
email
|
|
ip
|
|
staff
|
|
).freeze
|
|
|
|
PAGINATION_PARAMS = (%i(limit) + FILTER_PARAMS).freeze
|
|
|
|
def index
|
|
authorize :account, :index?
|
|
render json: @accounts, each_serializer: REST::Admin::AccountSerializer
|
|
end
|
|
|
|
def show
|
|
authorize @account, :show?
|
|
render json: @account, serializer: REST::Admin::AccountSerializer
|
|
end
|
|
|
|
def enable
|
|
authorize @account.user, :enable?
|
|
@account.user.enable!
|
|
log_action :enable, @account.user
|
|
render json: @account, serializer: REST::Admin::AccountSerializer
|
|
end
|
|
|
|
def approve
|
|
authorize @account.user, :approve?
|
|
@account.user.approve!
|
|
render json: @account, serializer: REST::Admin::AccountSerializer
|
|
end
|
|
|
|
def reject
|
|
authorize @account.user, :reject?
|
|
SuspendAccountService.new.call(@account, reserve_email: false, reserve_username: false)
|
|
render json: @account, serializer: REST::Admin::AccountSerializer
|
|
end
|
|
|
|
def unsilence
|
|
authorize @account, :unsilence?
|
|
@account.unsilence!
|
|
log_action :unsilence, @account
|
|
render json: @account, serializer: REST::Admin::AccountSerializer
|
|
end
|
|
|
|
def unsuspend
|
|
authorize @account, :unsuspend?
|
|
@account.unsuspend!
|
|
log_action :unsuspend, @account
|
|
render json: @account, serializer: REST::Admin::AccountSerializer
|
|
end
|
|
|
|
private
|
|
|
|
def set_accounts
|
|
@accounts = filtered_accounts.order(id: :desc).includes(user: [:invite_request, :invite]).to_a_paginated_by_id(limit_param(LIMIT), params_slice(:max_id, :since_id, :min_id))
|
|
end
|
|
|
|
def set_account
|
|
@account = Account.find(params[:id])
|
|
end
|
|
|
|
def filtered_accounts
|
|
AccountFilter.new(filter_params).results
|
|
end
|
|
|
|
def filter_params
|
|
params.permit(*FILTER_PARAMS)
|
|
end
|
|
|
|
def insert_pagination_headers
|
|
set_pagination_headers(next_path, prev_path)
|
|
end
|
|
|
|
def next_path
|
|
api_v1_admin_accounts_url(pagination_params(max_id: pagination_max_id)) if records_continue?
|
|
end
|
|
|
|
def prev_path
|
|
api_v1_admin_accounts_url(pagination_params(min_id: pagination_since_id)) unless @accounts.empty?
|
|
end
|
|
|
|
def pagination_max_id
|
|
@accounts.last.id
|
|
end
|
|
|
|
def pagination_since_id
|
|
@accounts.first.id
|
|
end
|
|
|
|
def records_continue?
|
|
@accounts.size == limit_param(LIMIT)
|
|
end
|
|
|
|
def pagination_params(core_params)
|
|
params.slice(*PAGINATION_PARAMS).permit(*PAGINATION_PARAMS).merge(core_params)
|
|
end
|
|
|
|
def require_local_account!
|
|
forbidden unless @account.local? && @account.user.present?
|
|
end
|
|
end
|