* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
		
			
				
	
	
		
			35 lines
		
	
	
	
		
			911 B
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			35 lines
		
	
	
	
		
			911 B
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| require 'rails_helper'
 | |
| 
 | |
| RSpec.describe Api::V1::PollsController, type: :controller do
 | |
|   render_views
 | |
| 
 | |
|   let(:user)   { Fabricate(:user) }
 | |
|   let(:scopes) { 'read:statuses' }
 | |
|   let(:token)  { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
 | |
| 
 | |
|   before { allow(controller).to receive(:doorkeeper_token) { token } }
 | |
| 
 | |
|   describe 'GET #show' do
 | |
|     let(:poll) { Fabricate(:poll, status: Fabricate(:status, visibility: visibility)) }
 | |
| 
 | |
|     before do
 | |
|       get :show, params: { id: poll.id }
 | |
|     end
 | |
| 
 | |
|     context 'when parent status is public' do
 | |
|       let(:visibility) { 'public' }
 | |
| 
 | |
|       it 'returns http success' do
 | |
|         expect(response).to have_http_status(200)
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     context 'when parent status is private' do
 | |
|       let(:visibility) { 'private' }
 | |
| 
 | |
|       it 'returns http not found' do
 | |
|         expect(response).to have_http_status(404)
 | |
|       end
 | |
|     end
 | |
|   end
 | |
| end
 |