* Change account and user fabricators to simplify and improve tests - `Fabricate(:account)` implicitly fabricates an associated `user` if no `domain` attribute is given (an account with `domain: nil` is considered a local account, but no user record was created), unless `user: nil` is passed - `Fabricate(:account, user: Fabricate(:user))` should still be possible but is discouraged. * Fix and refactor tests - avoid passing unneeded attributes to `Fabricate(:user)` or `Fabricate(:account)` - avoid embedding `Fabricate(:user)` into a `Fabricate(:account)` or the other way around - prefer `Fabricate(:user, account_attributes: …)` to `Fabricate(:user, account: Fabricate(:account, …)` - also, some tests were using remote accounts with local user records, which is not representative of production code.
		
			
				
	
	
		
			34 lines
		
	
	
	
		
			865 B
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			34 lines
		
	
	
	
		
			865 B
		
	
	
	
		
			Ruby
		
	
	
	
	
	
require 'rails_helper'
 | 
						|
 | 
						|
RSpec.describe Api::V1::Polls::VotesController, type: :controller do
 | 
						|
  render_views
 | 
						|
 | 
						|
  let(:user)   { Fabricate(:user) }
 | 
						|
  let(:scopes) { 'write:statuses' }
 | 
						|
  let(:token)  { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
 | 
						|
 | 
						|
  before { allow(controller).to receive(:doorkeeper_token) { token } }
 | 
						|
 | 
						|
  describe 'POST #create' do
 | 
						|
    let(:poll) { Fabricate(:poll) }
 | 
						|
 | 
						|
    before do
 | 
						|
      post :create, params: { poll_id: poll.id, choices: %w(1) }
 | 
						|
    end
 | 
						|
 | 
						|
    it 'returns http success' do
 | 
						|
      expect(response).to have_http_status(200)
 | 
						|
    end
 | 
						|
 | 
						|
    it 'creates a vote' do
 | 
						|
      vote = poll.votes.where(account: user.account).first
 | 
						|
 | 
						|
      expect(vote).to_not be_nil
 | 
						|
      expect(vote.choice).to eq 1
 | 
						|
    end
 | 
						|
 | 
						|
    it 'updates poll tallies' do
 | 
						|
      expect(poll.reload.cached_tallies).to eq [0, 1]
 | 
						|
    end
 | 
						|
  end
 | 
						|
end
 |