me/glitchier-soc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
glitchier-soc/app
History
zunda 09191dee66
Add single splat to callback method definitions to avoid ArgumentError (#22246) 
It looks like a [bug](https://bugs.ruby-lang.org/issues/18633) around
autosplat is [fixed](fbaadd1cfe)
on ruby-3.2.0-rc1 and breaks a test (but not on ruby <= 3.1.3):

```
$ bundle exec rspec ./spec/controllers/api/v1/emails/confirmations_controller_spec.rb:41
  :
  1) Api::V1::Emails::ConfirmationsController#create with an oauth token from an app that created the account when the account is already confirmed but user changed e-mail and has not confirmed it returns http success
     Failure/Error:
         def email_changed(user, **)
           @resource = user
           @instance = Rails.configuration.x.local_domain

           return unless @resource.active_for_authentication?

           I18n.with_locale(locale) do
             mail to: @resource.email, subject: I18n.t('devise.mailer.email_changed.subject')
           end
         end

     ArgumentError:
       wrong number of arguments (given 2, expected 1)
     # ./app/mailers/user_mailer.rb:51:in `email_changed'
     # ./app/models/user.rb:444:in `render_and_send_devise_message'
     # ./app/models/user.rb:430:in `block in send_pending_devise_notifications'
     # ./app/models/user.rb:429:in `each'
     # ./app/models/user.rb:429:in `send_pending_devise_notifications'
     # ./spec/controllers/api/v1/emails/confirmations_controller_spec.rb:38:in `block (7 levels) in <top (required)>'
```
2022-12-13 20:03:16 +01:00
..
chewy Change algorithm of tootctl search deploy to improve performance (#18463) 2022-05-22 22:16:43 +02:00
controllers Log admin approve and reject account (#22088) 2022-12-07 00:25:18 +01:00
helpers Add Scots to the supported locales (#20283) 2022-11-10 21:11:38 +01:00
javascript fix missing style in warning and strike cards (#22177) 2022-12-13 20:03:09 +01:00
lib Fix unbounded recursion in account discovery (#22025) 2022-12-07 00:15:24 +01:00
mailers Add single splat to callback method definitions to avoid ArgumentError (#22246) 2022-12-13 20:03:16 +01:00
models Fix failure when “Require a reason to join” is set with open registrations (#22127) 2022-12-07 16:39:58 +01:00
policies Fix getting a single EmailDomainBlock (#20846) 2022-11-17 10:55:50 +01:00
presenters Change sign-in banner to reflect disabled or moved account status (#19773) 2022-11-05 18:28:13 +01:00
serializers Add maskable icon support for Android (#20904) 2022-11-17 10:52:30 +01:00
services Fix unbounded recursion in account discovery (#22025) 2022-12-07 00:15:24 +01:00
validators Fix error when uploading malformed CSV import (#19509) 2022-10-28 23:30:44 +02:00
views Add noindex setting to Admin settings Discovery page (#22205) 2022-12-11 07:27:44 +01:00
workers Change incoming activity processing to happen in ingress queue (#20264) 2022-11-10 14:21:51 +01:00