* Add more granular OAuth scopes * Add human-readable descriptions of the new scopes * Ensure new scopes look good on the app UI * Add tests * Group scopes in screen and color-code dangerous ones * Fix wrong extra scope
		
			
				
	
	
		
			75 lines
		
	
	
	
		
			1.8 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			75 lines
		
	
	
	
		
			1.8 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| require 'rails_helper'
 | |
| 
 | |
| RSpec.describe Api::V1::DomainBlocksController, type: :controller do
 | |
|   render_views
 | |
| 
 | |
|   let(:user)  { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
 | |
|   let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) }
 | |
| 
 | |
|   before do
 | |
|     user.account.block_domain!('example.com')
 | |
|     allow(controller).to receive(:doorkeeper_token) { token }
 | |
|   end
 | |
| 
 | |
|   shared_examples 'forbidden for wrong scope' do |wrong_scope|
 | |
|     let(:scopes) { wrong_scope }
 | |
| 
 | |
|     it 'returns http forbidden' do
 | |
|       expect(response).to have_http_status(403)
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   describe 'GET #show' do
 | |
|     let(:scopes) { 'read:blocks' }
 | |
| 
 | |
|     before do
 | |
|       get :show, params: { limit: 1 }
 | |
|     end
 | |
| 
 | |
|     it 'returns http success' do
 | |
|       expect(response).to have_http_status(200)
 | |
|     end
 | |
| 
 | |
|     it 'returns blocked domains' do
 | |
|       expect(body_as_json.first).to eq 'example.com'
 | |
|     end
 | |
| 
 | |
|     it_behaves_like 'forbidden for wrong scope', 'write:statuses'
 | |
|   end
 | |
| 
 | |
|   describe 'POST #create' do
 | |
|     let(:scopes) { 'write:blocks' }
 | |
| 
 | |
|     before do
 | |
|       post :create, params: { domain: 'example.org' }
 | |
|     end
 | |
| 
 | |
|     it 'returns http success' do
 | |
|       expect(response).to have_http_status(200)
 | |
|     end
 | |
| 
 | |
|     it 'creates a domain block' do
 | |
|       expect(user.account.domain_blocking?('example.org')).to be true
 | |
|     end
 | |
| 
 | |
|     it_behaves_like 'forbidden for wrong scope', 'write:statuses'
 | |
|   end
 | |
| 
 | |
|   describe 'DELETE #destroy' do
 | |
|     let(:scopes) { 'write:blocks' }
 | |
| 
 | |
|     before do
 | |
|       delete :destroy, params: { domain: 'example.com' }
 | |
|     end
 | |
| 
 | |
|     it 'returns http success' do
 | |
|       expect(response).to have_http_status(200)
 | |
|     end
 | |
| 
 | |
|     it 'deletes a domain block' do
 | |
|       expect(user.account.domain_blocking?('example.com')).to be false
 | |
|     end
 | |
| 
 | |
|     it_behaves_like 'forbidden for wrong scope', 'write:statuses'
 | |
|   end
 | |
| end
 |