* Fix misuse of foreign_type * Fix use of removed "add_template_helper" * Use response.media_type instead of response.content_type in tests * Fix CSV export controller test on Rails 6 Rails 6 sets a "filename*" field in the Content-Disposition header to explicitly encode the filename as UTF-8. This changes checks the first part of the Content-Disposition header so it matches in both Rails 5 and Rails 6. * Fix emoji formatting with Rails 6 * Make emoji output more idiomatic and robust * Switch from redis-rails gem to built-in Rails redis cache storage
		
			
				
	
	
		
			247 lines
		
	
	
	
		
			7.9 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			247 lines
		
	
	
	
		
			7.9 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| # frozen_string_literal: true
 | |
| 
 | |
| require 'rails_helper'
 | |
| 
 | |
| RSpec.describe ActivityPub::RepliesController, type: :controller do
 | |
|   let(:status) { Fabricate(:status, visibility: parent_visibility) }
 | |
|   let(:remote_reply_id) { nil }
 | |
|   let(:remote_account) { nil }
 | |
| 
 | |
|   shared_examples 'cachable response' do
 | |
|     it 'does not set cookies' do
 | |
|       expect(response.cookies).to be_empty
 | |
|       expect(response.headers['Set-Cookies']).to be nil
 | |
|     end
 | |
| 
 | |
|     it 'does not set sessions' do
 | |
|       response
 | |
|       expect(session).to be_empty
 | |
|     end
 | |
| 
 | |
|     it 'returns public Cache-Control header' do
 | |
|       expect(response.headers['Cache-Control']).to include 'public'
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   before do
 | |
|     allow(controller).to receive(:signed_request_account).and_return(remote_account)
 | |
| 
 | |
|     Fabricate(:status, thread: status, visibility: :public)
 | |
|     Fabricate(:status, thread: status, visibility: :public)
 | |
|     Fabricate(:status, thread: status, visibility: :private)
 | |
|     Fabricate(:status, account: status.account, thread: status, visibility: :public)
 | |
|     Fabricate(:status, account: status.account, thread: status, visibility: :private)
 | |
| 
 | |
|     Fabricate(:status, account: remote_account, thread: status, visibility: :public, uri: remote_reply_id) if remote_reply_id
 | |
|   end
 | |
| 
 | |
|   describe 'GET #index' do
 | |
|     context 'with no signature' do
 | |
|       subject(:response) { get :index, params: { account_username: status.account.username, status_id: status.id } }
 | |
|       subject(:body) { body_as_json }
 | |
| 
 | |
|       context 'when account is permanently suspended' do
 | |
|         let(:parent_visibility) { :public }
 | |
| 
 | |
|         before do
 | |
|           status.account.suspend!
 | |
|           status.account.deletion_request.destroy
 | |
|         end
 | |
| 
 | |
|         it 'returns http gone' do
 | |
|           expect(response).to have_http_status(410)
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       context 'when account is temporarily suspended' do
 | |
|         let(:parent_visibility) { :public }
 | |
| 
 | |
|         before do
 | |
|           status.account.suspend!
 | |
|         end
 | |
| 
 | |
|         it 'returns http forbidden' do
 | |
|           expect(response).to have_http_status(403)
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       context 'when status is public' do
 | |
|         let(:parent_visibility) { :public }
 | |
| 
 | |
|         it 'returns http success' do
 | |
|           expect(response).to have_http_status(200)
 | |
|         end
 | |
| 
 | |
|         it 'returns application/activity+json' do
 | |
|           expect(response.media_type).to eq 'application/activity+json'
 | |
|         end
 | |
| 
 | |
|         it_behaves_like 'cachable response'
 | |
| 
 | |
|         it 'returns items with account\'s own replies' do
 | |
|           expect(body[:first]).to be_a Hash
 | |
|           expect(body[:first][:items]).to be_an Array
 | |
|           expect(body[:first][:items].size).to eq 1
 | |
|           expect(body[:first][:items].all? { |item| item[:to].include?(ActivityPub::TagManager::COLLECTIONS[:public]) || item[:cc].include?(ActivityPub::TagManager::COLLECTIONS[:public]) }).to be true
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       context 'when status is private' do
 | |
|         let(:parent_visibility) { :private }
 | |
| 
 | |
|         it 'returns http not found' do
 | |
|           expect(response).to have_http_status(404)
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       context 'when status is direct' do
 | |
|         let(:parent_visibility) { :direct }
 | |
| 
 | |
|         it 'returns http not found' do
 | |
|           expect(response).to have_http_status(404)
 | |
|         end
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     context 'with signature' do
 | |
|       let(:remote_account) { Fabricate(:account, domain: 'example.com') }
 | |
|       let(:only_other_accounts) { nil }
 | |
| 
 | |
|       context do
 | |
|         before do
 | |
|           get :index, params: { account_username: status.account.username, status_id: status.id, only_other_accounts: only_other_accounts }
 | |
|         end
 | |
| 
 | |
|         context 'when status is public' do
 | |
|           let(:parent_visibility) { :public }
 | |
| 
 | |
|           it 'returns http success' do
 | |
|             expect(response).to have_http_status(200)
 | |
|           end
 | |
| 
 | |
|           it 'returns application/activity+json' do
 | |
|             expect(response.media_type).to eq 'application/activity+json'
 | |
|           end
 | |
| 
 | |
|           it_behaves_like 'cachable response'
 | |
| 
 | |
|           context 'without only_other_accounts' do
 | |
|             it 'returns items with account\'s own replies' do
 | |
|               json = body_as_json
 | |
| 
 | |
|               expect(json[:first]).to be_a Hash
 | |
|               expect(json[:first][:items]).to be_an Array
 | |
|               expect(json[:first][:items].size).to eq 1
 | |
|               expect(json[:first][:items].all? { |item| item[:to].include?(ActivityPub::TagManager::COLLECTIONS[:public]) || item[:cc].include?(ActivityPub::TagManager::COLLECTIONS[:public]) }).to be true
 | |
|             end
 | |
|           end
 | |
| 
 | |
|           context 'with only_other_accounts' do
 | |
|             let(:only_other_accounts) { 'true' }
 | |
| 
 | |
|             it 'returns items with other public or unlisted replies' do
 | |
|               json = body_as_json
 | |
| 
 | |
|               expect(json[:first]).to be_a Hash
 | |
|               expect(json[:first][:items]).to be_an Array
 | |
|               expect(json[:first][:items].size).to eq 2
 | |
|               expect(json[:first][:items].all? { |item| item[:to].include?(ActivityPub::TagManager::COLLECTIONS[:public]) || item[:cc].include?(ActivityPub::TagManager::COLLECTIONS[:public]) }).to be true
 | |
|             end
 | |
| 
 | |
|             context 'with remote responses' do
 | |
|               let(:remote_reply_id) { 'foo' }
 | |
| 
 | |
|               it 'returned items are all inlined local toots or are ids' do
 | |
|                 json = body_as_json
 | |
| 
 | |
|                 expect(json[:first]).to be_a Hash
 | |
|                 expect(json[:first][:items]).to be_an Array
 | |
|                 expect(json[:first][:items].size).to eq 3
 | |
|                 expect(json[:first][:items].all? { |item| item.is_a?(Hash) ? ActivityPub::TagManager.instance.local_uri?(item[:id]) : item.is_a?(String) }).to be true
 | |
|                 expect(json[:first][:items]).to include remote_reply_id
 | |
|               end
 | |
|             end
 | |
|           end
 | |
|         end
 | |
| 
 | |
|         context 'when status is private' do
 | |
|           let(:parent_visibility) { :private }
 | |
| 
 | |
|           it 'returns http not found' do
 | |
|             expect(response).to have_http_status(404)
 | |
|           end
 | |
|         end
 | |
| 
 | |
|         context 'when status is direct' do
 | |
|           let(:parent_visibility) { :direct }
 | |
| 
 | |
|           it 'returns http not found' do
 | |
|             expect(response).to have_http_status(404)
 | |
|           end
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       context 'when signed request account is blocked' do
 | |
|         before do
 | |
|           status.account.block!(remote_account)
 | |
|           get :index, params: { account_username: status.account.username, status_id: status.id }
 | |
|         end
 | |
| 
 | |
|         context 'when status is public' do
 | |
|           let(:parent_visibility) { :public }
 | |
| 
 | |
|           it 'returns http not found' do
 | |
|             expect(response).to have_http_status(404)
 | |
|           end
 | |
|         end
 | |
| 
 | |
|         context 'when status is private' do
 | |
|           let(:parent_visibility) { :private }
 | |
| 
 | |
|           it 'returns http not found' do
 | |
|             expect(response).to have_http_status(404)
 | |
|           end
 | |
|         end
 | |
| 
 | |
|         context 'when status is direct' do
 | |
|           let(:parent_visibility) { :direct }
 | |
| 
 | |
|           it 'returns http not found' do
 | |
|             expect(response).to have_http_status(404)
 | |
|           end
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       context 'when signed request account is domain blocked' do
 | |
|         before do
 | |
|           status.account.block_domain!(remote_account.domain)
 | |
|           get :index, params: { account_username: status.account.username, status_id: status.id }
 | |
|         end
 | |
| 
 | |
|         context 'when status is public' do
 | |
|           let(:parent_visibility) { :public }
 | |
| 
 | |
|           it 'returns http not found' do
 | |
|             expect(response).to have_http_status(404)
 | |
|           end
 | |
|         end
 | |
| 
 | |
|         context 'when status is private' do
 | |
|           let(:parent_visibility) { :private }
 | |
| 
 | |
|           it 'returns http not found' do
 | |
|             expect(response).to have_http_status(404)
 | |
|           end
 | |
|         end
 | |
| 
 | |
|         context 'when status is direct' do
 | |
|           let(:parent_visibility) { :direct }
 | |
| 
 | |
|           it 'returns http not found' do
 | |
|             expect(response).to have_http_status(404)
 | |
|           end
 | |
|         end
 | |
|       end
 | |
|     end
 | |
|   end
 | |
| end
 |