* create account_identity_proofs table * add endpoint for keybase to check local proofs * add async task to update validity and liveness of proofs from keybase * first pass keybase proof CRUD * second pass keybase proof creation * clean up proof list and add badges * add avatar url to keybase api * Always highlight the “Identity Proofs” navigation item when interacting with proofs. * Update translations. * Add profile URL. * Reorder proofs. * Add proofs to bio. * Update settings/identity_proofs front-end. * Use `link_to`. * Only encode query params if they exist. URLs without params had a trailing `?`. * Only show live proofs. * change valid to active in proof list and update liveness before displaying * minor fixes * add keybase config at well-known path * extremely naive feature flagging off the identity proof UI * fixes for rubocop * make identity proofs page resilient to potential keybase issues * normalize i18n * tweaks for brakeman * remove two unused translations * cleanup and add more localizations * make keybase_contacts an admin setting * fix ExternalProofService my_domain * use Addressable::URI in identity proofs * use active model serializer for keybase proof config * more cleanup of keybase proof config * rename proof is_valid and is_live to proof_valid and proof_live * cleanup * assorted tweaks for more robust communication with keybase * Clean up * Small fixes * Display verified identity identically to verified links * Clean up unused CSS * Add caching for Keybase avatar URLs * Remove keybase_contacts setting
		
			
				
	
	
		
			112 lines
		
	
	
	
		
			4 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
			
		
		
	
	
			112 lines
		
	
	
	
		
			4 KiB
		
	
	
	
		
			Ruby
		
	
	
	
	
	
| require 'rails_helper'
 | |
| 
 | |
| describe Settings::IdentityProofsController do
 | |
|   render_views
 | |
| 
 | |
|   let(:user) { Fabricate(:user) }
 | |
|   let(:valid_token) { '1'*66 }
 | |
|   let(:kbname) { 'kbuser' }
 | |
|   let(:provider) { 'keybase' }
 | |
|   let(:findable_id) { Faker::Number.number(5) }
 | |
|   let(:unfindable_id) { Faker::Number.number(5) }
 | |
|   let(:postable_params) do
 | |
|     { account_identity_proof: { provider: provider, provider_username: kbname, token: valid_token } }
 | |
|   end
 | |
| 
 | |
|   before do
 | |
|     allow_any_instance_of(ProofProvider::Keybase::Verifier).to receive(:status) { { 'proof_valid' => true, 'proof_live' => true } }
 | |
|     sign_in user, scope: :user
 | |
|   end
 | |
| 
 | |
|   describe 'new proof creation' do
 | |
|     context 'GET #new with no existing proofs' do
 | |
|       it 'redirects to :index' do
 | |
|         get :new
 | |
|         expect(response).to redirect_to settings_identity_proofs_path
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     context 'POST #create' do
 | |
|       context 'when saving works' do
 | |
|         before do
 | |
|           allow(ProofProvider::Keybase::Worker).to receive(:perform_async)
 | |
|           allow_any_instance_of(ProofProvider::Keybase::Verifier).to receive(:valid?) { true }
 | |
|           allow_any_instance_of(AccountIdentityProof).to receive(:on_success_path) { root_url }
 | |
|         end
 | |
| 
 | |
|         it 'serializes a ProofProvider::Keybase::Worker' do
 | |
|           expect(ProofProvider::Keybase::Worker).to receive(:perform_async)
 | |
|           post :create, params: postable_params
 | |
|         end
 | |
| 
 | |
|         it 'delegates redirection to the proof provider' do
 | |
|           expect_any_instance_of(AccountIdentityProof).to receive(:on_success_path)
 | |
|           post :create, params: postable_params
 | |
|           expect(response).to redirect_to root_url
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       context 'when saving fails' do
 | |
|         before do
 | |
|           allow_any_instance_of(ProofProvider::Keybase::Verifier).to receive(:valid?) { false }
 | |
|         end
 | |
| 
 | |
|         it 'redirects to :index' do
 | |
|           post :create, params: postable_params
 | |
|           expect(response).to redirect_to settings_identity_proofs_path
 | |
|         end
 | |
| 
 | |
|         it 'flashes a helpful message' do
 | |
|           post :create, params: postable_params
 | |
|           expect(flash[:alert]).to eq I18n.t('identity_proofs.errors.failed', provider: 'Keybase')
 | |
|         end
 | |
|       end
 | |
| 
 | |
|       context 'it can also do an update if the provider and username match an existing proof' do
 | |
|         before do
 | |
|           allow_any_instance_of(ProofProvider::Keybase::Verifier).to receive(:valid?) { true }
 | |
|           allow(ProofProvider::Keybase::Worker).to receive(:perform_async)
 | |
|           Fabricate(:account_identity_proof, account: user.account, provider: provider, provider_username: kbname)
 | |
|           allow_any_instance_of(AccountIdentityProof).to receive(:on_success_path) { root_url }
 | |
|         end
 | |
| 
 | |
|         it 'calls update with the new token' do
 | |
|           expect_any_instance_of(AccountIdentityProof).to receive(:save) do |proof|
 | |
|             expect(proof.token).to eq valid_token
 | |
|           end
 | |
| 
 | |
|           post :create, params: postable_params
 | |
|         end
 | |
|       end
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   describe 'GET #index' do
 | |
|     context 'with no existing proofs' do
 | |
|       it 'shows the helpful explanation' do
 | |
|         get :index
 | |
|         expect(response.body).to match I18n.t('identity_proofs.explanation_html')
 | |
|       end
 | |
|     end
 | |
| 
 | |
|     context 'with two proofs' do
 | |
|       before do
 | |
|         allow_any_instance_of(ProofProvider::Keybase::Verifier).to receive(:valid?) { true }
 | |
|         @proof1 = Fabricate(:account_identity_proof, account: user.account)
 | |
|         @proof2 = Fabricate(:account_identity_proof, account: user.account)
 | |
|         allow_any_instance_of(AccountIdentityProof).to receive(:badge) { double(avatar_url: '', profile_url: '', proof_url: '') }
 | |
|         allow_any_instance_of(AccountIdentityProof).to receive(:refresh!) { }
 | |
|       end
 | |
| 
 | |
|       it 'has the first proof username on the page' do
 | |
|         get :index
 | |
|         expect(response.body).to match /#{Regexp.quote(@proof1.provider_username)}/
 | |
|       end
 | |
| 
 | |
|       it 'has the second proof username on the page' do
 | |
|         get :index
 | |
|         expect(response.body).to match /#{Regexp.quote(@proof2.provider_username)}/
 | |
|       end
 | |
|     end
 | |
|   end
 | |
| end
 |