Commit graph

5626 commits

Author SHA1 Message Date
Gô Shoemake
c6d5ea8695 Fix column headers accessibility (#6199)
* Fix accessibility of column headers

As a screen reader user new to Mastodon, I encountered the following issues with the column headers as designed:
 * Jumping between them was difficult. FOr instance, passing my home timeline to reach notification settings was difficult to impossible, especially considering infinite scrolling.
 * There doesn't appear to be any means for triggering the control via the keyboard. the `titleClick` handler only responds to mouse clicks.
 * I didn't even realize there was a Settings toggle until I made this change.

Thanks for using ARIA in your designs. It's a huge help. But adding a `button` role doesn't add keyboard handling and other button behavior. Also, because the role was on the heading container, it obscured the controls within the container itself. This fix resolve that. It also exposes the headings as headings rather than buttons, enabling skipping columns by using screen readers' heading navigation commands.

Since I myself am blind, if this fix requires additional visual styling, I'd like help applying that so it can be merged. I'd consider it an essential accessibility fix for my and other blind users' existence on the platform. Thanks!

* Styling fixes

* Fixed overflow issue
2018-01-15 04:33:06 +01:00
kibi!
7a692fe499 Increase priority of favstar gold 2018-01-14 16:05:44 -08:00
kibi!
28be50d95e Fixes to notification styling 2018-01-14 15:48:54 -08:00
kibi!
919caa6e1c Fixes to drawer and CWs 2018-01-14 15:31:00 -08:00
beatrix
5ded1fc5b8 Merge pull request #329 from KnzkDev/scss-refactor
SCSS Refactor
2018-01-14 17:48:02 -05:00
beatrix
093cc02c84 Merge pull request #328 from glitch-soc/feature/glitchy-elephant-friend
Add glitchy elephant friend
2018-01-14 17:40:27 -05:00
kibi!
e106f0be6d Oops this should have been a part of last commit 2018-01-14 14:21:41 -08:00
kibi!
df2f1344fa Fixes onboarding modal (#318) 2018-01-14 14:13:24 -08:00
kibi!
8399fba7f2 Fixed autocollapse detection 2018-01-14 13:29:51 -08:00
David Yip
7333a28191 Fix eslint errors. #294. 2018-01-14 05:56:43 -06:00
David Yip
20a82bf6a3 Run slightly less afoul of accessibility checks. #294.
This makes the clickable element an interactive element, but doesn't add
alt text and makes it not-obvious that you can click the elefriend.  On
one hand, this goes against good practice; on the other hand, it's not
*supposed* to be obvious that you can click the elefriend.
2018-01-14 05:07:08 -06:00
David Yip
7ccde6b46b Introduce a bit of luck into the elefriend selection. #294. 2018-01-14 04:46:21 -06:00
David Yip
bbfeb688e5 Add wave background; blend elefriend in a bit more. #294. 2018-01-14 04:00:21 -06:00
David Yip
1da6d12ea7 Bind click event to elefriend cycling. #294. 2018-01-14 03:35:25 -06:00
David Yip
e018b6c44c Set glitchy elephant friend variant in initial state. #294.
Also lay some groundwork needed to interactively change the
glitchfriend.

The codebase uses "elefriend" because it's shorter and didn't require me
to realign the actions in actions/compose.js.  Same idea, though.
2018-01-14 03:06:11 -06:00
David Yip
5b4f9858e6 Add the shrinking glitchy elefriend. #294. 2018-01-13 21:27:39 -06:00
David Yip
a6eeda658c Prototype out glitchy elephant friend. #294.
Glitched elephant friends kindly provided by @ncls7615.
2018-01-13 21:27:14 -06:00
ncls7615
808ace389f Fix collapsed toot style 2018-01-14 11:13:55 +09:00
ncls7615
3a5ecab183 Fix un-fullwidth media style 2018-01-14 11:07:32 +09:00
ncls7615
75ab24dcea Fix media detailed style 2018-01-14 10:38:51 +09:00
ncls7615
8709608e10 Fix confirmation modal bug 2018-01-14 09:51:01 +09:00
ncls7615
3ccbe066f0 Fix letterbox bug 2018-01-14 09:25:35 +09:00
ncls7615
80c899153f Improve scss refactor 5 2018-01-14 09:17:38 +09:00
ncls7615
a263178cf3 Improve scss refactor 4 2018-01-14 09:12:10 +09:00
ncls7615
25f7568a7e Improve scss refactor 3 2018-01-14 08:47:59 +09:00
ncls7615
090d7c1807 Improve scss refactor 2 2018-01-14 07:48:18 +09:00
ncls7615
4d9133003f Improve scss refactor 1 2018-01-14 07:18:50 +09:00
ncls7615
75af54925a Fix padded-blocks error 2018-01-14 04:12:41 +09:00
ncls7615
9e7150c6fa Initial scss refactor 2018-01-14 03:41:20 +09:00
beatrix
a9bfc5b3c5 Merge pull request #324 from glitch-soc/load-public-on-admin
Load public javascripts on admin pages
2018-01-12 23:52:41 -05:00
Gô Shoemake
64f483cc0f load public.js on vanilla#admin 2018-01-12 18:52:53 -08:00
Gô Shoemake
056f52edac Load packs/public.js for glitch#admin 2018-01-12 18:51:52 -08:00
David Yip
430f9c37ea Merge remote-tracking branch 'remotes/origin/fix-column-headers-accessibility' 2018-01-12 20:10:58 -06:00
beatrix
7837d2c49f Merge pull request #322 from m4sk1n/glitch-soc-pl
i18n: Update Polish translation
2018-01-12 18:16:31 -05:00
Marcin Mikołajczak
6be6f6f5bd i18n: Update Polish translation
Signed-off-by: Marcin Mikołajczak <me@m4sk.in>
2018-01-12 23:08:51 +01:00
David Yip
895a578030 Merge pull request #321 from KnzkDev/fix/dropdown-text
Fix dropdown item text
2018-01-12 09:09:10 -06:00
ncls7615
327c9e96e0 Fix dropdown text 2018-01-12 23:18:25 +09:00
Jenkins
e6049e6fd0 Merge remote-tracking branch 'tootsuite/master' into glitchsoc/master 2018-01-12 02:17:15 +00:00
Jeong Arm
73b6f2ebe9 Handle sessions that can't be translated (#6245)
* Handle sessions that can't be translated

This commit fixes #6165.

* Fix typo
2018-01-12 02:44:28 +01:00
David Yip
5ed533dffd Merge pull request #320 from glitch-soc/dockerfile-stack-space
dockerfile: Give more stack space to /sbin/tini
2018-01-11 04:25:26 -06:00
David Yip
b6d0dcc5d3 dockerfile: Give more stack space to /sbin/tini.
/sbin/tini ends up running the Sass compiler, which seems to need a
larger thread stack size than the musl default.  This patch incorporates
a fix from
https://raw.githubusercontent.com/jubel-han/dockerfiles/master/common/stack-fix.c,
as described in https://github.com/sass/node-sass/issues/2031.
2018-01-11 04:09:16 -06:00
David Yip
31aad49ad6 Merge pull request #319 from glitch-soc/317-attempt-to-switch-flavors-raises-actioncontroller-parametermissing
Fix #317: Attempting to switch flavors raises ActionController::ParameterMissing
2018-01-10 12:49:43 -06:00
David Yip
53854707ce Thank you, Officer Murphy 2018-01-10 12:10:43 -06:00
David Yip
ec1199404c The flavour parameter is unused, so omit it (#317) 2018-01-10 12:09:42 -06:00
David Yip
28e652d35d Allow for user object to be empty. Fixes #317.
If a flavour has only one skin, the skin selector will be omitted.  This
omits the user[setting_skin] field, and because that's the only
user[...] field on the page, the entire user object will not be present
in the request handler's params object.

This commit accounts for that scenario by avoiding params.require(:user)
and instead picking out what we need from the params hash.
2018-01-10 12:09:42 -06:00
David Yip
eecdc3e6a7 Add examples based on errors seen in #317 2018-01-10 12:09:41 -06:00
David Yip
dbf88612e3 Merge pull request #316 from glitch-soc/fix-async
Fix glitch async chunks
2018-01-09 18:30:45 -06:00
kibigo!
c4d63ba442 Renamed glitch async chunks 2018-01-09 16:26:14 -08:00
David Yip
7852fc7706 Merge pull request #314 from chriswmartin/merge-vanilla-updates-2
Merge vanilla updates into glitch - round 2
2018-01-09 17:01:23 -06:00
David Yip
1a7f8eb723 Merge remote-tracking branch 'origin/master' into merge-upstream
Conflicts:
	db/schema.rb
2018-01-09 14:16:45 -06:00