Nick Schonning
f6fd5e4ad0
Autofix Rubocop Style/ConcatArrayLiterals ( #23755 )
2023-05-04 05:57:40 +02:00
Matt Jankowski
53682a7b4f
Fix Performance/DeletePrefix cop ( #24796 )
2023-05-02 21:07:45 +02:00
Matt Jankowski
4d1f9d4278
Rename with_lock
to with_redis_lock
to avoid confusion with ActiveRecord's method ( #24741 )
2023-05-02 18:16:07 +02:00
Matt Jankowski
276a0f7ff9
Fix Performance/Count cop ( #24793 )
2023-05-02 18:06:43 +02:00
Matt Jankowski
621e53f8fc
Fix Performance/Sum cop ( #24788 )
2023-05-02 16:10:40 +02:00
Matt Jankowski
182bb4595f
Fix Lint/DuplicateBranch cop ( #24766 )
2023-05-02 12:57:11 +02:00
Claire
abce7cf2b9
Rewrite import feature ( #21054 )
2023-05-02 12:08:48 +02:00
dependabot[bot]
c943082b1b
Bump connection_pool from 2.3.0 to 2.4.0 ( #24290 )
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-04-30 15:45:02 +09:00
Nick Schonning
519ae8c0c6
Drop EOL Ruby 2.7 ( #24237 )
2023-04-27 01:46:18 +02:00
Matt Jankowski
f01a643897
Remove instance variables from helper usage ( #24203 )
2023-04-23 22:35:54 +02:00
Eugen Rochko
c75fccf033
Change user settings to be stored in a more optimal way ( #23630 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2023-03-30 14:44:00 +02:00
Matt Jankowski
4e6cf24ce9
Update retention model sql query ( #24249 )
2023-03-26 00:37:57 +01:00
Claire
3b17f2f718
Add warning for object storage misconfiguration ( #24137 )
2023-03-16 22:47:01 +01:00
Christian Schmidt
7583523bf0
Replace Status#translatable?
with language matrix in separate endpoint ( #24037 )
2023-03-16 11:07:24 +01:00
Eugen Rochko
f0734513f4
Refactor monkey-patching of PrivateAddressCheck
( #24122 )
2023-03-16 04:33:38 +01:00
Claire
bde1c7aa96
Fix dashboard crash on ElasticSearch server error ( #23751 )
2023-03-15 04:01:49 +01:00
Claire
23bce96f0c
Change sidekiq-bulk's batch size from 10,000 to 1,000 jobs in one Redis call ( #24034 )
2023-03-15 03:45:15 +01:00
Christian Schmidt
170d3a0bc8
Unescape HTML entities ( #24019 )
2023-03-08 19:56:41 +01:00
Matt Jankowski
8ea6707b2b
Remove unused TOCGenerator ( #23986 )
2023-03-06 17:33:58 +01:00
Jean byroot Boussier
08c2938b4a
Upgrade to latest redis-rb 4.x and fix deprecations ( #23616 )
...
Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
2023-03-04 16:38:28 +01:00
Christian Schmidt
cc0c37cd69
Only offer translation for supported languages ( #23879 )
2023-03-03 21:06:31 +01:00
Nick Schonning
247bf6e812
Enable Rubocop Style/StringConcatenation defaults ( #23792 )
2023-02-22 09:54:36 +09:00
Nick Schonning
dd63a919f0
Autofix Rubocop Style/RescueStandardError ( #23745 )
2023-02-20 11:01:20 +01:00
Nick Schonning
e6312104c7
Autofix Rubocop remaining Layout rules ( #23679 )
2023-02-20 06:58:28 +01:00
Nick Schonning
b8f17330ea
Autofix Rubocop Rails/Pluck ( #23730 )
2023-02-20 02:28:40 +01:00
Nick Schonning
be1ec56c6d
Autofix Rubocop Style/StringLiterals ( #23695 )
2023-02-19 07:38:14 +09:00
Nick Schonning
49f1168050
Autofix Rubocop Style/RedundantBegin ( #23703 )
2023-02-19 07:09:40 +09:00
Nick Schonning
793f8c7dd5
Autofix Rubocop Style/IfUnlessModifier ( #23697 )
2023-02-18 12:37:47 +01:00
Nick Schonning
4553bc78ba
Autofix Rubocop Style/PerlBackrefs ( #23649 )
2023-02-18 14:20:20 +09:00
Nick Schonning
b7d4391c4d
Autofix Rubocop Lint/AmbiguousOperatorPrecedence ( #23681 )
2023-02-18 04:30:23 +01:00
Nick Schonning
a71a0802d6
Autofix Rubocop Lint/SymbolConversion ( #23683 )
2023-02-18 03:23:49 +01:00
Nick Schonning
31ca76fe2c
Run rubocop formatting except line length ( #23632 )
2023-02-18 06:56:20 +09:00
Claire
ea4cffac37
Fix unbounded recursion in post discovery ( #23506 )
...
* Add a limit to how many posts can get fetched as a result of a single request
* Add tests
* Always pass `request_id` when processing `Announce` activities
---------
Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>
2023-02-10 22:16:37 +01:00
Nick Schonning
ae45c9ccd4
Apply Rubocop Rails/WhereNot ( #23448 )
...
* Apply Rubocop Rails/WhereNot
* Update spec for where.not
2023-02-08 10:39:57 +01:00
Nick Schonning
4a49c50e64
Apply Rubocop Performance/BlockGivenWithExplicitBlock ( #23441 )
...
* Apply Rubocop Performance/BlockGivenWithExplicitBlock
* Unprefix used block parameter
2023-02-08 10:36:23 +01:00
Nick Schonning
67a6f688ca
Apply Rubocop Performance/StringIdentifierArgument ( #23444 )
2023-02-08 02:36:20 +01:00
Nick Schonning
6af127a98e
Apply Rubocop Performance/DoubleStartEndWith ( #23442 )
2023-02-08 10:06:48 +09:00
Nick Schonning
38ec6d27d8
Autofix Rails/EagerEvaluationLogMessage ( #23429 )
...
* Autofix Rails/EagerEvaluationLogMessage
* Update spec for debug block syntax
2023-02-07 03:44:36 +01:00
Eugen Rochko
502c919bfd
Change number of stored items in home feed from 400 to 800 ( #23349 )
2023-02-01 11:24:22 +01:00
Claire
ae94782edb
Fix spurious admin dashboard warning when using ElasticSearch 7.x ( #23064 )
...
Some 7.x ElasticSearch versions support some 6.x nodes, thus the version check
is inadequate. I am not sure there is a good way to check if a server
implements all the 7.x APIs, so check server version and minimum wire version
instead.
2023-01-18 16:21:48 +01:00
Markus Unterwaditzer
b7f37e68ad
fix: allow verification when page size exceeds 1MB (using HTML5 parser) ( #22879 )
...
* fix: allow verification when page size exceeds 1MB
Truncates the page after 1MB instead
Closes #15316
* switch to HTML5 parser, fix rubocop errors
* undo rubocop fixes
Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com>
2023-01-11 21:59:13 +01:00
Kaspar V
1cd04e5d77
Fix/remove calling private method with send in model ( #22951 )
...
* fix(status): remove send usage for private unlink_from_conversations
- make unlink_from_conversations public method
- rename unlink_from_conversations to unlink_from_conversations!
- fix send call on private method in statuses_vacuum and batched_remove_status_service
* fix(feeds_vacuum): replace find_in_batches with in_batches
because active record query results should be a little more efficient than
itterating with map and each. Postgres can grasp such lists of ids much quicker
than ruby can.
Will probably make allmost no difference, but cannot hurt either.
2023-01-11 21:57:24 +01:00
Vyr Cossont
b2c7ca296c
Check OpenSearch compatibility version instead of regular version ( #22422 )
...
Fixes #18535 .
2023-01-05 13:44:31 +01:00
Jeong Arm
5180ae5bf6
Fix home TL could contain post from who blocked me ( #22849 )
...
* Fix home tl contains post from who blocked me
* Add test
* Fix feed_manager's build_crutches
blocked_by was not includes status' owner
* Add test for status from I blocked
* Fix typo
2023-01-05 13:30:38 +01:00
Claire
e1d8048bc4
Fix status cache hydration discrepancy ( #19879 )
2022-12-15 18:55:55 +01:00
Claire
c83083eef5
Fix inability to use local LibreTranslate without setting ALLOWED_PRIVATE_ADDRESSES ( #21926 )
...
Fixes #20029
2022-12-15 17:04:38 +01:00
s0
289097866b
Fix crash in elasticsearch_check.rb ( #21006 )
...
Nil unwrap causes the admin dashboard to crash/500 when the Chewy client info version number value is nil.
This occurs when running another ES-compatible backend such as MeiliSearch.
Obviously it would be good for chewy to recognise upstream but at least avoiding the crash would be fine.
2022-12-15 15:56:48 +01:00
Jeong Arm
53b6623136
Don't delivery a reply to domains which are blocked by author ( #22117 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2022-12-15 15:52:06 +01:00
Claire
aec7de494f
Fix unbounded recursion in account discovery ( #22025 )
...
* Fix trying to fetch posts from other users when fetching featured posts
* Rate-limit discovery of new subdomains
* Put a limit on recursively discovering new accounts
2022-12-07 00:15:24 +01:00
Claire
1bef772764
Fix some performance issues with /admin/instances ( #21907 )
...
/admin/instances?availability=failing remains wholly unefficient
2022-12-01 10:32:10 +01:00