Commit graph

39694 commits

Author SHA1 Message Date
Eugen Rochko
ed867eca9d
Move e-mail digest task to sidekiq, reduce workload, improve hint (#6252) 2018-01-15 04:34:28 +01:00
Gô Shoemake
c6d5ea8695 Fix column headers accessibility (#6199)
* Fix accessibility of column headers

As a screen reader user new to Mastodon, I encountered the following issues with the column headers as designed:
 * Jumping between them was difficult. FOr instance, passing my home timeline to reach notification settings was difficult to impossible, especially considering infinite scrolling.
 * There doesn't appear to be any means for triggering the control via the keyboard. the `titleClick` handler only responds to mouse clicks.
 * I didn't even realize there was a Settings toggle until I made this change.

Thanks for using ARIA in your designs. It's a huge help. But adding a `button` role doesn't add keyboard handling and other button behavior. Also, because the role was on the heading container, it obscured the controls within the container itself. This fix resolve that. It also exposes the headings as headings rather than buttons, enabling skipping columns by using screen readers' heading navigation commands.

Since I myself am blind, if this fix requires additional visual styling, I'd like help applying that so it can be merged. I'd consider it an essential accessibility fix for my and other blind users' existence on the platform. Thanks!

* Styling fixes

* Fixed overflow issue
2018-01-15 04:33:06 +01:00
Gô Shoemake
08e4c78e78 Fix column headers accessibility (#6199)
* Fix accessibility of column headers

As a screen reader user new to Mastodon, I encountered the following issues with the column headers as designed:
 * Jumping between them was difficult. FOr instance, passing my home timeline to reach notification settings was difficult to impossible, especially considering infinite scrolling.
 * There doesn't appear to be any means for triggering the control via the keyboard. the `titleClick` handler only responds to mouse clicks.
 * I didn't even realize there was a Settings toggle until I made this change.

Thanks for using ARIA in your designs. It's a huge help. But adding a `button` role doesn't add keyboard handling and other button behavior. Also, because the role was on the heading container, it obscured the controls within the container itself. This fix resolve that. It also exposes the headings as headings rather than buttons, enabling skipping columns by using screen readers' heading navigation commands.

Since I myself am blind, if this fix requires additional visual styling, I'd like help applying that so it can be merged. I'd consider it an essential accessibility fix for my and other blind users' existence on the platform. Thanks!

* Styling fixes

* Fixed overflow issue
2018-01-15 04:33:06 +01:00
kibi!
7a692fe499 Increase priority of favstar gold 2018-01-14 16:05:44 -08:00
kibi!
8ee6ed358f Increase priority of favstar gold 2018-01-14 16:05:44 -08:00
kibi!
28be50d95e Fixes to notification styling 2018-01-14 15:48:54 -08:00
kibi!
1ee0e91fb6 Fixes to notification styling 2018-01-14 15:48:54 -08:00
kibi!
919caa6e1c Fixes to drawer and CWs 2018-01-14 15:31:00 -08:00
kibi!
b9f4896830 Fixes to drawer and CWs 2018-01-14 15:31:00 -08:00
beatrix
5ded1fc5b8 Merge pull request #329 from KnzkDev/scss-refactor
SCSS Refactor
2018-01-14 17:48:02 -05:00
beatrix
cd6674606f
Merge pull request #329 from KnzkDev/scss-refactor
SCSS Refactor
2018-01-14 17:48:02 -05:00
beatrix
093cc02c84 Merge pull request #328 from glitch-soc/feature/glitchy-elephant-friend
Add glitchy elephant friend
2018-01-14 17:40:27 -05:00
beatrix
39f231f3da
Merge pull request #328 from glitch-soc/feature/glitchy-elephant-friend
Add glitchy elephant friend
2018-01-14 17:40:27 -05:00
kibi!
e106f0be6d Oops this should have been a part of last commit 2018-01-14 14:21:41 -08:00
kibi!
0fb3bd09e9 Oops this should have been a part of last commit 2018-01-14 14:21:41 -08:00
kibi!
df2f1344fa Fixes onboarding modal (#318) 2018-01-14 14:13:24 -08:00
kibi!
1fa03e026a Fixes onboarding modal (#318) 2018-01-14 14:13:24 -08:00
kibi!
8399fba7f2 Fixed autocollapse detection 2018-01-14 13:29:51 -08:00
kibi!
a5931e1f48 Fixed autocollapse detection 2018-01-14 13:29:51 -08:00
David Yip
7333a28191 Fix eslint errors. #294. 2018-01-14 05:56:43 -06:00
David Yip
c2669f93d0
Fix eslint errors. #294. 2018-01-14 05:56:43 -06:00
David Yip
20a82bf6a3 Run slightly less afoul of accessibility checks. #294.
This makes the clickable element an interactive element, but doesn't add
alt text and makes it not-obvious that you can click the elefriend.  On
one hand, this goes against good practice; on the other hand, it's not
*supposed* to be obvious that you can click the elefriend.
2018-01-14 05:07:08 -06:00
David Yip
756a9cd139
Run slightly less afoul of accessibility checks. #294.
This makes the clickable element an interactive element, but doesn't add
alt text and makes it not-obvious that you can click the elefriend.  On
one hand, this goes against good practice; on the other hand, it's not
*supposed* to be obvious that you can click the elefriend.
2018-01-14 05:07:08 -06:00
David Yip
7ccde6b46b Introduce a bit of luck into the elefriend selection. #294. 2018-01-14 04:46:21 -06:00
David Yip
e64cc311dd
Introduce a bit of luck into the elefriend selection. #294. 2018-01-14 04:46:21 -06:00
David Yip
bbfeb688e5 Add wave background; blend elefriend in a bit more. #294. 2018-01-14 04:00:21 -06:00
David Yip
53cbc9933e
Add wave background; blend elefriend in a bit more. #294. 2018-01-14 04:00:21 -06:00
David Yip
1da6d12ea7 Bind click event to elefriend cycling. #294. 2018-01-14 03:35:25 -06:00
David Yip
cd1377de7f
Bind click event to elefriend cycling. #294. 2018-01-14 03:35:25 -06:00
David Yip
e018b6c44c Set glitchy elephant friend variant in initial state. #294.
Also lay some groundwork needed to interactively change the
glitchfriend.

The codebase uses "elefriend" because it's shorter and didn't require me
to realign the actions in actions/compose.js.  Same idea, though.
2018-01-14 03:06:11 -06:00
David Yip
1dbb6b5e08
Set glitchy elephant friend variant in initial state. #294.
Also lay some groundwork needed to interactively change the
glitchfriend.

The codebase uses "elefriend" because it's shorter and didn't require me
to realign the actions in actions/compose.js.  Same idea, though.
2018-01-14 03:06:11 -06:00
David Yip
5b4f9858e6 Add the shrinking glitchy elefriend. #294. 2018-01-13 21:27:39 -06:00
David Yip
1e0b707018
Add the shrinking glitchy elefriend. #294. 2018-01-13 21:27:39 -06:00
David Yip
a6eeda658c Prototype out glitchy elephant friend. #294.
Glitched elephant friends kindly provided by @ncls7615.
2018-01-13 21:27:14 -06:00
David Yip
835eec8a4c
Prototype out glitchy elephant friend. #294.
Glitched elephant friends kindly provided by @ncls7615.
2018-01-13 21:27:14 -06:00
ncls7615
808ace389f Fix collapsed toot style 2018-01-14 11:13:55 +09:00
ncls7615
f9b08e2142
Fix collapsed toot style 2018-01-14 11:13:55 +09:00
ncls7615
3a5ecab183 Fix un-fullwidth media style 2018-01-14 11:07:32 +09:00
ncls7615
1ebe66b78c
Fix un-fullwidth media style 2018-01-14 11:07:32 +09:00
ncls7615
75ab24dcea Fix media detailed style 2018-01-14 10:38:51 +09:00
ncls7615
be2bac05aa
Fix media detailed style 2018-01-14 10:38:51 +09:00
ncls7615
8709608e10 Fix confirmation modal bug 2018-01-14 09:51:01 +09:00
ncls7615
b5476f6c75
Fix confirmation modal bug 2018-01-14 09:51:01 +09:00
ncls7615
3ccbe066f0 Fix letterbox bug 2018-01-14 09:25:35 +09:00
ncls7615
bc0524834e
Fix letterbox bug 2018-01-14 09:25:35 +09:00
ncls7615
80c899153f Improve scss refactor 5 2018-01-14 09:17:38 +09:00
ncls7615
6ecf81cacf
Improve scss refactor 5 2018-01-14 09:17:38 +09:00
ncls7615
a263178cf3 Improve scss refactor 4 2018-01-14 09:12:10 +09:00
ncls7615
64425dbb77
Improve scss refactor 4 2018-01-14 09:12:10 +09:00
ncls7615
25f7568a7e Improve scss refactor 3 2018-01-14 08:47:59 +09:00