Matt Jankowski
bdbc9d0036
Fix Rails/CompactBlank cop ( #24690 )
2 years ago
Matt Jankowski
2a78b65bfd
Fix Rails/I18nLocaleAssignment cop ( #24693 )
2 years ago
Matt Jankowski
e9e394fe57
Fix Rails/InverseOf cop ( #24732 )
2 years ago
Matt Jankowski
8a813615b0
Fix Rails/Output cop ( #24687 )
2 years ago
Matt Jankowski
78f29479ab
Fix Rails/Present cop ( #24688 )
2 years ago
Matt Jankowski
ba0a49b7f6
Fix Rails/ContentTag cop ( #24691 )
2 years ago
Matt Jankowski
390aa577e7
Fix Rails/ActionOrder cop ( #24692 )
2 years ago
Matt Jankowski
16e08228df
Fix Rails/SquishedSQLHeredocs cop ( #24694 )
2 years ago
Matt Jankowski
807ada7b39
Fix Rails/HttpPositionalArguments cop ( #24699 )
2 years ago
Matt Jankowski
f9fcde8205
Add pending spec for User.those_who_can ( #24724 )
2 years ago
Claire
498de92bc8
Merge branch 'main' into glitch-soc/merge-upstream
...
Conflicts:
- `.github/dependabot.yml`:
Updated upstream, removed in glitch-soc to disable noise.
Kept removed.
- `CODE_OF_CONDUCT.md`:
Upstream updated to a new version of the covenant, but I have not read it
yet, so kept unchanged.
- `Gemfile.lock`:
Not a real conflict, one upstream dependency updated textually too close to
the glitch-soc only `hcaptcha` dependency.
Applied upstream changes.
- `app/controllers/admin/base_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/controllers/application_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/controllers/disputes/base_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/controllers/relationships_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/controllers/statuses_cleanup_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/helpers/application_helper.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/javascript/mastodon/features/compose/components/compose_form.jsx`:
Upstream added a highlight animation for onboarding, while we changed the
max character limit.
Applied our local changes on top of upstream's new version.
- `app/views/layouts/application.html.haml`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `stylelint.config.js`:
Upstream added ignore paths, glitch-soc had extra ignore paths.
Added the same paths as upstream.
2 years ago
Nick Schonning
519ae8c0c6
Drop EOL Ruby 2.7 ( #24237 )
2 years ago
Nick Schonning
b36ccb2fac
Autofix Rubocop RSpec/MatchArray ( #24675 )
2 years ago
Nick Schonning
16cc6bc400
Autofix Rubocop RSpec/MatchArray ( #24050 )
2 years ago
Nick Schonning
28d554cc49
Autofix Rubocop Rails/ResponseParsedBody ( #24051 )
2 years ago
Matt Jankowski
f01a643897
Remove instance variables from helper usage ( #24203 )
2 years ago
Nick Schonning
91f0da8563
Autofix Rubocop Style/NumericLiterals ( #24468 )
2 years ago
Eugen Rochko
3ca64638d4
Refactor `Cache-Control` and `Vary` definitions ( #24347 )
2 years ago
Claire
0cbf19affd
Fix most rubocop issues ( #2165 )
...
* Run rubocop --autocorrect on app/, config/ and lib/, also manually fix some remaining style issues
* Run rubocop --autocorrect-all on db/
* Run rubocop --autocorrect-all on `spec/` and fix remaining issues
2 years ago
Nick Schonning
5f1a0f550b
Autofix Rubocop Rails/IgnoredColumnsAssignment ( #23761 )
2 years ago
Nick Schonning
2a0d2453b0
Autofix Rubocop Style/IdenticalConditionalBranches ( #24322 )
2 years ago
Nick Schonning
718cdb0286
Enable Rubocop Metrics/BlockLength with Excludes ( #24260 )
2 years ago
Eugen Rochko
c75fccf033
Change user settings to be stored in a more optimal way ( #23630 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Nick Schonning
2ed77774f7
Exclude files for Rubocop Metrics/ClassLength ( #24213 )
2 years ago
Matt Jankowski
7a82026971
Remove references to non-existent actions ( #24183 )
2 years ago
Vyr Cossont
d1b3f02926
Webhooks for local status.create, status.update, account.update ( #24133 )
2 years ago
Nick Schonning
8d05167e5f
Include config/ and update all rubcop deps ( #23963 )
2 years ago
Nick Schonning
c2821e2aa3
Ignore additional Style/OptionalBooleanParameter ( #24138 )
2 years ago
Matt Jankowski
10a4c16256
Roll back unintentionally activated rubocop rules ( #24132 )
...
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
2 years ago
Christian Schmidt
7583523bf0
Replace `Status#translatable?` with language matrix in separate endpoint ( #24037 )
2 years ago
Nick Schonning
8f638799ec
Regen rubocop-todo without Max shadowing ( #24076 )
2 years ago
Nick Schonning
0717d1b058
Autofix Rubocop Style/RedundantArgument ( #23798 )
2 years ago
Nick Schonning
6d0a49f4a4
Autofix Rubocop Style/PreferredHashMethods ( #23851 )
2 years ago
Nick Schonning
12cbdf36a9
Enable Rubocop Performance/DeleteSuffix ( #24077 )
2 years ago
Nick Schonning
7f17a44a6b
Enable RSpec/FilePath ( #23965 )
2 years ago
Matt Jankowski
7a8257b638
Coverage improvement round-out following up previous work ( #23987 )
2 years ago
Matt Jankowski
c5c1e07555
Serializers spec coverage ( #24017 )
2 years ago
Claire
370cff9a5d
Disable Style/SymbolArray ( #23921 )
2 years ago
Nick Schonning
19be243493
Autofix Rubocop Style/HashConversion ( #23852 )
2 years ago
Matt Jankowski
c759d6f31d
Remove unused HTML Validator ( #23866 )
2 years ago
Nick Schonning
1cdd7d6c8f
Rename ActivityPub Serializer Specs ( #23844 )
2 years ago
Nick Schonning
43a3812265
Fix mispelled spec filenames ( #23834 )
2 years ago
Nick Schonning
4f6ad6475e
Autofix Rubocop Rails/Blank ( #23765 )
2 years ago
Nick Schonning
eb6991cee1
Autofix Rubocop Rails/RootPathnameMethods ( #23760 )
2 years ago
Nick Schonning
247bf6e812
Enable Rubocop Style/StringConcatenation defaults ( #23792 )
2 years ago
Nick Schonning
a0e4d69c12
Autofix Rubocop Rails/FindById ( #23762 )
2 years ago
Nick Schonning
25cf99e513
Autofix Rubocop Security/IoMethods ( #23757 )
2 years ago
Nick Schonning
eed0829d3f
Autofix Rubocop Rails/WhereEquals ( #23759 )
2 years ago
Nick Schonning
dd63a919f0
Autofix Rubocop Style/RescueStandardError ( #23745 )
2 years ago
Nick Schonning
9376fccf91
Autofix Rubocop Style/SymbolProc ( #23742 )
2 years ago
Nick Schonning
9b3be79cb5
Autofix Rubocop Style/FormatString ( #23743 )
2 years ago
Nick Schonning
e6312104c7
Autofix Rubocop remaining Layout rules ( #23679 )
2 years ago
Nick Schonning
c08d9e5e5c
Autofix Rubocop Style/UnpackFirst ( #23741 )
2 years ago
Nick Schonning
a4cbfac4d9
Autofix Rubocop RSpec/BeEq ( #23740 )
2 years ago
Nick Schonning
c0f0c42326
Audofix Rubocop Style/WordArray ( #23739 )
2 years ago
Nick Schonning
754c417e29
Autofix Rubocop RSpec/LeadingSubject ( #23670 )
2 years ago
Nick Schonning
a1e0384fc5
Enable Rubocop RSpec/ExpectActual ( #23720 )
2 years ago
Nick Schonning
ac56c3971b
Autofix Rubocop RSpec/ImplicitSubject ( #23721 )
2 years ago
Nick Schonning
448f0929a7
Autofix Rubocop Rails/EnumHash ( #23737 )
2 years ago
Nick Schonning
06f8de2e34
Autofix Rubocop Style/ExplicitBlockArgument ( #23704 )
2 years ago
Nick Schonning
0d47dee648
Autofix Rubocops RSpec/ScatteredLet ( #23725 )
2 years ago
Nick Schonning
ae51248ffe
Enable Rubocop HTTP status rules ( #23717 )
2 years ago
Nick Schonning
f6c4699d73
Autofix Rubocop RSpec/EmptyLineAfterSubject ( #23719 )
2 years ago
Nick Schonning
181617e3d9
Autofix Rubocop Lint/UnusedBlockArgument ( #23712 )
2 years ago
Nick Schonning
a25f6522da
Enable Rubocop RSpec/NotToNot ( #23723 )
2 years ago
Nick Schonning
1de4bdbaf4
Autofix Rubocop RSpec/ReturnFromStub ( #23724 )
2 years ago
Nick Schonning
b8f17330ea
Autofix Rubocop Rails/Pluck ( #23730 )
2 years ago
Nick Schonning
483fabc53f
Autofix Rubocop Rails/RedundantForeignKey ( #23731 )
2 years ago
Nick Schonning
46d56d2403
Autofix Rubocop Style/EmptyMethod ( #23732 )
2 years ago
Nick Schonning
e08a42e1d7
Autofix Rubocop RSpec/EmptyLineAfterHook ( #23718 )
2 years ago
Nick Schonning
be1ec56c6d
Autofix Rubocop Style/StringLiterals ( #23695 )
2 years ago
Nick Schonning
28b19386c1
Autofix Rubocop RSpec/LetBeforeExamples ( #23671 )
2 years ago
Nick Schonning
bfc66a0454
Autofix Rubocop Style/EmptyLambdaParameter ( #23705 )
2 years ago
Nick Schonning
a63cb79201
Autofix Rubocop RSpec/EmptyLineAfterFinalLet ( #23707 )
2 years ago
Nick Schonning
49f1168050
Autofix Rubocop Style/RedundantBegin ( #23703 )
2 years ago
Nick Schonning
e9074c3eb5
Autofix Rubocop Style/BlockDelimiters ( #23706 )
2 years ago
Nick Schonning
2e4833b246
Autofix Rubocop RSpec/Capybara/FeatureMethods ( #23708 )
2 years ago
Nick Schonning
6988b04ec7
Autofix Rubocop Style/TrailingCommaInArrayLiteral ( #23692 )
2 years ago
Nick Schonning
4dc470fbee
Autofix Rubocop Style/TrailingCommaInHashLiteral ( #23693 )
2 years ago
Nick Schonning
a2129d336a
Autofix Rubocop RSpec/ExcessiveDocstringSpacing ( #23666 )
2 years ago
Nick Schonning
7f8439ee07
Autofix Rubocop Style/TrailingCommaInArguments ( #23694 )
2 years ago
Nick Schonning
3f9d7419d1
Autofix Rubocop Style/Lambda ( #23696 )
2 years ago
Nick Schonning
793f8c7dd5
Autofix Rubocop Style/IfUnlessModifier ( #23697 )
2 years ago
Nick Schonning
4553bc78ba
Autofix Rubocop Style/PerlBackrefs ( #23649 )
2 years ago
Nick Schonning
b7d4391c4d
Autofix Rubocop Lint/AmbiguousOperatorPrecedence ( #23681 )
2 years ago
Nick Schonning
5973a58281
Enable Lint/RedundantCopDisableDirective ( #23687 )
2 years ago
Nick Schonning
bc31a28361
Apply Rubocop Style/RedundantConstantBase ( #23463 )
2 years ago
Nick Schonning
35dbf602f2
Autofix Rubocop Lint/ParenthesesAsGroupedExpression ( #23682 )
2 years ago
Nick Schonning
c402904fa1
Enable Rubocop RSpec/HooksBeforeExamples ( #23668 )
2 years ago
Nick Schonning
298f61ecef
Autofix Rubocop Style/RedundantPercentQ ( #23651 )
2 years ago
Nick Schonning
f8947c2042
Autofix Rubocop RSpec/ExampleWording ( #23667 )
2 years ago
Nick Schonning
24f4789d2b
Enable Rubocop RSpec/MultipleDescribes ( #23672 )
2 years ago
Nick Schonning
92d606bc98
Autofix Rubocop RSpec/ClassCheck ( #23685 )
2 years ago
Nick Schonning
a71a0802d6
Autofix Rubocop Lint/SymbolConversion ( #23683 )
2 years ago
Nick Schonning
efcf9f0076
Autofix Rubocop Lint/AmbiguousOperator ( #23680 )
2 years ago
Nick Schonning
8fa4163574
Enable Rubocop Style/NumericLiterals ( #23647 )
2 years ago
Nick Schonning
31ca76fe2c
Run rubocop formatting except line length ( #23632 )
2 years ago
Nick Schonning
85b352d1c1
Autofix Rubocop Style/RaiseArgs ( #23650 )
2 years ago
Nick Schonning
a45f8ff02d
Autofix Rubocop RSpec/EmptyLineAfterExample ( #23661 )
2 years ago
Nick Schonning
284a6902cc
Autofix Rubocop RSpec/BeNil ( #23653 )
2 years ago