Daniel M Brasil
45d98959ac
Fix uncaught NoMethodError in POST `/api/v1/featured_tags` ( #25063 )
2 years ago
Claire
e13d2edd47
Fix “Authorized applications” inefficiently and incorrectly getting last use date ( #25060 )
2 years ago
Daniel M Brasil
ce8b5899ae
Fix POST `/api/v1/admin/domain_allows` returning 200 when no domain is specified ( #24958 )
2 years ago
Frankie Roberto
36a77748b4
Order sessions by most-recent to least-recently updated ( #25005 )
2 years ago
Claire
45ba9ada34
Fix race condition when reblogging a status ( #25016 )
2 years ago
Claire
bec6a1cad4
Add hCaptcha support ( #25019 )
2 years ago
Claire
e60414792d
Add polling and automatic redirection to `/start` on email confirmation ( #25013 )
2 years ago
Daniel M Brasil
433ab0c9a3
Fix uncaught NoMethodError error in `/api/v1/admin/canonical_email_blocks/test` ( #24947 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
zunda
c0ea33e3fc
Make it possible to upload audio and video to Heroku app ( #24866 )
2 years ago
Nick Schonning
569b39256b
Bump rubocop-rails 2.19.1 with update .rubocop_todo.yml ( #24469 )
2 years ago
Nick Schonning
d5a185d721
Autofix Rubocop Style/CaseLikeIf ( #23756 )
2 years ago
Matt Jankowski
08fb9d300a
Spec coverage for settings/preferences/* controllers ( #24825 )
2 years ago
Matt Jankowski
668a19a2f3
Fix Performance/DeletePrefix cop ( #24796 )
2 years ago
Matt Jankowski
f1c1dd0118
Rename `with_lock` to `with_redis_lock` to avoid confusion with ActiveRecord's method ( #24741 )
2 years ago
Claire
9189e90ff2
Add fallback redirection when getting a webfinger query `LOCAL_DOMAIN@LOCAL_DOMAIN` ( #23600 )
...
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
2 years ago
Claire
32a030dd74
Rewrite import feature ( #21054 )
2 years ago
Matt Jankowski
6e226f5a32
Fix Rails/ActionOrder cop ( #24692 )
2 years ago
Claire
faa336e3f7
Change logged-out WebUI HTML pages to be cached for a few seconds ( #24708 )
2 years ago
Claire
1c61869eed
Fix /api/v1/custom_emojis being cached even when unauthenticated API access is disallowed ( #24665 )
2 years ago
Claire
b0bf6216e6
Fix /api/v1/instance/domain_blocks being unconditionally cached ( #24662 )
2 years ago
Claire
62ab7506d6
Fix /actor needlessly reading session cookie and varying on Signature ( #24664 )
2 years ago
Claire
1419f90ef2
Fix some user-independent endpoints potentially reading session cookies ( #24650 )
2 years ago
Claire
276c39361b
Fix anonymous visitors getting a session cookie on first visit ( #24584 )
2 years ago
Eugen Rochko
6084461cd0
Change unauthenticated responses to be cached in REST API ( #24348 )
2 years ago
Claire
e9a79d46cd
Fix crash when SSO_ACCOUNT_SETTINGS is not defined ( #24628 )
2 years ago
Matt Jankowski
0a5f0a8b20
Remove instance variables from helper usage ( #24203 )
2 years ago
Claire
58a1b2e330
Fix caching logic with regards to Accept-Language, Cookie, and Signature ( #24604 )
2 years ago
Eugen Rochko
e98c86050a
Refactor `Cache-Control` and `Vary` definitions ( #24347 )
2 years ago
Robert R George
4db8230194
Add trend management to admin API ( #24257 )
2 years ago
Eugen Rochko
e5c0b16735
Add progress indicator to sign-up flow ( #24545 )
2 years ago
Matt Jankowski
d193bc8c5c
Remove unused methods in 2FA OTP Auth Controller ( #24220 )
2 years ago
Claire
9d08b81193
Fix user archive takeouts when using OpenStack Swift ( #24431 )
2 years ago
Claire
280fa3b2c0
Fix invalid/expired invites being processed on sign-up ( #24337 )
2 years ago
Eugen Rochko
a9b5598c97
Change user settings to be stored in a more optimal way ( #23630 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Claire
e084b5b82d
Fix user archive takeout when using OpenStack Swift or S3 providers with no ACL support ( #24200 )
2 years ago
Matt Jankowski
0663803348
Move link header setting to after_action ( #24251 )
2 years ago
Matt Jankowski
e633b26f4f
Add allow_other_host in redirects which may go outside app ( #24252 )
2 years ago
Claire
2626097869
Fix Rails cache namespace being overriden with `v2` for cached statuses ( #24202 )
2 years ago
Matt Jankowski
7bef11630d
Remove references to non-existent actions ( #24183 )
2 years ago
Jean byroot Boussier
160f38f03d
Workaround the ActiveRecord / Marshal serialization bug on Ruby 3.2 ( #24142 )
...
Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
2 years ago
CSDUMMI
d75a1e5054
Link to the Identity provider's account settings from the account settings ( #24100 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Eugen Rochko
75e5a6e437
Change user backups to use expiring URLs for download when possible ( #24136 )
2 years ago
Christian Schmidt
bd047acc35
Replace `Status#translatable?` with language matrix in separate endpoint ( #24037 )
2 years ago
Nick Schonning
25d36b6edd
Autofix Rubocop Style/RedundantArgument ( #23798 )
2 years ago
Claire
a232a1feb8
Fix misleading error code when receiving invalid WebAuthn credentials ( #23568 )
2 years ago
CSDUMMI
39c7236649
Redirect users to SLO at the IdP after logging them out of Mastodon. ( #24020 )
2 years ago
CSDUMMI
d258ec8e3b
Prefer the stored location as after_sign_in_path in Omniauth Callback Controller ( #24073 )
2 years ago
Claire
f8bb4d0d6b
Fix server error when failing to follow back followers from `/relationships` ( #23787 )
2 years ago
Claire
c2a046ded1
Fix “Remove all followers from the selected domains” being more destructive than it claims ( #23805 )
2 years ago
Nick Schonning
434770f580
Autofix Rubocop Rails/FindById ( #23762 )
2 years ago
Nick Schonning
717683d1c3
Autofix Rubocop remaining Layout rules ( #23679 )
2 years ago
Nick Schonning
aef0051fd0
Enable Rubocop HTTP status rules ( #23717 )
2 years ago
Nick Schonning
2177daeae9
Autofix Rubocop Style/RedundantBegin ( #23703 )
2 years ago
Nick Schonning
c38bd17657
Autofix Rubocop Style/TrailingCommaInArguments ( #23694 )
2 years ago
Nick Schonning
e2a3ebb271
Autofix Rubocop Style/IfUnlessModifier ( #23697 )
2 years ago
Nick Schonning
a6f77aa28a
Autofix Rubocop Lint/AmbiguousOperatorPrecedence ( #23681 )
2 years ago
Claire
d6930b3847
Add API parameter to safeguard unexpect mentions in new posts ( #18350 )
2 years ago
Claire
832595d1e7
Remove posts count and last posts from ActivityPub representation of hashtag collections ( #23460 )
2 years ago
Nick Schonning
f68bb52556
Apply Rubocop Style/NegatedIfElseCondition ( #23451 )
2 years ago
Nick Schonning
2e652aa81c
Apply Rubocop Performance/RedundantSplitRegexpArgument ( #23443 )
...
* Apply Rubocop Performance/RedundantSplitRegexpArgument
* Update app/controllers/concerns/signature_verification.rb
2 years ago
Claire
20a479ff7c
Change `POST /settings/applications/:id` to regenerate token on scopes change ( #23359 )
...
Fixes #23096
2 years ago
Eugen Rochko
21780c0204
Change notifications per page from 15 to 40 in REST API ( #23348 )
2 years ago
Claire
68dcbcb7bf
Add more specific error messages to HTTP signature verification ( #21617 )
...
* Return specific error on failure to parse Date header
* Add error message when preferredUsername is not set
* Change error report to be JSON and include more details
* Change error report to differentiate unknown account and failed refresh
* Add tests
2 years ago
Claire
343e1fe8e9
Add confirmation screen when handling reports ( #22375 )
...
* Add confirmation screen on moderation actions
* Add flash notice when a report has been processed
* Refactor tests
* Add tests
2 years ago
Claire
4b92e59f4f
Add support for editing media description and focus point of already-posted statuses ( #20878 )
...
* Add backend support for editing media attachments of existing posts
* Allow editing media attachments of already-posted toots
* Add tests
2 years ago
Claire
b034dc42be
Fix /api/v1/admin/trends/tags using wrong serializer ( #18943 )
...
* Fix /api/v1/admin/trends/tags using wrong serializer
Fix regression from #18641
* Only use `REST::Admin::TagSerializer` when the user can `manage_taxonomies`
* Fix admin trending hashtag component to not link if `id` is unknown
2 years ago
Claire
fcc4c9b34a
Change domain block CSV parsing to be more robust and handle more lists ( #21470 )
...
* Change domain block CSV parsing to be more robust and handle more lists
* Add some tests
* Improve domain block import validation and reporting
2 years ago
Carl Schwan
f33e22ae4c
Allow changing hide_collections setting with the api ( #22790 )
...
* Allow changing hide_collections setting with the api
This is currently only possible with app/controllers/settings/profiles_controller.rb
and is the only difference in the allowed parameter between the two controllers
* Fix the lint issue
* Use normal indent
2 years ago
Claire
aefefc74c4
Change referrer-policy to no-referrer application-wide ( #23014 )
2 years ago
Claire
18d00055f4
Add dropdown menu item to open admin interface for remote domains ( #21895 )
...
* Allow /admin/instances/:domain to handle IDNs
* Add dropdown menu item to open admin interface for remote domains
2 years ago
Claire
42f9693d00
Fix PermalinkRedirector not applying to users with moved accounts ( #22497 )
...
Fixes #22262
2 years ago
Claire
8556a649d5
Fix changing domain block severity not undoing individual account effects ( #22135 )
...
* Fix changing domain block severity not undoing individual account effects
Fixes #22133
* Add tests
2 years ago
David Vega
1b5d207131
Fix single name variables on controller folder ( #20092 )
...
Co-authored-by: petrokoriakin1 <116151189+petrokoriakin1@users.noreply.github.com>
Co-authored-by: petrokoriakin1 <116151189+petrokoriakin1@users.noreply.github.com>
Co-authored-by: Effy Elden <effy@effy.space>
2 years ago
Claire
623d3d2e32
Change CSP directives on API to be tight and concise ( #20960 )
2 years ago
nametoolong
63b379c2d9
Fix N+1 queries from in NotificationsController ( #21202 )
...
Co-authored-by: Nonexistent <nx@example.org>
2 years ago
Effy Elden
441cac758f
Allow adding relays while secure mode & limited federation mode are enabled ( #22324 )
2 years ago
Francis Murillo
5fb1c3e934
Revoke all authorized applications on password reset ( #21325 )
...
* Clear sessions on password change
* Rename User::clear_sessions to revoke_access for a clearer meaning
* Add reset paassword controller test
* Use User.find instead of User.find_for_authentication for reset password test
* Use redirect and render for better test meaning in reset password
Co-authored-by: Effy Elden <effy@effy.space>
2 years ago
Francis Murillo
f6492a7c4d
Log admin approve and reject account ( #22088 )
...
* Log admin approve and reject account
* Add unit tests for approve and reject logging
2 years ago
Claire
69137f4a90
Fix irreversible and whole_word parameters handling in /api/v1/filters ( #21988 )
...
Fixes #21965
2 years ago
Claire
68d1df8bc3
Fix some performance issues with /admin/instances ( #21907 )
...
/admin/instances?availability=failing remains wholly unefficient
2 years ago
Claire
51a33ce77a
Fix not being able to follow more than one hashtag ( #21285 )
...
Fixes regression from #20860
2 years ago
Claire
48e136605a
Fix form-action CSP directive for external login ( #20962 )
2 years ago
Claire
4ae97a2e4c
Fix OAuth flow being broken by recent CSP change ( #20958 )
2 years ago
lenore gilbert
c373148b3d
Support for import/export of instance-level domain blocks/allows for 4.x w/ additional fixes ( #20597 )
...
* Allow import/export of instance-level domain blocks/allows (#1754 )
* Allow import/export of instance-level domain blocks/allows.
Fixes #15095
* Pacify circleci
* Address simple code review feedback
* Add headers to exported CSV
* Extract common import/export functionality to
AdminExportControllerConcern
* Add additional fields to instance-blocked domain export
* Address review feedback
* Split instance domain block/allow import/export into separate pages/controllers
* Address code review feedback
* Pacify DeepSource
* Work around Paperclip::HasAttachmentFile for Rails 6
* Fix deprecated API warning in export tests
* Remove after_commit workaround
(cherry picked from commit 94e98864e3
)
* Add confirmation page when importing blocked domains (#1773 )
* Move glitch-soc-specific strings to glitch-soc-specific locale files
* Add confirmation page when importing blocked domains
(cherry picked from commit b91196f4b7
)
* Fix authorization check in domain blocks controller
(cherry picked from commit 7527937758
)
* Fix error strings for domain blocks and email-domain blocks
Corrected issue with non-error message used for Mastodon:NotPermittedError in Domain Blocks
Corrected issue Domain Blocks using the Email Domain Blocks message on ActionContoller::ParameterMissing
Corrected issue with Email Domain Blocks using the not_permitted string from "custom emojii's"
* Ran i18n-tasks normalize to address test failure
* Removed unused admin.export_domain_blocks.not_permitted string
Removing unused string as indicated by Check i18n
* Fix tests
(cherry picked from commit 9094c2f52c
)
* Fix domain block export not exporting blocks with only media rejection
(cherry picked from commit 26ff48ee48
)
* Fix various issues with domain block import
- stop using Paperclip for processing domain allow/block imports
- stop leaving temporary files
- better error handling
- assume CSV files are UTF-8-encoded
(cherry picked from commit cad824d8f501b95377e4f0a957e5a00d517a1902)
Co-authored-by: Levi Bard <taktaktaktaktaktaktaktaktaktak@gmail.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Claire
cbb0153bd0
Fix invalid/empty RSS feed link on account pages ( #20772 )
...
Fixes #20770
2 years ago
trwnh
7fdeed5fbc
Make tag following idempotent ( #20860 )
2 years ago
Claire
00b2720ef0
Change automatic post deletion configuration to be accessible to redirected users ( #20774 )
...
Fixes #20550
2 years ago
trwnh
e1f819fd78
Fix pagination of followed tags ( #20861 )
...
* Fix missing pagination headers on followed tags
* Fix typo
2 years ago
Daniel Axtens
4d85c27d1a
Add 'private' to Cache-Control, match Rails expectations ( #20608 )
...
Several controlers set quite intricate Cache-Control headers in order to
hopefully not be cached by any intermediate proxies or local caches. Unfortunately,
these headers are processed by ActionDispatch::HTTP::Cache in a way that squashes
and discards any values set alongside no-store other than private:
8015c2c2cf/actionpack/lib/action_dispatch/http/cache.rb (L207-L209)
We want to preserve no-store on these responses, but we might as well remove
parts that are going to be dropped anyway. As many of the endpoints in these
controllers are private to a particular user, we should also add "private",
which will be preserved alongside no-store.
2 years ago
trwnh
b59ce0a60f
Move V2 Filter methods under /api/v2 prefix ( #20622 )
...
* Move V2 Filter methods under /api/v2 prefix
* move over the tests too
2 years ago
Eugen Rochko
b31afc6294
Fix error when passing unknown filter param in REST API ( #20626 )
...
Fix #19156
2 years ago
Eugen Rochko
167d86d21d
Fix `role_ids` not accepting arrays in admin API ( #20625 )
...
Fix #19157
2 years ago
Claire
86f6631d28
Remove dead code and refactor status threading code ( #20357 )
...
* Remove dead code
* Remove unneeded/broken parameters and refactor descendant computation
2 years ago
Claire
1615c3eb6e
Change logged out /api/v1/statuses/:id/context logged out limits ( #20355 )
2 years ago
James Tucker
78a6b871fe
Improve performance by avoiding regex construction ( #20215 )
...
```ruby
10.times { p /#{FOO}/.object_id }
10.times { p FOO_RE.object_id }
```
2 years ago
Eugen Rochko
0cd0786aef
Revert filtering public timelines by locale by default ( #20294 )
2 years ago
trwnh
89e1974f30
Make account endorsements idempotent ( fix #19045 ) ( #20118 )
...
* Make account endorsements idempotent (fix #19045 )
* Accept suggestion to use exists? instead of find_by + nil check
Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>
* fix logic (unless, not if)
* switch to using `find_or_create_by!`
Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>
2 years ago
trwnh
68d9dcd425
Fix uncaught 500 error on invalid `replies_policy` ( Fix #19097 ) ( #20126 )
2 years ago
Claire
1e1289b024
Fix crash when external auth provider has no display_name set ( #19962 )
...
Fixes #19913
2 years ago
Claire
4cb2323458
Fix crash in legacy filter creation controller ( #19878 )
2 years ago