Matt Jankowski
c42591356d
Fix `RSpec/DescribedClass` cop ( #25104 )
1 year ago
Matt Jankowski
1e243e2df7
Misc spec coverage for `Admin::` area controllers ( #25282 )
1 year ago
Daniel M Brasil
eb6f8181e1
Add test coverage for `Mastodon::CLI::Accounts#reset_relationships` ( #25194 )
1 year ago
Matt Jankowski
b22bfae4f9
Add coverage for `DomainBlock#public_domain` method ( #25283 )
1 year ago
Eugen Rochko
4eda233e09
Add webhook templating ( #23289 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski
af135bddd0
Update `Admin::Metrics::Measure` classes for Rails 7 ( #25236 )
1 year ago
Matt Jankowski
3b21c13dcc
Rails 7 compatibility fix for `Admin::Metrics::Dimension` classes ( #25277 )
1 year ago
Daniel M Brasil
70cd2d6000
Add test coverage for `Mastodon::CLI::Accounts#cull` ( #25250 )
1 year ago
Darius Kazemi
bacb674921
Add exclusive lists ( #22048 )
...
Co-authored-by: Liam Cooke <liam@liamcooke.com>
Co-authored-by: John Holdun <john@johnholdun.com>
Co-authored-by: Effy Elden <effy@effy.space>
Co-authored-by: Lina Reyne <git@lina.pizza>
Co-authored-by: Lina <20880695+necropolina@users.noreply.github.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski
5c87c66504
Add coverage for CLI::CanonicalEmailBlocks command ( #25239 )
1 year ago
Daniel M Brasil
03a707f6a6
Add test coverage for `Mastodon::CLI::Accounts#merge` ( #25199 )
1 year ago
Renaud Chaput
b0780cfeed
Fix `/share` and cleanup and reorganize frontend locale loading ( #25240 )
1 year ago
Claire
8884d1ece0
Add support for importing lists ( #25203 )
1 year ago
Daniel M Brasil
2a353200ad
Add test coverage for `Mastodon::CLI::Accounts#rotate` ( #25212 )
1 year ago
Renaud Chaput
942d850b0a
Allow carets in URL search params ( #25216 )
1 year ago
Daniel M Brasil
f906e21a4f
Add test coverage for `Mastodon::CLI::Accounts#refresh` ( #25196 )
1 year ago
Matt Jankowski
f84037ae2b
Remove unused #hash_to_object method in SettingsHelper ( #25213 )
1 year ago
Claire
e9385e93e9
Add a confirmation screen when suspending a domain ( #25144 )
1 year ago
Claire
b922ad7a1b
Fix crash when S3_ALIAS_HOST or S3_CLOUDFRONT_HOST have a path component ( #25018 )
1 year ago
Christian Schmidt
69057467cb
Translate CW, poll options and media descriptions ( #24175 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski
b0104e4c33
Silence output to stdout during cli specs ( #25211 )
1 year ago
Daniel M Brasil
3c41547f49
Add test coverage for `Mastodon::CLI::Accounts#backup` ( #25163 )
1 year ago
Matt Jankowski
8b1bfaed3e
Add specs for admin/webhooks CRUD actions ( #25133 )
1 year ago
Matt Jankowski
665bb237a8
Increase spec coverage for controllers - admin/ip_blocks, admin/relays, admin/rules ( #25192 )
1 year ago
Daniel M Brasil
bf9a7ce8e8
Add test coverage for `Mastodon::CLI::Accounts#unfollow` ( #25162 )
1 year ago
Daniel M Brasil
dbc44be0ca
Add test coverage for `Mastodon::CLI::Accounts#follow` ( #25161 )
1 year ago
Daniel M Brasil
3d253b9830
Add test coverage for `Mastodon::CLI::Accounts#approve` ( #25160 )
1 year ago
Daniel M Brasil
bbbcdc083f
Add test coverage for `Mastodon::CLI::Accounts#delete` ( #25146 )
1 year ago
Daniel M Brasil
bdc7548652
Add test coverage for `Mastodon::CLI::Accounts#modify` ( #25145 )
1 year ago
Daniel M Brasil
11b8336418
Add test coverage for `Mastodon::CLI::Accounts#create` ( #25143 )
1 year ago
Matt Jankowski
0f2c16ac4b
Fix RSpec/NoExpectationExample cop ( #25103 )
1 year ago
Matt Jankowski
384345b0de
Add CLI Base class for command line code ( #25106 )
1 year ago
Matt Jankowski
d2e5430d4a
Fix RSpec/ExpectChange cop ( #25101 )
1 year ago
Matt Jankowski
b896b16cb3
Fix RSpec/PredicateMatcher cop ( #25102 )
1 year ago
Matt Jankowski
778e4a7bf7
Fix RSpec/ExpectInHook cop ( #25100 )
1 year ago
Matt Jankowski
b6b4ea4ca5
Move the mastodon/*_cli files to mastodon/cli/* ( #24139 )
1 year ago
Matt Jankowski
c9f980b268
Add request spec for backups download ( #25099 )
1 year ago
Matt Jankowski
e387175fc9
Fix RSpec/RepeatedExample cop ( #24849 )
1 year ago
Matt Jankowski
9f5deb310b
Fix Performance/MapCompact cop ( #24797 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski
2877c80dbc
Add specs for admin/announcements CRUD actions ( #25077 )
1 year ago
Daniel M Brasil
b473df9a14
Improve test coverage for `/api/v1/featured_tags` ( #25076 )
1 year ago
Claire
2a61f14753
Fix account confirmation flow not returning to app after captcha validation ( #25057 )
1 year ago
Daniel M Brasil
4a22e72b9b
Improve test coverage for `/api/v1/admin/canonical_email_blocks` ( #24985 )
1 year ago
Daniel M Brasil
ce8b5899ae
Fix POST `/api/v1/admin/domain_allows` returning 200 when no domain is specified ( #24958 )
1 year ago
Matt Jankowski
e328ab7e5a
Implement pending specs for StatusesController ( #23969 )
1 year ago
Daniel M Brasil
f3feb4c891
Improve test coverage for `/api/v1/admin/email_domain_blocks` ( #25017 )
1 year ago
Emelia Smith
19f9098551
Allow reports with long comments from remote instances, but truncate ( #25028 )
1 year ago
Daniel M Brasil
d51464283c
Improve test coverage for `/api/v1/admin/ip_blocks_controller` ( #25031 )
1 year ago
Nick Schonning
99e2e9b81f
Fix minor typos in comments and spec names ( #21831 )
2 years ago
Claire
b805b7f021
Add tests for avatar/header in backup service ( #25037 )
2 years ago
Matt Jankowski
d34d94d08f
Add spec for migration warning module ( #25033 )
2 years ago
Claire
e60414792d
Add polling and automatic redirection to `/start` on email confirmation ( #25013 )
2 years ago
Claire
3ed3d54bf3
Fix reports not being closed when performing batch suspensions ( #24988 )
2 years ago
Matt Jankowski
604e1c2b11
Remove usage of random sample values in specs ( #24869 )
2 years ago
Matt Jankowski
b84bc2de5d
Replace i18n view spec with helper spec ( #24966 )
2 years ago
Matt Jankowski
679aca46da
I18n pluralization errors ( #24963 )
2 years ago
Daniel M Brasil
433ab0c9a3
Fix uncaught NoMethodError error in `/api/v1/admin/canonical_email_blocks/test` ( #24947 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Claire
9015c2d646
Change profile updates to be sent to recently-mentioned servers ( #24852 )
2 years ago
Matt Jankowski
2c2d924942
Fix RSpec/RepeatedExampleGroupDescription cop ( #24850 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Matt Jankowski
bf3ebeb42f
Fix RSpec/SharedContext cop ( #24847 )
2 years ago
Matt Jankowski
a610a02d4f
Fix RSpec/ScatteredSetup cop ( #24848 )
2 years ago
Daniel M Brasil
9cbda99941
Add test coverage for `Mastodon::IpBlocksCLI` ( #24935 )
2 years ago
Claire
6b0942d107
Change AccessTokensVacuum to also delete expired tokens ( #24868 )
2 years ago
Daniel M Brasil
c9210af3ee
Add test coverage for `Mastodon::SettingsCLI` ( #24856 )
2 years ago
Claire
c3c7d59072
Fix infinite loop in AccountsStatusesCleanupScheduler ( #24840 )
2 years ago
Nick Schonning
da3bd913ae
Autofix Rubocop Style/HashSyntax ( #23754 )
2 years ago
Nick Schonning
1fe04f740a
Enable Rubocop Rails/FilePath ( #23854 )
2 years ago
Matt Jankowski
c97b611b6b
Fix RSpec/InferredSpecType cop ( #24736 )
2 years ago
Matt Jankowski
710745e16b
Fix RSpec/ContextWording cop ( #24739 )
2 years ago
Matt Jankowski
cf18cc2891
Fix RSpec/MultipleSubjects cop ( #24738 )
2 years ago
Matt Jankowski
bdcd8a9e88
Misc spec cleanup ( #24822 )
2 years ago
Matt Jankowski
08fb9d300a
Spec coverage for settings/preferences/* controllers ( #24825 )
2 years ago
Claire
a2a22bad23
Fix various edge cases with local moves ( #24812 )
2 years ago
Claire
1e75eb690d
Fix own posts not getting delivered to own lists ( #24810 )
2 years ago
Claire
c98b012583
Change Move handler to also move list memberships ( #24808 )
2 years ago
Matt Jankowski
3df665fd23
Fix Lint/ConstantDefinitionInBlock cop ( #24763 )
2 years ago
Claire
8b636a29c6
Improve automatic post cleanup worker performances ( #24785 )
2 years ago
Matt Jankowski
a0c9f2447e
Fix Performance/MethodObjectAsBlock cop ( #24798 )
2 years ago
Matt Jankowski
97385f27bd
Fix Performance/RedundantEqualityComparisonBlock cop ( #24799 )
2 years ago
Matt Jankowski
05e3abe9d9
Fix Lint/EmptyClass cop ( #24795 )
2 years ago
Matt Jankowski
a7df578f97
ApplicationHelper spec coverage, unused removal, tiny refactor ( #24762 )
2 years ago
Matt Jankowski
570079f8ce
Fix Performance/TimesMap cop ( #24789 )
2 years ago
Claire
9189e90ff2
Add fallback redirection when getting a webfinger query `LOCAL_DOMAIN@LOCAL_DOMAIN` ( #23600 )
...
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
2 years ago
Claire
b233da5996
Optimize archive export service and export zip files instead of gzipped tar files ( #23360 )
2 years ago
Claire
6693a4fe7c
Change lists to be able to include accounts with pending follow requests ( #19727 )
2 years ago
Claire
1eb51bd749
Add request specs for caching behavior ( #24592 )
2 years ago
Claire
32a030dd74
Rewrite import feature ( #21054 )
2 years ago
Matt Jankowski
d00e45a7d3
Fix Rails/I18nLocaleAssignment cop ( #24693 )
2 years ago
Mark Roszko
c23d285b16
Remove the u in Favorite for non-gb english ( #24667 )
...
Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>
2 years ago
João Pedro Marques
8f6e290c7a
Adds new follower/following routes ( #24601 )
2 years ago
Matt Jankowski
bdc74086e6
Fix Rails/ContentTag cop ( #24691 )
2 years ago
Matt Jankowski
8dcfb6e0ea
Fix Rails/HttpPositionalArguments cop ( #24699 )
2 years ago
Matt Jankowski
274d561430
Enable local account key generation spec ( #24728 )
2 years ago
Matt Jankowski
4cfe52635c
Add pending spec for User.those_who_can ( #24724 )
2 years ago
Nick Schonning
5841f1af8c
Autofix Rubocop RSpec/MatchArray ( #24675 )
2 years ago
Nick Schonning
a3393d0d07
Autofix Rubocop RSpec/MatchArray ( #24050 )
2 years ago
Matt Jankowski
91a8cd21d8
React component helper specs ( #24072 )
2 years ago
Nick Schonning
90beba57d8
Autofix Rubocop Rails/ResponseParsedBody ( #24051 )
2 years ago
Claire
276c39361b
Fix anonymous visitors getting a session cookie on first visit ( #24584 )
2 years ago
Claire
f45961aa98
Add feature test for OAuth access grant ( #24624 )
2 years ago
Matt Jankowski
0a5f0a8b20
Remove instance variables from helper usage ( #24203 )
2 years ago
Claire
58a1b2e330
Fix caching logic with regards to Accept-Language, Cookie, and Signature ( #24604 )
2 years ago
Claire
5dc3173ef8
Fix AccountsStatusesCleanupScheduler not spreading deletes across accounts correctly ( #24607 )
2 years ago
Eugen Rochko
e98c86050a
Refactor `Cache-Control` and `Vary` definitions ( #24347 )
2 years ago
Robert R George
4db8230194
Add trend management to admin API ( #24257 )
2 years ago
Heitor de Melo Cardozo
bc75e62ca6
Change moderation search an account using the username with @ ( #24242 )
2 years ago
Heitor de Melo Cardozo
4601e0dcbb
Add user handle to notification mail recipient address ( #24240 )
...
Co-authored-by: luccamps <luccamps@users.noreply.github.com>
Co-authored-by: Leonardo Negreiros de Oliveira <negreirosleo12@gmail.com>
Co-authored-by: Marcio Flavio <mflaviof1995@gmail.com>
Co-authored-by: Gabriel Quaresma <j.quaresmasantos_98@hotmail.com>
2 years ago
Matt Jankowski
10f0de4212
Refactor race condition reblog service spec ( #24526 )
2 years ago
Claire
f53d009778
Refactor `Status._insert_record` slightly and tighten the test around reblogs of discarded statuses ( #24516 )
2 years ago
Matt Jankowski
36eeb70d53
Spec coverage on Settings/ controllers specs ( #24221 )
2 years ago
Matt Jankowski
a2a66300d9
Clean up the post deployment migration generator ( #24233 )
2 years ago
Matt Jankowski
9d39b111f1
Expand coverage for "system checks" ( #24216 )
2 years ago
Christian Schmidt
b4f38edf74
Wrong type for user setting when default is defined by lambda ( #24321 )
2 years ago
Eugen Rochko
a9b5598c97
Change user settings to be stored in a more optimal way ( #23630 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Christian Schmidt
eb38e9df31
Requeue expiration notification ( #24311 )
2 years ago
Eugen Rochko
9bda933740
Change media upload limits and remove client-side resizing ( #23726 )
2 years ago
Matt Jankowski
b179ff84c7
Add specs for Chewy importers ( #24204 )
2 years ago
Christian Schmidt
bd047acc35
Replace `Status#translatable?` with language matrix in separate endpoint ( #24037 )
2 years ago
Nick Schonning
a38f67c1c3
Autofix Rubocop Style/PreferredHashMethods ( #23851 )
2 years ago
Claire
a232a1feb8
Fix misleading error code when receiving invalid WebAuthn credentials ( #23568 )
2 years ago
Matt Jankowski
a471e1c48f
Add spec for the CLI `version` task ( #23978 )
2 years ago
Matt Jankowski
1ed12d5e2f
Add basic search specs for chewy indexes ( #24065 )
2 years ago
Matt Jankowski
688287c59d
Coverage improvement round-out following up previous work ( #23987 )
2 years ago
Matt Jankowski
56bddfbfa3
Serializers spec coverage ( #24017 )
2 years ago
Matt Jankowski
2f7a663b0b
Explicitly set github repo in instance presenter spec ( #24036 )
2 years ago
Christian Schmidt
684a970b3c
Unescape HTML entities ( #24019 )
2 years ago
Matt Jankowski
c599e289d8
Fix spec for api/v1/statuses/translations ( #23956 )
2 years ago
Matt Jankowski
2d1ccb3d8b
Restore missing fabricators ( #23951 )
2 years ago
Matt Jankowski
506b16cf59
Pending example models minimal coverage ( #23912 )
2 years ago
Matt Jankowski
7f4412eeeb
User mailer spec coverage improvements ( #23905 )
2 years ago
Matt Jankowski
42ddc45133
Admin controllers specs ( #23917 )
2 years ago
Matt Jankowski
ad585fb195
Specs api v1 controllers ( #23930 )
2 years ago
Matt Jankowski
cd99fa8ceb
Fabricator specs ( #23925 )
2 years ago
Matt Jankowski
c40d5e5a8f
Misc coverage improvements for validators ( #23928 )
2 years ago
Matt Jankowski
2f606ba122
Helpers specs coverage improvement ( #23937 )
2 years ago
Matt Jankowski
00eb2269b6
Policies specs ( #23924 )
2 years ago
Matt Jankowski
6a57c42316
Settings controllers specs ( #23915 )
2 years ago
Matt Jankowski
39e7525c96
Add basic coverage for some worker jobs ( #23943 )
2 years ago
Matt Jankowski
f9c2213ae5
Models specs coverage ( #23940 )
2 years ago
Christian Schmidt
5a8c651e8f
Only offer translation for supported languages ( #23879 )
2 years ago
Claire
3f52e717fa
Add tests for moderation actions without custom text ( #23184 )
2 years ago
Claire
c2a046ded1
Fix “Remove all followers from the selected domains” being more destructive than it claims ( #23805 )
2 years ago
Claire
3a6451c867
Add support for incoming rich text ( #23913 )
2 years ago
Matt Jankowski
af578e8ce0
Fix deprecation warning about merging conditions ( #23618 )
2 years ago
Matt Jankowski
9da52ac044
Update rspec-rails to version 6.0.1 ( #23908 )
2 years ago
Matt Jankowski
35dff48edf
Add spec coverage for Admin::Trends::StatusesHelper ( #23898 )
2 years ago
Stanislav Dobrovolschii
d9271126ce
Add rspecs for FollowRecommendationsScheduler ( #23890 )
2 years ago
Matt Jankowski
b6602f68eb
Spec coverage for HomeHelper ( #23907 )
2 years ago
Matt Jankowski
6185efbc3c
Admin mailer spec coverage improvement ( #23863 )
2 years ago
Matt Jankowski
9ee83a9f3b
Add policies and serializers groups to simplecov output ( #23897 )
2 years ago
Matt Jankowski
4bb39ac3c3
Fix single-record invalid condition on PollVote ( #23810 )
2 years ago
Nick Schonning
19614ba247
Rename ActivityPub Serializer Specs ( #23844 )
2 years ago
Claire
20b80c62ff
Change auto-deletion throttling constants to better scale with server size ( #23320 )
2 years ago
Nick Schonning
6bd7003799
Fix mispelled spec filenames ( #23834 )
2 years ago
Claire
3ed1b9ebb6
Fix rack:attack flaky tests and test end of throttle period ( #23799 )
2 years ago
Nick Schonning
8fd3fc404d
Autofix Rubocop Rails/RootPathnameMethods ( #23760 )
2 years ago
Nick Schonning
84cc805cae
Enable Style/FrozenStringLiteralComment for specs ( #23790 )
2 years ago
Nick Schonning
0cfdd1a401
Enable Rubocop Style/StringConcatenation defaults ( #23792 )
2 years ago
Nick Schonning
35d032500b
Autofix Rubocop Security/IoMethods ( #23757 )
2 years ago
Nick Schonning
2c3c734bcc
Autofix Rubocop Style/SymbolProc ( #23742 )
2 years ago
Nick Schonning
717683d1c3
Autofix Rubocop remaining Layout rules ( #23679 )
2 years ago
Nick Schonning
5116347eb7
Autofix Rubocop RSpec/BeEq ( #23740 )
2 years ago
Nick Schonning
bf785df9fe
Audofix Rubocop Style/WordArray ( #23739 )
2 years ago
Nick Schonning
4552685f6b
Autofix Rubocop RSpec/LeadingSubject ( #23670 )
2 years ago
Nick Schonning
4ea1e0fceb
Enable Rubocop RSpec/ExpectActual ( #23720 )
2 years ago
Nick Schonning
38a1d8bb85
Autofix Rubocop RSpec/ImplicitSubject ( #23721 )
2 years ago
Nick Schonning
5179c47087
Autofix Rubocops RSpec/ScatteredLet ( #23725 )
2 years ago
Nick Schonning
aef0051fd0
Enable Rubocop HTTP status rules ( #23717 )
2 years ago
Nick Schonning
bd1d57c230
Autofix Rubocop RSpec/EmptyLineAfterSubject ( #23719 )
2 years ago
Nick Schonning
dbc6d7b276
Autofix Rubocop Lint/UnusedBlockArgument ( #23712 )
2 years ago
Nick Schonning
65ba0d92ef
Enable Rubocop RSpec/NotToNot ( #23723 )
2 years ago
Nick Schonning
a2fdb388eb
Autofix Rubocop RSpec/ReturnFromStub ( #23724 )
2 years ago
Nick Schonning
21bf326356
Autofix Rubocop Rails/Pluck ( #23730 )
2 years ago
Nick Schonning
e0e63b73ee
Autofix Rubocop RSpec/EmptyLineAfterHook ( #23718 )
2 years ago
Nick Schonning
81ad6c2e39
Autofix Rubocop Style/StringLiterals ( #23695 )
2 years ago
Nick Schonning
ac3561098e
Autofix Rubocop RSpec/LetBeforeExamples ( #23671 )
2 years ago
Nick Schonning
1a02101100
Autofix Rubocop Style/EmptyLambdaParameter ( #23705 )
2 years ago
Nick Schonning
3680e032b4
Autofix Rubocop RSpec/EmptyLineAfterFinalLet ( #23707 )
2 years ago
Nick Schonning
167709f6b0
Autofix Rubocop Style/BlockDelimiters ( #23706 )
2 years ago
Nick Schonning
c0d7c855b3
Autofix Rubocop RSpec/Capybara/FeatureMethods ( #23708 )
2 years ago
Nick Schonning
08289a38fa
Autofix Rubocop Style/TrailingCommaInArrayLiteral ( #23692 )
2 years ago
Nick Schonning
5069769cbe
Autofix Rubocop Style/TrailingCommaInHashLiteral ( #23693 )
2 years ago
Nick Schonning
b4cbfff3eb
Autofix Rubocop RSpec/ExcessiveDocstringSpacing ( #23666 )
2 years ago
Nick Schonning
c38bd17657
Autofix Rubocop Style/TrailingCommaInArguments ( #23694 )
2 years ago
Nick Schonning
e2a3ebb271
Autofix Rubocop Style/IfUnlessModifier ( #23697 )
2 years ago
Nick Schonning
d65b2c1924
Apply Rubocop Style/RedundantConstantBase ( #23463 )
2 years ago
Nick Schonning
a7db0b41cd
Autofix Rubocop Lint/ParenthesesAsGroupedExpression ( #23682 )
2 years ago
Nick Schonning
e5cf23cf3a
Enable Rubocop RSpec/HooksBeforeExamples ( #23668 )
2 years ago
Nick Schonning
efd424506a
Autofix Rubocop Style/RedundantPercentQ ( #23651 )
2 years ago
Nick Schonning
c0a645f647
Autofix Rubocop RSpec/ExampleWording ( #23667 )
2 years ago
Nick Schonning
7a3d4c3d4b
Enable Rubocop RSpec/MultipleDescribes ( #23672 )
2 years ago
Nick Schonning
54318dcd6d
Autofix Rubocop RSpec/ClassCheck ( #23685 )
2 years ago
Nick Schonning
634368c491
Autofix Rubocop Lint/SymbolConversion ( #23683 )
2 years ago
Nick Schonning
6d42820e5d
Autofix Rubocop Lint/AmbiguousOperator ( #23680 )
2 years ago
Nick Schonning
ac59d6f19f
Enable Rubocop Style/NumericLiterals ( #23647 )
2 years ago
Nick Schonning
669f6d2c0a
Run rubocop formatting except line length ( #23632 )
2 years ago
Nick Schonning
6ed6c41724
Autofix Rubocop RSpec/EmptyLineAfterExample ( #23661 )
2 years ago
Nick Schonning
68b1071f86
Autofix Rubocop RSpec/BeNil ( #23653 )
2 years ago
Nick Schonning
936204b9ea
Autofix Rubocop Style/NestedParenthesizedCalls ( #23646 )
2 years ago
Nick Schonning
37914c8757
Autofix Rubocop Style/MethodCallWithoutArgsParentheses ( #23645 )
2 years ago
Claire
66f715550e
Add `memorial` attribute to REST API ( #23591 )
2 years ago
Claire
d6930b3847
Add API parameter to safeguard unexpect mentions in new posts ( #18350 )
2 years ago
Varun Sharma
45e2936c89
Add tests to indicate inclusion of self replies in statuses endpoint ( #23266 )
2 years ago
Claire
c55568c75a
Add tests for `REST::AccountSerializer` ( #23319 )
2 years ago
Claire
0c9eac80d8
Fix unbounded recursion in post discovery ( #23506 )
...
* Add a limit to how many posts can get fetched as a result of a single request
* Add tests
* Always pass `request_id` when processing `Announce` activities
---------
Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>
2 years ago
Nick Schonning
0592937264
Apply Rubocop Rails/WhereNot ( #23448 )
...
* Apply Rubocop Rails/WhereNot
* Update spec for where.not
2 years ago
Nick Schonning
1487fcde93
Apply Rubocop Style/ExpandPathArguments ( #23450 )
2 years ago
Nick Schonning
ed570050c6
Autofix Rails/EagerEvaluationLogMessage ( #23429 )
...
* Autofix Rails/EagerEvaluationLogMessage
* Update spec for debug block syntax
2 years ago
Claire
9edefc779f
Fix `UserCleanupScheduler` crash when an unconfirmed account has a moderation note ( #23318 )
...
* Fix `UserCleanupScheduler` crash when an unconfirmed account has a moderation note
* Add tests
2 years ago
Claire
20a479ff7c
Change `POST /settings/applications/:id` to regenerate token on scopes change ( #23359 )
...
Fixes #23096
2 years ago
Claire
13a2abacc8
Add `roles` attribute to Account entities in REST API ( #23255 )
2 years ago
Claire
a5a00d7f7a
Fix email with empty domain name labels passing validation ( #23246 )
...
* Fix email with empty domain name labels passing validation
`EmailMxValidator` would allow empty labels because `Resolv::DNS` is
particularly lenient about them, but the email would be invalid and
unusable.
* Add tests
2 years ago
Claire
6883fddb19
Fix account activation being triggered before email confirmation ( #23245 )
...
* Add tests
* Fix account activation being triggered before email confirmation
Fixes #23098
2 years ago
Markus Unterwaditzer
f2a6e71bb6
Suppress AddressFamilyError in link verification ( #23204 )
...
* Suppress AddressFamilyError
* clarify comment
2 years ago
Claire
448be26b34
Add missing `policy` attribute to `WebPushSubscriptionSerializer` ( #23210 )
...
* Add missing `policy` attribute to `WebPushSubscriptionSerializer`
Fixes #23145
* Add tests
2 years ago
Claire
68dcbcb7bf
Add more specific error messages to HTTP signature verification ( #21617 )
...
* Return specific error on failure to parse Date header
* Add error message when preferredUsername is not set
* Change error report to be JSON and include more details
* Change error report to differentiate unknown account and failed refresh
* Add tests
2 years ago
Claire
343e1fe8e9
Add confirmation screen when handling reports ( #22375 )
...
* Add confirmation screen on moderation actions
* Add flash notice when a report has been processed
* Refactor tests
* Add tests
2 years ago
Claire
4b92e59f4f
Add support for editing media description and focus point of already-posted statuses ( #20878 )
...
* Add backend support for editing media attachments of existing posts
* Allow editing media attachments of already-posted toots
* Add tests
2 years ago
Claire
fcc4c9b34a
Change domain block CSV parsing to be more robust and handle more lists ( #21470 )
...
* Change domain block CSV parsing to be more robust and handle more lists
* Add some tests
* Improve domain block import validation and reporting
2 years ago
Claire
21a1a8ee88
Fix crash when marking statuses as sensitive while some statuses are deleted ( #22134 )
...
* Do not offer to mark statuses as sensitive if there is no undeleted status with media attachments
* Fix crash when marking statuses as sensitive while some statuses are deleted
Fixes #21910
* Fix multiple strikes being created for a single report when selecting “Mark as sensitive”
* Add tests
2 years ago
Claire
15b88a83ab
Fix sanitizer parsing link text as HTML when stripping unsupported links ( #22558 )
2 years ago
Markus Unterwaditzer
0c689b9d01
fix: allow verification when page size exceeds 1MB (using HTML5 parser) ( #22879 )
...
* fix: allow verification when page size exceeds 1MB
Truncates the page after 1MB instead
Closes #15316
* switch to HTML5 parser, fix rubocop errors
* undo rubocop fixes
Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com>
2 years ago
Claire
18fb01ef7c
Fix possible race conditions when suspending/unsuspending accounts ( #22363 )
...
* Fix possible race conditions when suspending/unsuspending accounts
* Fix tests
Tests were assuming SuspensionWorker and UnsuspensionWorker would do the
suspending/unsuspending themselves, but this has changed.
2 years ago
Jeong Arm
fdd1facba1
Fix home TL could contain post from who blocked me ( #22849 )
...
* Fix home tl contains post from who blocked me
* Add test
* Fix feed_manager's build_crutches
blocked_by was not includes status' owner
* Add test for status from I blocked
* Fix typo
2 years ago
Partho Ghosh
115ab2869b
Fix ・ detection in hashtag regex to construct hashtag correctly ( #22888 )
...
* Fix ・ detection in hashtag regex to construct hashtag correctly
* Fixed rubocop liniting issues
* More rubocop linting fix
2 years ago
Claire
70415714f1
Add follow request banner on account header ( #20785 )
...
* Add requested_by to relationship maps
* Display whether an account has requested to follow you on their profile
2 years ago
Claire
8556a649d5
Fix changing domain block severity not undoing individual account effects ( #22135 )
...
* Fix changing domain block severity not undoing individual account effects
Fixes #22133
* Add tests
2 years ago
Jeong Arm
d412147d02
Save avatar or header correctly even if other one fails ( #18465 )
...
* Save avatar or header correctly if other one fails
* Fix test
2 years ago
Neil Matatall
1f5740e65c
Use Rails tag API to build RSS feed for spoilers and polls ( #20163 )
...
* Use Rails tag API to build RSS feed for spoilers and polls
While the previous method did not contain a bug or a potential issue,
the tag API can be very resilient against future problems and reduces the
amount of manual management of the escape status of the content.
I've added tests to ensure that the formatting is broken and still
escapes control characters correctly.
* this seems cleaner and passes
* Incorporate feedback by moving the br to its own line and using the tag helper over the string constant for the br tag itself
* whoops, tag helper doesn't use a self-closing tag
2 years ago
Ikko Ashimine
baecdf2882
Fix typo in application_helper_spec.rb ( #20981 )
...
enviroment -> environment
2 years ago
Francis Murillo
5fb1c3e934
Revoke all authorized applications on password reset ( #21325 )
...
* Clear sessions on password change
* Rename User::clear_sessions to revoke_access for a clearer meaning
* Add reset paassword controller test
* Use User.find instead of User.find_for_authentication for reset password test
* Use redirect and render for better test meaning in reset password
Co-authored-by: Effy Elden <effy@effy.space>
2 years ago
Meisam
6cdbc345f4
Validate nodeinfo response by schema ( #21395 )
...
* add json-schema to :test in Gemfile
* Create node_info_2.0_schema.json
* test match_response_schema
* Create match_response_schema.rb
* Update nodeinfo_controller_spec.rb
* Rename spec/support/node_info_2.0_schema.json to spec/support/schema/node_info_2.0_schema.json
* Update match_response_schema.rb
* cleanup
* additionally validate the json schema itself
disable throwing errors
test the schema matcher
* rename nodeinfo schema to nodeinfo_2.0
* use Rails.root.join to construct the path
* prettify json
* sync Gemfile.lock
2 years ago
Claire
b59fb28e90
Fix 500 error when trying to migrate to an invalid address ( #21462 )
...
* Fix 500 error when trying to migrate to an invalid address
* Add tests
2 years ago
Francis Murillo
f6492a7c4d
Log admin approve and reject account ( #22088 )
...
* Log admin approve and reject account
* Add unit tests for approve and reject logging
2 years ago
Claire
c8849d6cee
Fix unbounded recursion in account discovery ( #22025 )
...
* Fix trying to fetch posts from other users when fetching featured posts
* Rate-limit discovery of new subdomains
* Put a limit on recursively discovering new accounts
2 years ago
Claire
69137f4a90
Fix irreversible and whole_word parameters handling in /api/v1/filters ( #21988 )
...
Fixes #21965
2 years ago
Claire
625216d8e1
Fix attachments of edited statuses not being fetched ( #21565 )
...
* Fix attachments of edited statuses not being fetched
* Fix tests
2 years ago
Claire
51a33ce77a
Fix not being able to follow more than one hashtag ( #21285 )
...
Fixes regression from #20860
2 years ago
David Leadbeater
69378eac99
Don't allow URLs that contain non-normalized paths to be verified ( #20999 )
...
* Don't allow URLs that contain non-normalized paths to be verified
This stops things like https://example.com/otheruser/../realuser where
"/otheruser" appears to be the verified URL, but the actual URL being
verified is "/realuser" due to the "/../".
Also fix a test to use 'https', so it is testing the right thing, now
that since #20304 https is required.
* missing do
2 years ago
Rose
4f15fd0ba1
Fix style for hashes ( #20518 )
...
* Fix style for hashes
Make the style for hashes consistent.
* New style
More consistency
2 years ago
lenore gilbert
c373148b3d
Support for import/export of instance-level domain blocks/allows for 4.x w/ additional fixes ( #20597 )
...
* Allow import/export of instance-level domain blocks/allows (#1754 )
* Allow import/export of instance-level domain blocks/allows.
Fixes #15095
* Pacify circleci
* Address simple code review feedback
* Add headers to exported CSV
* Extract common import/export functionality to
AdminExportControllerConcern
* Add additional fields to instance-blocked domain export
* Address review feedback
* Split instance domain block/allow import/export into separate pages/controllers
* Address code review feedback
* Pacify DeepSource
* Work around Paperclip::HasAttachmentFile for Rails 6
* Fix deprecated API warning in export tests
* Remove after_commit workaround
(cherry picked from commit 94e98864e3
)
* Add confirmation page when importing blocked domains (#1773 )
* Move glitch-soc-specific strings to glitch-soc-specific locale files
* Add confirmation page when importing blocked domains
(cherry picked from commit b91196f4b7
)
* Fix authorization check in domain blocks controller
(cherry picked from commit 7527937758
)
* Fix error strings for domain blocks and email-domain blocks
Corrected issue with non-error message used for Mastodon:NotPermittedError in Domain Blocks
Corrected issue Domain Blocks using the Email Domain Blocks message on ActionContoller::ParameterMissing
Corrected issue with Email Domain Blocks using the not_permitted string from "custom emojii's"
* Ran i18n-tasks normalize to address test failure
* Removed unused admin.export_domain_blocks.not_permitted string
Removing unused string as indicated by Check i18n
* Fix tests
(cherry picked from commit 9094c2f52c
)
* Fix domain block export not exporting blocks with only media rejection
(cherry picked from commit 26ff48ee48
)
* Fix various issues with domain block import
- stop using Paperclip for processing domain allow/block imports
- stop leaving temporary files
- better error handling
- assume CSV files are UTF-8-encoded
(cherry picked from commit cad824d8f501b95377e4f0a957e5a00d517a1902)
Co-authored-by: Levi Bard <taktaktaktaktaktaktaktaktaktak@gmail.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Joshua Wood
daf6f3453e
Handle links with no href in VerifyLinkService ( #20741 )
...
Before this change, the following error would cause VerifyAccountLinksWorker to fail:
NoMethodError: undefined method `downcase' for nil:NilClass
[PROJECT_ROOT]/app/services/verify_link_service.rb:31 :in `block in link_back_present?`
2 years ago
Eugen Rochko
21fd25a269
Fix rate limiting for paths with formats ( #20675 )
2 years ago
trwnh
b59ce0a60f
Move V2 Filter methods under /api/v2 prefix ( #20622 )
...
* Move V2 Filter methods under /api/v2 prefix
* move over the tests too
2 years ago
Eugen Rochko
552d69ad96
Fix error when invalid domain name is submitted ( #19474 )
...
Fix #19175
2 years ago
Eugen Rochko
b31afc6294
Fix error when passing unknown filter param in REST API ( #20626 )
...
Fix #19156
2 years ago
Hampton Lintorn-Catlin
147d8bd8fc
Support UTF-8 Characters in Domains During CSV Import ( #20592 )
...
* Support UTF-8 Characters in Domains During Import
* Update Changelong
2 years ago
Emily Strickland
c2231539c7
Test blank account field verifiability ( #20458 )
...
* Test blank account field verifiability
This change tests the need for #20428 , which ensures that we guard against a situation in which `at_xpath` returns `nil`.
* Test verifiability of blank fields for remote account profiles
This adds a counterpart test for remote account profiles' fields' verifiability when those fields are blank. I previously added the same test for local accounts.
2 years ago
F
d4f973227c
Test the native_locale_name of a non-standard locale ( #20284 )
...
`:en` is English for both `standard_locale_name` and
`native_locale_name`, and so makes for a poor test candidate for
differentiating between them.
2 years ago
Eugen Rochko
9965a23b04
Change link verification to ignore IDN domains ( #20295 )
...
Fix #3833
2 years ago
Eugen Rochko
e98833748e
Fix being able to spoof link verification ( #20217 )
...
- Change verification to happen in `default` queue
- Change verification worker to only be queued if there's something to do
- Add `link` tags from metadata fields to page header of profiles
2 years ago
luzpaz
6ba52306f9
Fix typos ( #19849 )
...
Found via `codespell -q 3 -S ./yarn.lock,./CHANGELOG.md,./AUTHORS.md,./config/locales,./app/javascript/mastodon/locales -L ba,followings,keypair,medias,pattens,pixelx,rememberable,ro,te`
2 years ago
Roni Laukkarinen
36b0ff57b7
Fix grammar ( #20106 )
2 years ago
Claire
bbf74498f5
Fix validation error in SynchronizeFeaturedTagsCollectionWorker ( #20018 )
...
* Fix followers count not being updated when migrating follows
Fixes #19900
* Fix validation error in SynchronizeFeaturedTagsCollectionWorker
Also saves remote user's chosen case for hashtags
* Limit remote featured tags before validation
2 years ago
Claire
3114c826a7
Fix filter handling in status cache hydration ( #19963 )
2 years ago
Claire
5925a31b78
Fix followers count not being updated when migrating follows ( #19998 )
...
Fixes #19900
2 years ago
Claire
bb89f83cc0
Fix additional issues with status cache hydration ( #19747 )
...
* Spare one SQL query when hydrating polls
* Improve tests
* Fix more discrepancies
* Fix possible crash when the status has no application set
2 years ago
Claire
03b991de6c
Fix various issues with store hydration ( #19746 )
...
- Improve tests
- Fix possible crash when application of a reblogged post isn't set
- Fix discrepancies around favourited and reblogged attributes
- Fix discrepancies around pinned attribute
- Fix polls not being hydrated
2 years ago
Eugen Rochko
5f9e47be34
Add caching for payload serialization during fan-out ( #19642 )
2 years ago
Claire
4fb0aae636
Change mentions of blocked users to not be processed ( #19725 )
...
Fixes #19698
2 years ago
Claire
9387beb3b3
Change flaky AccountSearchService test ( #19650 )
2 years ago
Claire
1dca08b76f
Fix admin action logs page ( #19649 )
...
* Add tests
* Fix crash when trying to display orphaned action logs
* Add migration for older admin action logs
2 years ago
pea-sys
c68e6b52d9
png optimization(loss less) ( #19630 )
2 years ago
Eugen Rochko
d0ba77047e
Change max. thumbnail dimensions to 640x360px (360p) ( #19619 )
2 years ago
Eugen Rochko
40c7f3e830
Fix account action type validation ( #19476 )
...
* Fix account action type validation
Fix #19143
* Fix #19145
* Fix code style issues
2 years ago
Eugen Rochko
f8ca3bb2a1
Add ability to view previous edits of a status in admin UI ( #19462 )
...
* Add ability to view previous edits of a status in admin UI
* Change moderator access to posts to be controlled by a separate policy
2 years ago
Eugen Rochko
bf0ab3e0fa
Fix vacuum scheduler missing lock, locks never expiring ( #19458 )
...
Remove vacuuming of orphaned preview cards
2 years ago
Eugen Rochko
1ae508bf2f
Change unauthenticated search to not support pagination in REST API ( #19326 )
...
- Only exact search matches for queries with < 5 characters
- Do not support queries with `offset` (pagination)
- Return HTTP 401 on truthy `resolve` instead of overriding to false
2 years ago
Eugen Rochko
7c152acb2c
Change settings area to be separated into categories in admin UI ( #19407 )
...
And update all descriptions
2 years ago
Yamagishi Kazutoshi
94feb2b93f
Fix `FetchFeaturedCollectionService` spec ( #19401 )
...
Regression from #19380
2 years ago
Eugen Rochko
839f893168
Change public accounts pages to mount the web UI ( #19319 )
...
* Change public accounts pages to mount the web UI
* Fix handling of remote usernames in routes
- When logged in, serve web app
- When logged out, redirect to permalink
- Fix `app-body` class not being set sometimes due to name conflict
* Fix missing `multiColumn` prop
* Fix failing test
* Use `discoverable` attribute to control indexing directives
* Fix `<ColumnLoading />` not using `multiColumn`
* Add `noindex` to accounts in REST API
* Change noindex directive to not be rendered by default before a route is mounted
* Add loading indicator for detailed status in web UI
* Fix missing indicator appearing while account is loading in web UI
2 years ago
Eugen Rochko
1bd00036c2
Change about page to be mounted in the web UI ( #19345 )
2 years ago
Eugen Rochko
b04633a961
Add image processing and generate blurhash for server thumbnail ( #19348 )
...
Remove separate server hero setting
2 years ago
Yamagishi Kazutoshi
7afc6a630c
Redirect non-logged-in user to owner statuses on single user mode ( #19333 )
2 years ago
Eugen Rochko
45ebdb72ca
Add support for language preferences for trending statuses and links ( #18288 )
2 years ago
Eugen Rochko
93f340a4bf
Remove setting that disables account deletes ( #17683 )
2 years ago
Eugen Rochko
62782babd0
Change public statuses pages to mount the web UI ( #19301 )
2 years ago
Eugen Rochko
58d5b28cb0
Remove previous landing page ( #19300 )
2 years ago
Eugen Rochko
9f65909f42
Change public timelines to be filtered by current locale by default ( #19291 )
...
In the absence of an opt-in to multiple specific languages in the
preferences, it makes more sense to filter by the user's presumed
language only (interface language or `lang` override)
2 years ago
Eugen Rochko
d2528b26b6
Add server banner to web app, add `GET /api/v2/instance` to REST API ( #19294 )
2 years ago
Eugen Rochko
02ba9cfa35
Remove code for rendering public and hashtag timelines outside the web UI ( #19257 )
2 years ago
Eugen Rochko
36f4c32a38
Change path of privacy policy page ( #19249 )
2 years ago
Eugen Rochko
43b5d5e38d
Add logged-out access to the web UI ( #18961 )
2 years ago
Eugen Rochko
5c9abdeff1
Add retention policy for cached content and media ( #19232 )
2 years ago
Claire
7165e89362
Add tests to ActivityPub::FetchRemoteKeyService ( #19226 )
2 years ago
Claire
26c51cfa07
Fix various rspec warnings in ReportService tests ( #19189 )
...
* Fix various rspec warnings in ReportService tests
* Add tests to ReportService
2 years ago
Claire
8cf7006d4e
Refactor ActivityPub handling to prepare for non-Account actors ( #19212 )
...
* Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService
ActivityPub::FetchRemoteAccountService is kept as a wrapper for when the actor is
specifically required to be an Account
* Refactor SignatureVerification to allow non-Account actors
* fixup! Move ActivityPub::FetchRemoteAccountService to ActivityPub::FetchRemoteActorService
* Refactor ActivityPub::FetchRemoteKeyService to potentially return non-Account actors
* Refactor inbound ActivityPub payload processing to accept non-Account actors
* Refactor inbound ActivityPub processing to accept activities relayed through non-Account
* Refactor how Account key URIs are built
* Refactor Request and drop unused key_id_format parameter
* Rename ActivityPub::Dereferencer `signature_account` to `signature_actor`
2 years ago
Eugen Rochko
50948b46aa
Add ability to filter followed accounts' posts by language ( #19095 )
2 years ago
Claire
1145dbd327
Improve error reporting and logging when processing remote accounts ( #15605 )
...
* Add a more descriptive PrivateNetworkAddressError exception class
* Remove unnecessary exception class to rescue clause
* Remove unnecessary include to JsonLdHelper
* Give more neutral error message when too many webfinger redirects
* Remove unnecessary guard condition
* Rework how “ActivityPub::FetchRemoteAccountService” handles errors
Add “suppress_errors” keyword argument to avoid raising errors in
ActivityPub::FetchRemoteAccountService#call (default/previous behavior).
* Rework how “ActivityPub::FetchRemoteKeyService” handles errors
Add “suppress_errors” keyword argument to avoid raising errors in
ActivityPub::FetchRemoteKeyService#call (default/previous behavior).
* Fix Webfinger::RedirectError not being a subclass of Webfinger::Error
* Add suppress_errors option to ResolveAccountService
Defaults to true (to preserve previous behavior). If set to false,
errors will be raised instead of caught, allowing the caller to be
informed of what went wrong.
* Return more precise error when failing to fetch account signing AP payloads
* Add tests
* Fixes
* Refactor error handling a bit
* Fix various issues
* Add specific error when provided Digest is not 256 bits of base64-encoded data
* Please CodeClimate
* Improve webfinger error reporting
2 years ago
luzpaz
4aa3b9bd01
Fix typos ( #18604 )
...
* Fix typos
Found via `codespell -q 3 -S ./CHANGELOG.md,./AUTHORS.md,./config/locales,./app/javascript/mastodon/locales -L ba,keypair,medias,pixelx,ro`
* Follow-up typo fix
2 years ago
Eugen Rochko
0b3e4fd5de
Remove digest e-mails ( #17985 )
...
* Remove digest e-mails
* Remove digest-related code
2 years ago
Eugen Rochko
0396acf39e
Add audit log entries for user roles ( #19040 )
...
* Refactor audit log schema
* Add audit log entries for user roles
2 years ago
Claire
50487db122
Add ability to filter individual posts ( #18945 )
...
* Add database table for status-specific filters
* Add REST endpoints, entities and attributes
* Show status filters in /filters interface
* Perform server-side filtering for individual posts filters
* Fix filtering on context mismatch
* Refactor `toServerSideType` by moving it to its own module
* Move loupe and delete icons to their own module
* Add ability to filter individual posts from WebUI
* Replace keyword list by warnings (expired, context mismatch)
* Refactor server-side filtering code
* Add tests
2 years ago
Eugen Rochko
0412a4d03e
Change e-mail domain blocks to match subdomains of blocked domains ( #18979 )
2 years ago
Eugen Rochko
d83faa1a89
Add ability to block sign-ups from IP ( #19037 )
2 years ago
Claire
461239db5d
Fix backend compatibility with OpenSSL 3.0 ( #18449 )
...
* Update webpush to fork with OpenSSL 3 compatibility
* Fix tests with OpenSSL 3.0
* Update webauthn gem to latest release and update dependencies
2 years ago
Eugen Rochko
c3f0621a59
Add ability to follow hashtags ( #18809 )
2 years ago
Eugen Rochko
e7aa2be828
Change how hashtags are normalized ( #18795 )
...
* Change how hashtags are normalized
* Fix tests
2 years ago
Eugen Rochko
44b2ee3485
Add customizable user roles ( #18641 )
...
* Add customizable user roles
* Various fixes and improvements
* Add migration for old settings and fix tootctl role management
2 years ago
Claire
1b4054256f
Fix crash when a remote Flag activity mentions a private post ( #18760 )
...
* Add tests
* Fix crash when a remote Flag activity mentions a private post
2 years ago