Matt Jankowski
e0e7e73cb4
Implement pending specs for StatusesController ( #23969 )
2 years ago
Daniel M Brasil
67d0dfbc67
Improve test coverage for `/api/v1/admin/email_domain_blocks` ( #25017 )
2 years ago
Emelia Smith
8b4d7b22ed
Allow reports with long comments from remote instances, but truncate ( #25028 )
2 years ago
Daniel M Brasil
90466ee43a
Improve test coverage for `/api/v1/admin/ip_blocks_controller` ( #25031 )
2 years ago
Nick Schonning
c4f2b1e86a
Fix minor typos in comments and spec names ( #21831 )
2 years ago
Claire
9011b008c2
Add tests for avatar/header in backup service ( #25037 )
2 years ago
Matt Jankowski
9082e53002
Add spec for migration warning module ( #25033 )
2 years ago
Claire
86961b5b7b
Add polling and automatic redirection to `/start` on email confirmation ( #25013 )
2 years ago
Claire
99f1302cc3
Fix reports not being closed when performing batch suspensions ( #24988 )
2 years ago
Matt Jankowski
74c77c5274
Remove usage of random sample values in specs ( #24869 )
2 years ago
Matt Jankowski
540b446f77
Replace i18n view spec with helper spec ( #24966 )
2 years ago
Matt Jankowski
42ca35dcbc
I18n pluralization errors ( #24963 )
2 years ago
Daniel M Brasil
7cf0ce19e2
Fix uncaught NoMethodError error in `/api/v1/admin/canonical_email_blocks/test` ( #24947 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Claire
c8998a2678
Change profile updates to be sent to recently-mentioned servers ( #24852 )
2 years ago
Matt Jankowski
2500233709
Fix RSpec/RepeatedExampleGroupDescription cop ( #24850 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Matt Jankowski
bf1a16e278
Fix RSpec/SharedContext cop ( #24847 )
2 years ago
Matt Jankowski
1598cf9043
Fix RSpec/ScatteredSetup cop ( #24848 )
2 years ago
Daniel M Brasil
9c5c803c7c
Add test coverage for `Mastodon::IpBlocksCLI` ( #24935 )
2 years ago
Claire
c752e939d5
Change AccessTokensVacuum to also delete expired tokens ( #24868 )
2 years ago
Daniel M Brasil
a82a6882ad
Add test coverage for `Mastodon::SettingsCLI` ( #24856 )
2 years ago
Claire
53e3a1b06d
Fix infinite loop in AccountsStatusesCleanupScheduler ( #24840 )
2 years ago
Nick Schonning
2f2c8f671b
Autofix Rubocop Style/HashSyntax ( #23754 )
2 years ago
Nick Schonning
dfbb3a61c9
Enable Rubocop Rails/FilePath ( #23854 )
2 years ago
Matt Jankowski
cf86cc68b7
Fix RSpec/InferredSpecType cop ( #24736 )
2 years ago
Matt Jankowski
8dec215a57
Fix RSpec/ContextWording cop ( #24739 )
2 years ago
Matt Jankowski
2cd141b65f
Fix RSpec/MultipleSubjects cop ( #24738 )
2 years ago
Matt Jankowski
790aa68ea3
Misc spec cleanup ( #24822 )
2 years ago
Matt Jankowski
fded3a99ab
Spec coverage for settings/preferences/* controllers ( #24825 )
2 years ago
Claire
90b45c5040
Fix various edge cases with local moves ( #24812 )
2 years ago
Claire
f89b5c08b6
Fix own posts not getting delivered to own lists ( #24810 )
2 years ago
Claire
a4e3f98fc7
Change Move handler to also move list memberships ( #24808 )
2 years ago
Matt Jankowski
916f204ec1
Fix Lint/ConstantDefinitionInBlock cop ( #24763 )
2 years ago
Claire
ca3003835d
Improve automatic post cleanup worker performances ( #24785 )
2 years ago
Matt Jankowski
b7e49e1a70
Fix Performance/MethodObjectAsBlock cop ( #24798 )
2 years ago
Matt Jankowski
fdd7fc23c2
Fix Performance/RedundantEqualityComparisonBlock cop ( #24799 )
2 years ago
Matt Jankowski
8ecd2fbe07
Fix Lint/EmptyClass cop ( #24795 )
2 years ago
Matt Jankowski
c50acc4d2c
ApplicationHelper spec coverage, unused removal, tiny refactor ( #24762 )
2 years ago
Matt Jankowski
3030a8b458
Fix Performance/TimesMap cop ( #24789 )
2 years ago
Claire
7da78595fc
Add fallback redirection when getting a webfinger query `LOCAL_DOMAIN@LOCAL_DOMAIN` ( #23600 )
...
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
2 years ago
Claire
e964406ec3
Optimize archive export service and export zip files instead of gzipped tar files ( #23360 )
2 years ago
Claire
a247f77162
Change lists to be able to include accounts with pending follow requests ( #19727 )
2 years ago
Claire
2e33a31f80
Add request specs for caching behavior ( #24592 )
2 years ago
Claire
abce7cf2b9
Rewrite import feature ( #21054 )
2 years ago
Matt Jankowski
2a78b65bfd
Fix Rails/I18nLocaleAssignment cop ( #24693 )
2 years ago
Mark Roszko
8c1fb86333
Remove the u in Favorite for non-gb english ( #24667 )
...
Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>
2 years ago
João Pedro Marques
d00c43b9c1
Adds new follower/following routes ( #24601 )
2 years ago
Matt Jankowski
ba0a49b7f6
Fix Rails/ContentTag cop ( #24691 )
2 years ago
Matt Jankowski
807ada7b39
Fix Rails/HttpPositionalArguments cop ( #24699 )
2 years ago
Matt Jankowski
7a395989b7
Enable local account key generation spec ( #24728 )
2 years ago
Matt Jankowski
f9fcde8205
Add pending spec for User.those_who_can ( #24724 )
2 years ago
Nick Schonning
b36ccb2fac
Autofix Rubocop RSpec/MatchArray ( #24675 )
2 years ago
Nick Schonning
16cc6bc400
Autofix Rubocop RSpec/MatchArray ( #24050 )
2 years ago
Matt Jankowski
dcb91de3ba
React component helper specs ( #24072 )
2 years ago
Nick Schonning
28d554cc49
Autofix Rubocop Rails/ResponseParsedBody ( #24051 )
2 years ago
Claire
31bd0da41f
Fix anonymous visitors getting a session cookie on first visit ( #24584 )
2 years ago
Claire
84862cb2cf
Add feature test for OAuth access grant ( #24624 )
2 years ago
Matt Jankowski
f01a643897
Remove instance variables from helper usage ( #24203 )
2 years ago
Claire
d8e7a72597
Fix caching logic with regards to Accept-Language, Cookie, and Signature ( #24604 )
2 years ago
Claire
59a73ea537
Fix AccountsStatusesCleanupScheduler not spreading deletes across accounts correctly ( #24607 )
2 years ago
Eugen Rochko
3ca64638d4
Refactor `Cache-Control` and `Vary` definitions ( #24347 )
2 years ago
Robert R George
335b53ab48
Add trend management to admin API ( #24257 )
2 years ago
Heitor de Melo Cardozo
a34c422490
Change moderation search an account using the username with @ ( #24242 )
2 years ago
Heitor de Melo Cardozo
e2760bd0ee
Add user handle to notification mail recipient address ( #24240 )
...
Co-authored-by: luccamps <luccamps@users.noreply.github.com>
Co-authored-by: Leonardo Negreiros de Oliveira <negreirosleo12@gmail.com>
Co-authored-by: Marcio Flavio <mflaviof1995@gmail.com>
Co-authored-by: Gabriel Quaresma <j.quaresmasantos_98@hotmail.com>
2 years ago
Matt Jankowski
1c31bdc9fc
Refactor race condition reblog service spec ( #24526 )
2 years ago
Claire
1afa6d8cbf
Refactor `Status._insert_record` slightly and tighten the test around reblogs of discarded statuses ( #24516 )
2 years ago
Matt Jankowski
761f2750fd
Spec coverage on Settings/ controllers specs ( #24221 )
2 years ago
Matt Jankowski
c5f965afcf
Clean up the post deployment migration generator ( #24233 )
2 years ago
Matt Jankowski
e323372ebe
Expand coverage for "system checks" ( #24216 )
2 years ago
Christian Schmidt
41190c8172
Wrong type for user setting when default is defined by lambda ( #24321 )
2 years ago
Eugen Rochko
c75fccf033
Change user settings to be stored in a more optimal way ( #23630 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Christian Schmidt
72b4973f50
Requeue expiration notification ( #24311 )
2 years ago
Eugen Rochko
1d2a941bc8
Change media upload limits and remove client-side resizing ( #23726 )
2 years ago
Matt Jankowski
d38c3ba12e
Add specs for Chewy importers ( #24204 )
2 years ago
Christian Schmidt
7583523bf0
Replace `Status#translatable?` with language matrix in separate endpoint ( #24037 )
2 years ago
Nick Schonning
6d0a49f4a4
Autofix Rubocop Style/PreferredHashMethods ( #23851 )
2 years ago
Claire
8a618c8eca
Fix misleading error code when receiving invalid WebAuthn credentials ( #23568 )
2 years ago
Matt Jankowski
a7bc6ae1de
Add spec for the CLI `version` task ( #23978 )
2 years ago
Matt Jankowski
00f9e14d13
Add basic search specs for chewy indexes ( #24065 )
2 years ago
Matt Jankowski
7a8257b638
Coverage improvement round-out following up previous work ( #23987 )
2 years ago
Matt Jankowski
c5c1e07555
Serializers spec coverage ( #24017 )
2 years ago
Matt Jankowski
76950ce2bc
Explicitly set github repo in instance presenter spec ( #24036 )
2 years ago
Christian Schmidt
170d3a0bc8
Unescape HTML entities ( #24019 )
2 years ago
Matt Jankowski
f6f3004420
Fix spec for api/v1/statuses/translations ( #23956 )
2 years ago
Matt Jankowski
d1984eb87f
Restore missing fabricators ( #23951 )
2 years ago
Matt Jankowski
db41d60d04
Pending example models minimal coverage ( #23912 )
2 years ago
Matt Jankowski
471346fd3a
User mailer spec coverage improvements ( #23905 )
2 years ago
Matt Jankowski
6e2d11ff48
Admin controllers specs ( #23917 )
2 years ago
Matt Jankowski
9a16204737
Specs api v1 controllers ( #23930 )
2 years ago
Matt Jankowski
5676537303
Fabricator specs ( #23925 )
2 years ago
Matt Jankowski
c48dd42fa8
Misc coverage improvements for validators ( #23928 )
2 years ago
Matt Jankowski
6210055dde
Helpers specs coverage improvement ( #23937 )
2 years ago
Matt Jankowski
5149123d20
Policies specs ( #23924 )
2 years ago
Matt Jankowski
5b612db821
Settings controllers specs ( #23915 )
2 years ago
Matt Jankowski
9e213fd37d
Add basic coverage for some worker jobs ( #23943 )
2 years ago
Matt Jankowski
bf674337d9
Models specs coverage ( #23940 )
2 years ago
Christian Schmidt
cc0c37cd69
Only offer translation for supported languages ( #23879 )
2 years ago
Claire
f1c31853e3
Add tests for moderation actions without custom text ( #23184 )
2 years ago
Claire
7bc43c91a0
Fix “Remove all followers from the selected domains” being more destructive than it claims ( #23805 )
2 years ago
Claire
16c8144b1c
Add support for incoming rich text ( #23913 )
2 years ago
Matt Jankowski
35cbd0685d
Fix deprecation warning about merging conditions ( #23618 )
2 years ago
Matt Jankowski
0d409f9fd7
Update rspec-rails to version 6.0.1 ( #23908 )
2 years ago
Matt Jankowski
0fe721074b
Add spec coverage for Admin::Trends::StatusesHelper ( #23898 )
2 years ago
Stanislav Dobrovolschii
eaea285368
Add rspecs for FollowRecommendationsScheduler ( #23890 )
2 years ago
Matt Jankowski
5bf8f34842
Spec coverage for HomeHelper ( #23907 )
2 years ago
Matt Jankowski
04082726de
Admin mailer spec coverage improvement ( #23863 )
2 years ago
Matt Jankowski
7e7fa6cb40
Add policies and serializers groups to simplecov output ( #23897 )
2 years ago
Matt Jankowski
385ae6681d
Fix single-record invalid condition on PollVote ( #23810 )
2 years ago
Nick Schonning
1cdd7d6c8f
Rename ActivityPub Serializer Specs ( #23844 )
2 years ago
Claire
bc4837a600
Change auto-deletion throttling constants to better scale with server size ( #23320 )
2 years ago
Nick Schonning
43a3812265
Fix mispelled spec filenames ( #23834 )
2 years ago
Claire
3423976bda
Fix rack:attack flaky tests and test end of throttle period ( #23799 )
2 years ago
Nick Schonning
eb6991cee1
Autofix Rubocop Rails/RootPathnameMethods ( #23760 )
2 years ago
Nick Schonning
dd46810e8a
Enable Style/FrozenStringLiteralComment for specs ( #23790 )
2 years ago
Nick Schonning
247bf6e812
Enable Rubocop Style/StringConcatenation defaults ( #23792 )
2 years ago
Nick Schonning
25cf99e513
Autofix Rubocop Security/IoMethods ( #23757 )
2 years ago
Nick Schonning
9376fccf91
Autofix Rubocop Style/SymbolProc ( #23742 )
2 years ago
Nick Schonning
e6312104c7
Autofix Rubocop remaining Layout rules ( #23679 )
2 years ago
Nick Schonning
a4cbfac4d9
Autofix Rubocop RSpec/BeEq ( #23740 )
2 years ago
Nick Schonning
c0f0c42326
Audofix Rubocop Style/WordArray ( #23739 )
2 years ago
Nick Schonning
754c417e29
Autofix Rubocop RSpec/LeadingSubject ( #23670 )
2 years ago
Nick Schonning
a1e0384fc5
Enable Rubocop RSpec/ExpectActual ( #23720 )
2 years ago
Nick Schonning
ac56c3971b
Autofix Rubocop RSpec/ImplicitSubject ( #23721 )
2 years ago
Nick Schonning
0d47dee648
Autofix Rubocops RSpec/ScatteredLet ( #23725 )
2 years ago
Nick Schonning
ae51248ffe
Enable Rubocop HTTP status rules ( #23717 )
2 years ago
Nick Schonning
f6c4699d73
Autofix Rubocop RSpec/EmptyLineAfterSubject ( #23719 )
2 years ago
Nick Schonning
181617e3d9
Autofix Rubocop Lint/UnusedBlockArgument ( #23712 )
2 years ago
Nick Schonning
a25f6522da
Enable Rubocop RSpec/NotToNot ( #23723 )
2 years ago
Nick Schonning
1de4bdbaf4
Autofix Rubocop RSpec/ReturnFromStub ( #23724 )
2 years ago
Nick Schonning
b8f17330ea
Autofix Rubocop Rails/Pluck ( #23730 )
2 years ago
Nick Schonning
e08a42e1d7
Autofix Rubocop RSpec/EmptyLineAfterHook ( #23718 )
2 years ago
Nick Schonning
be1ec56c6d
Autofix Rubocop Style/StringLiterals ( #23695 )
2 years ago
Nick Schonning
28b19386c1
Autofix Rubocop RSpec/LetBeforeExamples ( #23671 )
2 years ago
Nick Schonning
bfc66a0454
Autofix Rubocop Style/EmptyLambdaParameter ( #23705 )
2 years ago
Nick Schonning
a63cb79201
Autofix Rubocop RSpec/EmptyLineAfterFinalLet ( #23707 )
2 years ago
Nick Schonning
e9074c3eb5
Autofix Rubocop Style/BlockDelimiters ( #23706 )
2 years ago
Nick Schonning
2e4833b246
Autofix Rubocop RSpec/Capybara/FeatureMethods ( #23708 )
2 years ago
Nick Schonning
6988b04ec7
Autofix Rubocop Style/TrailingCommaInArrayLiteral ( #23692 )
2 years ago
Nick Schonning
4dc470fbee
Autofix Rubocop Style/TrailingCommaInHashLiteral ( #23693 )
2 years ago
Nick Schonning
a2129d336a
Autofix Rubocop RSpec/ExcessiveDocstringSpacing ( #23666 )
2 years ago
Nick Schonning
7f8439ee07
Autofix Rubocop Style/TrailingCommaInArguments ( #23694 )
2 years ago
Nick Schonning
793f8c7dd5
Autofix Rubocop Style/IfUnlessModifier ( #23697 )
2 years ago
Nick Schonning
bc31a28361
Apply Rubocop Style/RedundantConstantBase ( #23463 )
2 years ago
Nick Schonning
35dbf602f2
Autofix Rubocop Lint/ParenthesesAsGroupedExpression ( #23682 )
2 years ago
Nick Schonning
c402904fa1
Enable Rubocop RSpec/HooksBeforeExamples ( #23668 )
2 years ago
Nick Schonning
298f61ecef
Autofix Rubocop Style/RedundantPercentQ ( #23651 )
2 years ago
Nick Schonning
f8947c2042
Autofix Rubocop RSpec/ExampleWording ( #23667 )
2 years ago
Nick Schonning
24f4789d2b
Enable Rubocop RSpec/MultipleDescribes ( #23672 )
2 years ago
Nick Schonning
92d606bc98
Autofix Rubocop RSpec/ClassCheck ( #23685 )
2 years ago
Nick Schonning
a71a0802d6
Autofix Rubocop Lint/SymbolConversion ( #23683 )
2 years ago
Nick Schonning
efcf9f0076
Autofix Rubocop Lint/AmbiguousOperator ( #23680 )
2 years ago
Nick Schonning
8fa4163574
Enable Rubocop Style/NumericLiterals ( #23647 )
2 years ago
Nick Schonning
31ca76fe2c
Run rubocop formatting except line length ( #23632 )
2 years ago
Nick Schonning
a45f8ff02d
Autofix Rubocop RSpec/EmptyLineAfterExample ( #23661 )
2 years ago
Nick Schonning
284a6902cc
Autofix Rubocop RSpec/BeNil ( #23653 )
2 years ago
Nick Schonning
c754596ce3
Autofix Rubocop Style/NestedParenthesizedCalls ( #23646 )
2 years ago
Nick Schonning
cb763ecb74
Autofix Rubocop Style/MethodCallWithoutArgsParentheses ( #23645 )
2 years ago
Claire
d706570d30
Add `memorial` attribute to REST API ( #23591 )
2 years ago
Claire
0ae0740826
Add API parameter to safeguard unexpect mentions in new posts ( #18350 )
2 years ago
Varun Sharma
1ac0afccc2
Add tests to indicate inclusion of self replies in statuses endpoint ( #23266 )
2 years ago
Claire
5410c06ca1
Add tests for `REST::AccountSerializer` ( #23319 )
2 years ago
Claire
ea4cffac37
Fix unbounded recursion in post discovery ( #23506 )
...
* Add a limit to how many posts can get fetched as a result of a single request
* Add tests
* Always pass `request_id` when processing `Announce` activities
---------
Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>
2 years ago
Nick Schonning
ae45c9ccd4
Apply Rubocop Rails/WhereNot ( #23448 )
...
* Apply Rubocop Rails/WhereNot
* Update spec for where.not
2 years ago
Nick Schonning
8a2b91488a
Apply Rubocop Style/ExpandPathArguments ( #23450 )
2 years ago
Nick Schonning
38ec6d27d8
Autofix Rails/EagerEvaluationLogMessage ( #23429 )
...
* Autofix Rails/EagerEvaluationLogMessage
* Update spec for debug block syntax
2 years ago
Claire
a173d5248f
Fix `UserCleanupScheduler` crash when an unconfirmed account has a moderation note ( #23318 )
...
* Fix `UserCleanupScheduler` crash when an unconfirmed account has a moderation note
* Add tests
2 years ago
Claire
3536a88bc9
Change `POST /settings/applications/:id` to regenerate token on scopes change ( #23359 )
...
Fixes #23096
2 years ago
Claire
9e5f274ba9
Add `roles` attribute to Account entities in REST API ( #23255 )
2 years ago
Claire
1c279cca28
Fix email with empty domain name labels passing validation ( #23246 )
...
* Fix email with empty domain name labels passing validation
`EmailMxValidator` would allow empty labels because `Resolv::DNS` is
particularly lenient about them, but the email would be invalid and
unusable.
* Add tests
2 years ago
Claire
d28bbdfd48
Fix account activation being triggered before email confirmation ( #23245 )
...
* Add tests
* Fix account activation being triggered before email confirmation
Fixes #23098
2 years ago
Markus Unterwaditzer
4a902cc7f6
Suppress AddressFamilyError in link verification ( #23204 )
...
* Suppress AddressFamilyError
* clarify comment
2 years ago
Claire
1e9d799c0a
Add missing `policy` attribute to `WebPushSubscriptionSerializer` ( #23210 )
...
* Add missing `policy` attribute to `WebPushSubscriptionSerializer`
Fixes #23145
* Add tests
2 years ago
Claire
b131e01db7
Add more specific error messages to HTTP signature verification ( #21617 )
...
* Return specific error on failure to parse Date header
* Add error message when preferredUsername is not set
* Change error report to be JSON and include more details
* Change error report to differentiate unknown account and failed refresh
* Add tests
2 years ago
Claire
592fe1a3bd
Add confirmation screen when handling reports ( #22375 )
...
* Add confirmation screen on moderation actions
* Add flash notice when a report has been processed
* Refactor tests
* Add tests
2 years ago
Claire
42aa864c84
Add support for editing media description and focus point of already-posted statuses ( #20878 )
...
* Add backend support for editing media attachments of existing posts
* Allow editing media attachments of already-posted toots
* Add tests
2 years ago
Claire
0687eb20da
Change domain block CSV parsing to be more robust and handle more lists ( #21470 )
...
* Change domain block CSV parsing to be more robust and handle more lists
* Add some tests
* Improve domain block import validation and reporting
2 years ago
Claire
64952cef52
Fix crash when marking statuses as sensitive while some statuses are deleted ( #22134 )
...
* Do not offer to mark statuses as sensitive if there is no undeleted status with media attachments
* Fix crash when marking statuses as sensitive while some statuses are deleted
Fixes #21910
* Fix multiple strikes being created for a single report when selecting “Mark as sensitive”
* Add tests
2 years ago
Claire
614dd22095
Fix sanitizer parsing link text as HTML when stripping unsupported links ( #22558 )
2 years ago
Markus Unterwaditzer
b7f37e68ad
fix: allow verification when page size exceeds 1MB (using HTML5 parser) ( #22879 )
...
* fix: allow verification when page size exceeds 1MB
Truncates the page after 1MB instead
Closes #15316
* switch to HTML5 parser, fix rubocop errors
* undo rubocop fixes
Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com>
2 years ago
Claire
6ccc1c09b6
Fix possible race conditions when suspending/unsuspending accounts ( #22363 )
...
* Fix possible race conditions when suspending/unsuspending accounts
* Fix tests
Tests were assuming SuspensionWorker and UnsuspensionWorker would do the
suspending/unsuspending themselves, but this has changed.
2 years ago
Jeong Arm
5180ae5bf6
Fix home TL could contain post from who blocked me ( #22849 )
...
* Fix home tl contains post from who blocked me
* Add test
* Fix feed_manager's build_crutches
blocked_by was not includes status' owner
* Add test for status from I blocked
* Fix typo
2 years ago
Partho Ghosh
5cdba7b239
Fix ・ detection in hashtag regex to construct hashtag correctly ( #22888 )
...
* Fix ・ detection in hashtag regex to construct hashtag correctly
* Fixed rubocop liniting issues
* More rubocop linting fix
2 years ago
Claire
cfeb01b17f
Add follow request banner on account header ( #20785 )
...
* Add requested_by to relationship maps
* Display whether an account has requested to follow you on their profile
2 years ago
Claire
94d294202b
Fix changing domain block severity not undoing individual account effects ( #22135 )
...
* Fix changing domain block severity not undoing individual account effects
Fixes #22133
* Add tests
2 years ago
Jeong Arm
0bcfa2b429
Save avatar or header correctly even if other one fails ( #18465 )
...
* Save avatar or header correctly if other one fails
* Fix test
2 years ago
Neil Matatall
728cfe0c1c
Use Rails tag API to build RSS feed for spoilers and polls ( #20163 )
...
* Use Rails tag API to build RSS feed for spoilers and polls
While the previous method did not contain a bug or a potential issue,
the tag API can be very resilient against future problems and reduces the
amount of manual management of the escape status of the content.
I've added tests to ensure that the formatting is broken and still
escapes control characters correctly.
* this seems cleaner and passes
* Incorporate feedback by moving the br to its own line and using the tag helper over the string constant for the br tag itself
* whoops, tag helper doesn't use a self-closing tag
2 years ago
Ikko Ashimine
3c4c932938
Fix typo in application_helper_spec.rb ( #20981 )
...
enviroment -> environment
2 years ago
Francis Murillo
3a11a90dd3
Revoke all authorized applications on password reset ( #21325 )
...
* Clear sessions on password change
* Rename User::clear_sessions to revoke_access for a clearer meaning
* Add reset paassword controller test
* Use User.find instead of User.find_for_authentication for reset password test
* Use redirect and render for better test meaning in reset password
Co-authored-by: Effy Elden <effy@effy.space>
2 years ago
Meisam
ad2610c413
Validate nodeinfo response by schema ( #21395 )
...
* add json-schema to :test in Gemfile
* Create node_info_2.0_schema.json
* test match_response_schema
* Create match_response_schema.rb
* Update nodeinfo_controller_spec.rb
* Rename spec/support/node_info_2.0_schema.json to spec/support/schema/node_info_2.0_schema.json
* Update match_response_schema.rb
* cleanup
* additionally validate the json schema itself
disable throwing errors
test the schema matcher
* rename nodeinfo schema to nodeinfo_2.0
* use Rails.root.join to construct the path
* prettify json
* sync Gemfile.lock
2 years ago
Claire
d4e4d272e1
Fix 500 error when trying to migrate to an invalid address ( #21462 )
...
* Fix 500 error when trying to migrate to an invalid address
* Add tests
2 years ago
Francis Murillo
5ad9fea52a
Log admin approve and reject account ( #22088 )
...
* Log admin approve and reject account
* Add unit tests for approve and reject logging
2 years ago
Claire
aec7de494f
Fix unbounded recursion in account discovery ( #22025 )
...
* Fix trying to fetch posts from other users when fetching featured posts
* Rate-limit discovery of new subdomains
* Put a limit on recursively discovering new accounts
2 years ago
Claire
b97260426b
Fix irreversible and whole_word parameters handling in /api/v1/filters ( #21988 )
...
Fixes #21965
2 years ago
Claire
be16e6f26c
Fix attachments of edited statuses not being fetched ( #21565 )
...
* Fix attachments of edited statuses not being fetched
* Fix tests
2 years ago
Claire
655ad99a37
Fix not being able to follow more than one hashtag ( #21285 )
...
Fixes regression from #20860
2 years ago
David Leadbeater
72a60150de
Don't allow URLs that contain non-normalized paths to be verified ( #20999 )
...
* Don't allow URLs that contain non-normalized paths to be verified
This stops things like https://example.com/otheruser/../realuser where
"/otheruser" appears to be the verified URL, but the actual URL being
verified is "/realuser" due to the "/../".
Also fix a test to use 'https', so it is testing the right thing, now
that since #20304 https is required.
* missing do
2 years ago
Rose
b54c639482
Fix style for hashes ( #20518 )
...
* Fix style for hashes
Make the style for hashes consistent.
* New style
More consistency
2 years ago
lenore gilbert
498e9478c7
Support for import/export of instance-level domain blocks/allows for 4.x w/ additional fixes ( #20597 )
...
* Allow import/export of instance-level domain blocks/allows (#1754 )
* Allow import/export of instance-level domain blocks/allows.
Fixes #15095
* Pacify circleci
* Address simple code review feedback
* Add headers to exported CSV
* Extract common import/export functionality to
AdminExportControllerConcern
* Add additional fields to instance-blocked domain export
* Address review feedback
* Split instance domain block/allow import/export into separate pages/controllers
* Address code review feedback
* Pacify DeepSource
* Work around Paperclip::HasAttachmentFile for Rails 6
* Fix deprecated API warning in export tests
* Remove after_commit workaround
(cherry picked from commit b8319d0578
)
* Add confirmation page when importing blocked domains (#1773 )
* Move glitch-soc-specific strings to glitch-soc-specific locale files
* Add confirmation page when importing blocked domains
(cherry picked from commit 73a2e3326f
)
* Fix authorization check in domain blocks controller
(cherry picked from commit 655bac2c3a
)
* Fix error strings for domain blocks and email-domain blocks
Corrected issue with non-error message used for Mastodon:NotPermittedError in Domain Blocks
Corrected issue Domain Blocks using the Email Domain Blocks message on ActionContoller::ParameterMissing
Corrected issue with Email Domain Blocks using the not_permitted string from "custom emojii's"
* Ran i18n-tasks normalize to address test failure
* Removed unused admin.export_domain_blocks.not_permitted string
Removing unused string as indicated by Check i18n
* Fix tests
(cherry picked from commit 1ba41b34c1
)
* Fix domain block export not exporting blocks with only media rejection
(cherry picked from commit 1686374b2f
)
* Fix various issues with domain block import
- stop using Paperclip for processing domain allow/block imports
- stop leaving temporary files
- better error handling
- assume CSV files are UTF-8-encoded
(cherry picked from commit cad824d8f501b95377e4f0a957e5a00d517a1902)
Co-authored-by: Levi Bard <taktaktaktaktaktaktaktaktaktak@gmail.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Joshua Wood
e0940d04f1
Handle links with no href in VerifyLinkService ( #20741 )
...
Before this change, the following error would cause VerifyAccountLinksWorker to fail:
NoMethodError: undefined method `downcase' for nil:NilClass
[PROJECT_ROOT]/app/services/verify_link_service.rb:31 :in `block in link_back_present?`
2 years ago
Eugen Rochko
e18c8537e6
Fix rate limiting for paths with formats ( #20675 )
2 years ago
trwnh
72d3607229
Move V2 Filter methods under /api/v2 prefix ( #20622 )
...
* Move V2 Filter methods under /api/v2 prefix
* move over the tests too
2 years ago