c97b611b6b
Fix RSpec/InferredSpecType cop ( #24736 )
2 years ago
710745e16b
Fix RSpec/ContextWording cop ( #24739 )
2 years ago
cf18cc2891
Fix RSpec/MultipleSubjects cop ( #24738 )
2 years ago
2c6c398c60
Fix Performance/CollectionLiteralInLoop cop ( #24819 )
2 years ago
d9a958fcf7
Fix Performance/RedundantMerge cop ( #24817 )
2 years ago
3df665fd23
Fix Lint/ConstantDefinitionInBlock cop ( #24763 )
2 years ago
a0c9f2447e
Fix Performance/MethodObjectAsBlock cop ( #24798 )
2 years ago
97385f27bd
Fix Performance/RedundantEqualityComparisonBlock cop ( #24799 )
2 years ago
668a19a2f3
Fix Performance/DeletePrefix cop ( #24796 )
2 years ago
05e3abe9d9
Fix Lint/EmptyClass cop ( #24795 )
2 years ago
24491abf6d
Fix Rails/DeprecatedActiveModelErrorsMethods cop ( #24742 )
2 years ago
b5c4b47746
Fix Rails/ActiveRecordCallbacksOrder cop ( #24689 )
2 years ago
38b2974a83
Extract AccountSearch concern from Account ( #24716 )
2 years ago
f1c1dd0118
Rename `with_lock` to `with_redis_lock` to avoid confusion with ActiveRecord's method ( #24741 )
2 years ago
570079f8ce
Fix Performance/TimesMap cop ( #24789 )
2 years ago
bae694108a
Fix Performance/Count cop ( #24793 )
2 years ago
5e060e1f44
Fix Performance/Sum cop ( #24788 )
2 years ago
88d33f361f
Fix Lint/DuplicateBranch cop ( #24766 )
2 years ago
32a030dd74
Rewrite import feature ( #21054 )
2 years ago
c53fe9b753
Fix RSpec/BeforeAfterAll cop ( #24737 )
2 years ago
d902a707a3
Fix Rails/CompactBlank cop ( #24690 )
2 years ago
d00e45a7d3
Fix Rails/I18nLocaleAssignment cop ( #24693 )
2 years ago
af824db398
Fix Rails/InverseOf cop ( #24732 )
2 years ago
2e43461100
Fix Rails/Output cop ( #24687 )
2 years ago
5a2aa06a51
Fix Rails/Present cop ( #24688 )
2 years ago
bdc74086e6
Fix Rails/ContentTag cop ( #24691 )
2 years ago
6e226f5a32
Fix Rails/ActionOrder cop ( #24692 )
2 years ago
60ac9e8634
Fix Rails/SquishedSQLHeredocs cop ( #24694 )
2 years ago
8dcfb6e0ea
Fix Rails/HttpPositionalArguments cop ( #24699 )
2 years ago
4cfe52635c
Add pending spec for User.those_who_can ( #24724 )
2 years ago
12b935fadf
Merge branch 'main' into glitch-soc/merge-upstream
...
Conflicts:
- `.github/dependabot.yml`:
Updated upstream, removed in glitch-soc to disable noise.
Kept removed.
- `CODE_OF_CONDUCT.md`:
Upstream updated to a new version of the covenant, but I have not read it
yet, so kept unchanged.
- `Gemfile.lock`:
Not a real conflict, one upstream dependency updated textually too close to
the glitch-soc only `hcaptcha` dependency.
Applied upstream changes.
- `app/controllers/admin/base_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/controllers/application_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/controllers/disputes/base_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/controllers/relationships_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/controllers/statuses_cleanup_controller.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/helpers/application_helper.rb`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `app/javascript/mastodon/features/compose/components/compose_form.jsx`:
Upstream added a highlight animation for onboarding, while we changed the
max character limit.
Applied our local changes on top of upstream's new version.
- `app/views/layouts/application.html.haml`:
Minor conflict due to glitch-soc's theming system.
Applied upstream changes.
- `stylelint.config.js`:
Upstream added ignore paths, glitch-soc had extra ignore paths.
Added the same paths as upstream.
2 years ago
49fad26eca
Drop EOL Ruby 2.7 ( #24237 )
2 years ago
5841f1af8c
Autofix Rubocop RSpec/MatchArray ( #24675 )
2 years ago
a3393d0d07
Autofix Rubocop RSpec/MatchArray ( #24050 )
2 years ago
90beba57d8
Autofix Rubocop Rails/ResponseParsedBody ( #24051 )
2 years ago
0a5f0a8b20
Remove instance variables from helper usage ( #24203 )
2 years ago
4687967176
Autofix Rubocop Style/NumericLiterals ( #24468 )
2 years ago
e98c86050a
Refactor `Cache-Control` and `Vary` definitions ( #24347 )
2 years ago
ff168ef202
Fix most rubocop issues ( #2165 )
...
* Run rubocop --autocorrect on app/, config/ and lib/, also manually fix some remaining style issues
* Run rubocop --autocorrect-all on db/
* Run rubocop --autocorrect-all on `spec/` and fix remaining issues
2 years ago
cb2ce842b0
Autofix Rubocop Rails/IgnoredColumnsAssignment ( #23761 )
2 years ago
500d6f93be
Autofix Rubocop Style/IdenticalConditionalBranches ( #24322 )
2 years ago
83fc97285b
Enable Rubocop Metrics/BlockLength with Excludes ( #24260 )
2 years ago
a9b5598c97
Change user settings to be stored in a more optimal way ( #23630 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
503022d6f9
Exclude files for Rubocop Metrics/ClassLength ( #24213 )
2 years ago
7bef11630d
Remove references to non-existent actions ( #24183 )
2 years ago
94cbd808b5
Webhooks for local status.create, status.update, account.update ( #24133 )
2 years ago
b22b4bac03
Include config/ and update all rubcop deps ( #23963 )
2 years ago
681dcd3fa3
Ignore additional Style/OptionalBooleanParameter ( #24138 )
2 years ago
edc7ca5920
Roll back unintentionally activated rubocop rules ( #24132 )
...
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
2 years ago
bd047acc35
Replace `Status#translatable?` with language matrix in separate endpoint ( #24037 )
2 years ago
aa947a143b
Regen rubocop-todo without Max shadowing ( #24076 )
2 years ago
25d36b6edd
Autofix Rubocop Style/RedundantArgument ( #23798 )
2 years ago
a38f67c1c3
Autofix Rubocop Style/PreferredHashMethods ( #23851 )
2 years ago
e762a14c0a
Enable Rubocop Performance/DeleteSuffix ( #24077 )
2 years ago
3ea0856f70
Enable RSpec/FilePath ( #23965 )
2 years ago
688287c59d
Coverage improvement round-out following up previous work ( #23987 )
2 years ago
56bddfbfa3
Serializers spec coverage ( #24017 )
2 years ago
aa98c8fbeb
Disable Style/SymbolArray ( #23921 )
2 years ago
56489cdc4f
Autofix Rubocop Style/HashConversion ( #23852 )
2 years ago
730bb3e211
Remove unused HTML Validator ( #23866 )
2 years ago
19614ba247
Rename ActivityPub Serializer Specs ( #23844 )
2 years ago
6bd7003799
Fix mispelled spec filenames ( #23834 )
2 years ago
4ff44be134
Autofix Rubocop Rails/Blank ( #23765 )
2 years ago
8fd3fc404d
Autofix Rubocop Rails/RootPathnameMethods ( #23760 )
2 years ago
0cfdd1a401
Enable Rubocop Style/StringConcatenation defaults ( #23792 )
2 years ago
434770f580
Autofix Rubocop Rails/FindById ( #23762 )
2 years ago
35d032500b
Autofix Rubocop Security/IoMethods ( #23757 )
2 years ago
9909b4b653
Autofix Rubocop Rails/WhereEquals ( #23759 )
2 years ago
59c8d43d94
Autofix Rubocop Style/RescueStandardError ( #23745 )
2 years ago
2c3c734bcc
Autofix Rubocop Style/SymbolProc ( #23742 )
2 years ago
af4c95100c
Autofix Rubocop Style/FormatString ( #23743 )
2 years ago
717683d1c3
Autofix Rubocop remaining Layout rules ( #23679 )
2 years ago
d2dcb6c45a
Autofix Rubocop Style/UnpackFirst ( #23741 )
2 years ago
5116347eb7
Autofix Rubocop RSpec/BeEq ( #23740 )
2 years ago
bf785df9fe
Audofix Rubocop Style/WordArray ( #23739 )
2 years ago
4552685f6b
Autofix Rubocop RSpec/LeadingSubject ( #23670 )
2 years ago
4ea1e0fceb
Enable Rubocop RSpec/ExpectActual ( #23720 )
2 years ago
38a1d8bb85
Autofix Rubocop RSpec/ImplicitSubject ( #23721 )
2 years ago
63e6353886
Autofix Rubocop Rails/EnumHash ( #23737 )
2 years ago
f0e1b12c10
Autofix Rubocop Style/ExplicitBlockArgument ( #23704 )
2 years ago
5179c47087
Autofix Rubocops RSpec/ScatteredLet ( #23725 )
2 years ago
aef0051fd0
Enable Rubocop HTTP status rules ( #23717 )
2 years ago
bd1d57c230
Autofix Rubocop RSpec/EmptyLineAfterSubject ( #23719 )
2 years ago
dbc6d7b276
Autofix Rubocop Lint/UnusedBlockArgument ( #23712 )
2 years ago
65ba0d92ef
Enable Rubocop RSpec/NotToNot ( #23723 )
2 years ago
a2fdb388eb
Autofix Rubocop RSpec/ReturnFromStub ( #23724 )
2 years ago
21bf326356
Autofix Rubocop Rails/Pluck ( #23730 )
2 years ago
597767a9f7
Autofix Rubocop Rails/RedundantForeignKey ( #23731 )
2 years ago
8ef09813a2
Autofix Rubocop Style/EmptyMethod ( #23732 )
2 years ago
e0e63b73ee
Autofix Rubocop RSpec/EmptyLineAfterHook ( #23718 )
2 years ago
81ad6c2e39
Autofix Rubocop Style/StringLiterals ( #23695 )
2 years ago
ac3561098e
Autofix Rubocop RSpec/LetBeforeExamples ( #23671 )
2 years ago
1a02101100
Autofix Rubocop Style/EmptyLambdaParameter ( #23705 )
2 years ago
3680e032b4
Autofix Rubocop RSpec/EmptyLineAfterFinalLet ( #23707 )
2 years ago
2177daeae9
Autofix Rubocop Style/RedundantBegin ( #23703 )
2 years ago
167709f6b0
Autofix Rubocop Style/BlockDelimiters ( #23706 )
2 years ago
c0d7c855b3
Autofix Rubocop RSpec/Capybara/FeatureMethods ( #23708 )
2 years ago
08289a38fa
Autofix Rubocop Style/TrailingCommaInArrayLiteral ( #23692 )
2 years ago
5069769cbe
Autofix Rubocop Style/TrailingCommaInHashLiteral ( #23693 )
2 years ago
b4cbfff3eb
Autofix Rubocop RSpec/ExcessiveDocstringSpacing ( #23666 )
2 years ago
c38bd17657
Autofix Rubocop Style/TrailingCommaInArguments ( #23694 )
2 years ago
ab7816a414
Autofix Rubocop Style/Lambda ( #23696 )
2 years ago
e2a3ebb271
Autofix Rubocop Style/IfUnlessModifier ( #23697 )
2 years ago
8aee4de034
Autofix Rubocop Style/PerlBackrefs ( #23649 )
2 years ago
a6f77aa28a
Autofix Rubocop Lint/AmbiguousOperatorPrecedence ( #23681 )
2 years ago
e2567df860
Enable Lint/RedundantCopDisableDirective ( #23687 )
2 years ago
d65b2c1924
Apply Rubocop Style/RedundantConstantBase ( #23463 )
2 years ago
a7db0b41cd
Autofix Rubocop Lint/ParenthesesAsGroupedExpression ( #23682 )
2 years ago
e5cf23cf3a
Enable Rubocop RSpec/HooksBeforeExamples ( #23668 )
2 years ago
efd424506a
Autofix Rubocop Style/RedundantPercentQ ( #23651 )
2 years ago
c0a645f647
Autofix Rubocop RSpec/ExampleWording ( #23667 )
2 years ago
7a3d4c3d4b
Enable Rubocop RSpec/MultipleDescribes ( #23672 )
2 years ago
54318dcd6d
Autofix Rubocop RSpec/ClassCheck ( #23685 )
2 years ago
634368c491
Autofix Rubocop Lint/SymbolConversion ( #23683 )
2 years ago
6d42820e5d
Autofix Rubocop Lint/AmbiguousOperator ( #23680 )
2 years ago
ac59d6f19f
Enable Rubocop Style/NumericLiterals ( #23647 )
2 years ago
669f6d2c0a
Run rubocop formatting except line length ( #23632 )
2 years ago
593bb8ce99
Autofix Rubocop Style/RaiseArgs ( #23650 )
2 years ago
6ed6c41724
Autofix Rubocop RSpec/EmptyLineAfterExample ( #23661 )
2 years ago
68b1071f86
Autofix Rubocop RSpec/BeNil ( #23653 )
2 years ago
936204b9ea
Autofix Rubocop Style/NestedParenthesizedCalls ( #23646 )
2 years ago
37914c8757
Autofix Rubocop Style/MethodCallWithoutArgsParentheses ( #23645 )
2 years ago
68a92c81bf
Generate minimimal Rubocop Todo file ( #23629 )
2 years ago
Matt Jankowski
Claire
Nick Schonning
Eugen Rochko
Vyr Cossont
Christian Schmidt