Nick Schonning
a0e4d69c12
Autofix Rubocop Rails/FindById ( #23762 )
2 years ago
Nick Schonning
e6312104c7
Autofix Rubocop remaining Layout rules ( #23679 )
2 years ago
Nick Schonning
ae51248ffe
Enable Rubocop HTTP status rules ( #23717 )
2 years ago
Nick Schonning
49f1168050
Autofix Rubocop Style/RedundantBegin ( #23703 )
2 years ago
Nick Schonning
7f8439ee07
Autofix Rubocop Style/TrailingCommaInArguments ( #23694 )
2 years ago
Nick Schonning
793f8c7dd5
Autofix Rubocop Style/IfUnlessModifier ( #23697 )
2 years ago
Nick Schonning
b7d4391c4d
Autofix Rubocop Lint/AmbiguousOperatorPrecedence ( #23681 )
2 years ago
Claire
0ae0740826
Add API parameter to safeguard unexpect mentions in new posts ( #18350 )
2 years ago
Claire
1c08aef482
Remove posts count and last posts from ActivityPub representation of hashtag collections ( #23460 )
2 years ago
Nick Schonning
e0a02f8696
Apply Rubocop Style/NegatedIfElseCondition ( #23451 )
2 years ago
Nick Schonning
e276e530ea
Apply Rubocop Performance/RedundantSplitRegexpArgument ( #23443 )
...
* Apply Rubocop Performance/RedundantSplitRegexpArgument
* Update app/controllers/concerns/signature_verification.rb
2 years ago
Claire
3536a88bc9
Change `POST /settings/applications/:id` to regenerate token on scopes change ( #23359 )
...
Fixes #23096
2 years ago
Eugen Rochko
99787fa30d
Change notifications per page from 15 to 40 in REST API ( #23348 )
2 years ago
Claire
b131e01db7
Add more specific error messages to HTTP signature verification ( #21617 )
...
* Return specific error on failure to parse Date header
* Add error message when preferredUsername is not set
* Change error report to be JSON and include more details
* Change error report to differentiate unknown account and failed refresh
* Add tests
2 years ago
Claire
592fe1a3bd
Add confirmation screen when handling reports ( #22375 )
...
* Add confirmation screen on moderation actions
* Add flash notice when a report has been processed
* Refactor tests
* Add tests
2 years ago
Claire
42aa864c84
Add support for editing media description and focus point of already-posted statuses ( #20878 )
...
* Add backend support for editing media attachments of existing posts
* Allow editing media attachments of already-posted toots
* Add tests
2 years ago
Claire
0ad00e71c5
Fix /api/v1/admin/trends/tags using wrong serializer ( #18943 )
...
* Fix /api/v1/admin/trends/tags using wrong serializer
Fix regression from #18641
* Only use `REST::Admin::TagSerializer` when the user can `manage_taxonomies`
* Fix admin trending hashtag component to not link if `id` is unknown
2 years ago
Claire
0687eb20da
Change domain block CSV parsing to be more robust and handle more lists ( #21470 )
...
* Change domain block CSV parsing to be more robust and handle more lists
* Add some tests
* Improve domain block import validation and reporting
2 years ago
Carl Schwan
27751cd101
Allow changing hide_collections setting with the api ( #22790 )
...
* Allow changing hide_collections setting with the api
This is currently only possible with app/controllers/settings/profiles_controller.rb
and is the only difference in the allowed parameter between the two controllers
* Fix the lint issue
* Use normal indent
2 years ago
Claire
99ecd6a106
Change referrer-policy to no-referrer application-wide ( #23014 )
2 years ago
Claire
c78d61f21a
Add dropdown menu item to open admin interface for remote domains ( #21895 )
...
* Allow /admin/instances/:domain to handle IDNs
* Add dropdown menu item to open admin interface for remote domains
2 years ago
Claire
81ae025687
Fix PermalinkRedirector not applying to users with moved accounts ( #22497 )
...
Fixes #22262
2 years ago
Claire
94d294202b
Fix changing domain block severity not undoing individual account effects ( #22135 )
...
* Fix changing domain block severity not undoing individual account effects
Fixes #22133
* Add tests
2 years ago
David Vega
4c10de8ae3
Fix single name variables on controller folder ( #20092 )
...
Co-authored-by: petrokoriakin1 <116151189+petrokoriakin1@users.noreply.github.com>
Co-authored-by: petrokoriakin1 <116151189+petrokoriakin1@users.noreply.github.com>
Co-authored-by: Effy Elden <effy@effy.space>
2 years ago
Claire
01f0da2a4f
Change CSP directives on API to be tight and concise ( #20960 )
2 years ago
nametoolong
93ad2aba5e
Fix N+1 queries from in NotificationsController ( #21202 )
...
Co-authored-by: Nonexistent <nx@example.org>
2 years ago
Effy Elden
c7d4d21d99
Allow adding relays while secure mode & limited federation mode are enabled ( #22324 )
2 years ago
Francis Murillo
3a11a90dd3
Revoke all authorized applications on password reset ( #21325 )
...
* Clear sessions on password change
* Rename User::clear_sessions to revoke_access for a clearer meaning
* Add reset paassword controller test
* Use User.find instead of User.find_for_authentication for reset password test
* Use redirect and render for better test meaning in reset password
Co-authored-by: Effy Elden <effy@effy.space>
2 years ago
Francis Murillo
5ad9fea52a
Log admin approve and reject account ( #22088 )
...
* Log admin approve and reject account
* Add unit tests for approve and reject logging
2 years ago
Claire
b97260426b
Fix irreversible and whole_word parameters handling in /api/v1/filters ( #21988 )
...
Fixes #21965
2 years ago
Claire
1bef772764
Fix some performance issues with /admin/instances ( #21907 )
...
/admin/instances?availability=failing remains wholly unefficient
2 years ago
Claire
655ad99a37
Fix not being able to follow more than one hashtag ( #21285 )
...
Fixes regression from #20860
2 years ago
Claire
3b81318a0f
Fix form-action CSP directive for external login ( #20962 )
2 years ago
Claire
aa37dc6aae
Fix OAuth flow being broken by recent CSP change ( #20958 )
2 years ago
lenore gilbert
498e9478c7
Support for import/export of instance-level domain blocks/allows for 4.x w/ additional fixes ( #20597 )
...
* Allow import/export of instance-level domain blocks/allows (#1754 )
* Allow import/export of instance-level domain blocks/allows.
Fixes #15095
* Pacify circleci
* Address simple code review feedback
* Add headers to exported CSV
* Extract common import/export functionality to
AdminExportControllerConcern
* Add additional fields to instance-blocked domain export
* Address review feedback
* Split instance domain block/allow import/export into separate pages/controllers
* Address code review feedback
* Pacify DeepSource
* Work around Paperclip::HasAttachmentFile for Rails 6
* Fix deprecated API warning in export tests
* Remove after_commit workaround
(cherry picked from commit b8319d0578
)
* Add confirmation page when importing blocked domains (#1773 )
* Move glitch-soc-specific strings to glitch-soc-specific locale files
* Add confirmation page when importing blocked domains
(cherry picked from commit 73a2e3326f
)
* Fix authorization check in domain blocks controller
(cherry picked from commit 655bac2c3a
)
* Fix error strings for domain blocks and email-domain blocks
Corrected issue with non-error message used for Mastodon:NotPermittedError in Domain Blocks
Corrected issue Domain Blocks using the Email Domain Blocks message on ActionContoller::ParameterMissing
Corrected issue with Email Domain Blocks using the not_permitted string from "custom emojii's"
* Ran i18n-tasks normalize to address test failure
* Removed unused admin.export_domain_blocks.not_permitted string
Removing unused string as indicated by Check i18n
* Fix tests
(cherry picked from commit 1ba41b34c1
)
* Fix domain block export not exporting blocks with only media rejection
(cherry picked from commit 1686374b2f
)
* Fix various issues with domain block import
- stop using Paperclip for processing domain allow/block imports
- stop leaving temporary files
- better error handling
- assume CSV files are UTF-8-encoded
(cherry picked from commit cad824d8f501b95377e4f0a957e5a00d517a1902)
Co-authored-by: Levi Bard <taktaktaktaktaktaktaktaktaktak@gmail.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Claire
4abfb043f2
Fix invalid/empty RSS feed link on account pages ( #20772 )
...
Fixes #20770
2 years ago
trwnh
699bec589f
Make tag following idempotent ( #20860 )
2 years ago
Claire
c7accdb6ac
Change automatic post deletion configuration to be accessible to redirected users ( #20774 )
...
Fixes #20550
2 years ago
trwnh
9b83c67aa7
Fix pagination of followed tags ( #20861 )
...
* Fix missing pagination headers on followed tags
* Fix typo
2 years ago
Daniel Axtens
e61dc520ae
Add 'private' to Cache-Control, match Rails expectations ( #20608 )
...
Several controlers set quite intricate Cache-Control headers in order to
hopefully not be cached by any intermediate proxies or local caches. Unfortunately,
these headers are processed by ActionDispatch::HTTP::Cache in a way that squashes
and discards any values set alongside no-store other than private:
8015c2c2cf/actionpack/lib/action_dispatch/http/cache.rb (L207-L209)
We want to preserve no-store on these responses, but we might as well remove
parts that are going to be dropped anyway. As many of the endpoints in these
controllers are private to a particular user, we should also add "private",
which will be preserved alongside no-store.
2 years ago
trwnh
72d3607229
Move V2 Filter methods under /api/v2 prefix ( #20622 )
...
* Move V2 Filter methods under /api/v2 prefix
* move over the tests too
2 years ago
Eugen Rochko
8b98bebc17
Fix error when passing unknown filter param in REST API ( #20626 )
...
Fix #19156
2 years ago
Eugen Rochko
3cc5ed3bae
Fix `role_ids` not accepting arrays in admin API ( #20625 )
...
Fix #19157
2 years ago
Claire
2fe47bc7db
Remove dead code and refactor status threading code ( #20357 )
...
* Remove dead code
* Remove unneeded/broken parameters and refactor descendant computation
2 years ago
Claire
ee5a39a507
Change logged out /api/v1/statuses/:id/context logged out limits ( #20355 )
2 years ago
James Tucker
c4ff2640c1
Improve performance by avoiding regex construction ( #20215 )
...
```ruby
10.times { p /#{FOO}/.object_id }
10.times { p FOO_RE.object_id }
```
2 years ago
Eugen Rochko
17881148e4
Revert filtering public timelines by locale by default ( #20294 )
2 years ago
trwnh
9d3cf4d9d4
Make account endorsements idempotent ( fix #19045 ) ( #20118 )
...
* Make account endorsements idempotent (fix #19045 )
* Accept suggestion to use exists? instead of find_by + nil check
Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>
* fix logic (unless, not if)
* switch to using `find_or_create_by!`
Co-authored-by: Yamagishi Kazutoshi <ykzts@desire.sh>
2 years ago
trwnh
9596a1374d
Fix uncaught 500 error on invalid `replies_policy` ( Fix #19097 ) ( #20126 )
2 years ago
Claire
811f8d2175
Fix crash when external auth provider has no display_name set ( #19962 )
...
Fixes #19913
2 years ago