Daniel M Brasil
6fb4a756ff
Migrate to request specs in `/api/v1/statuses/:status_id/bookmark` ( #25624 )
1 year ago
Daniel M Brasil
4859958a0c
Migrate to request specs in `/api/v1/polls` ( #25596 )
1 year ago
Daniel M Brasil
1aea938d3d
Migrate to request specs in `/api/v1/statuses/:status_id/pin` ( #25635 )
1 year ago
Daniel M Brasil
6cdc8408a9
Migrate to request specs in `/api/v1/emails/confirmations` ( #25686 )
1 year ago
Daniel M Brasil
8a1aabaac1
Migrate to request specs in `/api/v1/timelines/home` ( #25743 )
1 year ago
Claire
41f65edb21
Fix embed dropdown menu item for unauthenticated users ( #25964 )
1 year ago
Matt Jankowski
6c5a2233a8
Fix `RSpec/StubbedMock` cop ( #25552 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski
658742b3cd
Fix `Lint/AmbiguousBlockAssociation` cop ( #25921 )
1 year ago
Matt Jankowski
c75df62ccc
Fix `RSpec/SubjectDeclaration` cop ( #25312 )
1 year ago
Matt Jankowski
cf33028f35
Admin mailer parameterization ( #25759 )
1 year ago
Daniel M Brasil
383c00819c
Fix `/api/v2/search` not working with following query param ( #25681 )
1 year ago
Daniel M Brasil
4fe2d7cb59
Fix HTTP 500 in `/api/v1/emails/check_confirmation` ( #25595 )
1 year ago
Matt Jankowski
683ba5ecb1
Fix rails `rewhere` deprecation warning in directories api controller ( #25625 )
1 year ago
Claire
a5b6f6da80
Change /api/v1/statuses/:id/history to always return at least one item ( #25510 )
1 year ago
Matt Jankowski
05f9e39b32
Fix `RSpec/VerifiedDoubles` cop ( #25469 )
1 year ago
Matt Jankowski
38433ccd0b
Reduce `Admin::Reports::Actions` spec db activity ( #25465 )
1 year ago
Claire
602c458ab6
Add finer permission requirements for managing webhooks ( #25463 )
1 year ago
Matt Jankowski
63d15d5330
Speed-up on `StatusesController` spec ( #25549 )
1 year ago
Daniel M Brasil
6ac271c2a0
Migrate to request specs in `/api/v1/suggestions` ( #25540 )
1 year ago
Claire
ebfeaebedb
Fix /api/v1/conversations sometimes returning empty accounts ( #25499 )
1 year ago
Daniel M Brasil
e53eb38a8d
Migrate to request specs in `/api/v1/admin/account_actions` ( #25514 )
1 year ago
Claire
fd23f50243
Fix wrong view being displayed when a webhook fails validation ( #25464 )
1 year ago
Matt Jankowski
e835198b26
Combine assertions in api/v1/notifications spec ( #25486 )
1 year ago
Daniel M Brasil
b9bc9d0bda
Fix incorrect pagination headers in `/api/v2/admin/accounts` ( #25477 )
1 year ago
Daniel M Brasil
0a0a1f1495
Migrate to request specs in `/api/v1/tags` ( #25439 )
1 year ago
Daniel M Brasil
b10c05e702
Migrate to request specs in `/api/v1/lists` ( #25443 )
1 year ago
Matt Jankowski
4c5aa0e470
Update rubocop-rspec to version 2.22.0, fix `RSpec/IndexedLet` cop ( #24698 )
1 year ago
Daniel M Brasil
24015ef0cc
Migrate to request specs in `/api/v1/domain_blocks` ( #25414 )
1 year ago
Daniel M Brasil
87aff5aad8
Migrate to request specs in `/api/v1/follow_requests` ( #25411 )
1 year ago
Daniel M Brasil
a5b62e56d0
Migrate to request specs in `/api/v1/apps/verify_credentials` ( #25404 )
1 year ago
Daniel M Brasil
a6407aa662
Migrate to request specs in `/api/v1/apps` ( #25401 )
1 year ago
Matt Jankowski
4c5f62de99
Extract shared examples from api specs ( #25387 )
1 year ago
Claire
ec59166844
Fix ArgumentError when loading newer Private Mentions ( #25399 )
1 year ago
Matt Jankowski
62c996b52d
Reduce `RSpec/MultipleExpectations` cop max to 8 ( #25313 )
1 year ago
fusagiko / takayamaki
b19a695608
migrate test for `GET /api/v1/accounts/{account_id}` to request spec ( #25322 )
1 year ago
Daniel M Brasil
99216e34e5
Migrate to request specs in `/api/v1/admin/canonical_email_blocks` ( #25330 )
1 year ago
Daniel M Brasil
b4e19f9610
Migrate to request specs in `/api/v1/admin/ip_blocks` ( #25331 )
1 year ago
Daniel M Brasil
4301d8cbb3
Migrate to request specs in `/api/v1/admin/domain_allows` ( #25333 )
1 year ago
Daniel M Brasil
841c220c40
Migrate to request specs in `/api/v1/admin/domain_blocks` ( #25335 )
1 year ago
Daniel M Brasil
0e200d4e2f
Migrate to request specs in `/api/v1/admin/reports` ( #25355 )
1 year ago
Daniel M Brasil
4aff1d2974
Migrate to request specs in `/api/v1/admin/email_domain_blocks` ( #25337 )
1 year ago
Matt Jankowski
6c0e3f490a
Fix RSpec/MissingExampleGroupArgument cop ( #25310 )
1 year ago
Matt Jankowski
c42591356d
Fix `RSpec/DescribedClass` cop ( #25104 )
1 year ago
Matt Jankowski
1e243e2df7
Misc spec coverage for `Admin::` area controllers ( #25282 )
1 year ago
Claire
e9385e93e9
Add a confirmation screen when suspending a domain ( #25144 )
1 year ago
Christian Schmidt
69057467cb
Translate CW, poll options and media descriptions ( #24175 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
1 year ago
Matt Jankowski
8b1bfaed3e
Add specs for admin/webhooks CRUD actions ( #25133 )
1 year ago
Matt Jankowski
665bb237a8
Increase spec coverage for controllers - admin/ip_blocks, admin/relays, admin/rules ( #25192 )
1 year ago
Matt Jankowski
0f2c16ac4b
Fix RSpec/NoExpectationExample cop ( #25103 )
1 year ago
Matt Jankowski
d2e5430d4a
Fix RSpec/ExpectChange cop ( #25101 )
2 years ago
Matt Jankowski
b896b16cb3
Fix RSpec/PredicateMatcher cop ( #25102 )
2 years ago
Matt Jankowski
778e4a7bf7
Fix RSpec/ExpectInHook cop ( #25100 )
2 years ago
Matt Jankowski
2877c80dbc
Add specs for admin/announcements CRUD actions ( #25077 )
2 years ago
Daniel M Brasil
b473df9a14
Improve test coverage for `/api/v1/featured_tags` ( #25076 )
2 years ago
Daniel M Brasil
4a22e72b9b
Improve test coverage for `/api/v1/admin/canonical_email_blocks` ( #24985 )
2 years ago
Daniel M Brasil
ce8b5899ae
Fix POST `/api/v1/admin/domain_allows` returning 200 when no domain is specified ( #24958 )
2 years ago
Matt Jankowski
e328ab7e5a
Implement pending specs for StatusesController ( #23969 )
2 years ago
Daniel M Brasil
f3feb4c891
Improve test coverage for `/api/v1/admin/email_domain_blocks` ( #25017 )
2 years ago
Daniel M Brasil
d51464283c
Improve test coverage for `/api/v1/admin/ip_blocks_controller` ( #25031 )
2 years ago
Nick Schonning
99e2e9b81f
Fix minor typos in comments and spec names ( #21831 )
2 years ago
Claire
e60414792d
Add polling and automatic redirection to `/start` on email confirmation ( #25013 )
2 years ago
Matt Jankowski
604e1c2b11
Remove usage of random sample values in specs ( #24869 )
2 years ago
Daniel M Brasil
433ab0c9a3
Fix uncaught NoMethodError error in `/api/v1/admin/canonical_email_blocks/test` ( #24947 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Matt Jankowski
2c2d924942
Fix RSpec/RepeatedExampleGroupDescription cop ( #24850 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Matt Jankowski
a610a02d4f
Fix RSpec/ScatteredSetup cop ( #24848 )
2 years ago
Nick Schonning
da3bd913ae
Autofix Rubocop Style/HashSyntax ( #23754 )
2 years ago
Matt Jankowski
c97b611b6b
Fix RSpec/InferredSpecType cop ( #24736 )
2 years ago
Matt Jankowski
710745e16b
Fix RSpec/ContextWording cop ( #24739 )
2 years ago
Matt Jankowski
cf18cc2891
Fix RSpec/MultipleSubjects cop ( #24738 )
2 years ago
Matt Jankowski
08fb9d300a
Spec coverage for settings/preferences/* controllers ( #24825 )
2 years ago
Matt Jankowski
3df665fd23
Fix Lint/ConstantDefinitionInBlock cop ( #24763 )
2 years ago
Matt Jankowski
05e3abe9d9
Fix Lint/EmptyClass cop ( #24795 )
2 years ago
Matt Jankowski
570079f8ce
Fix Performance/TimesMap cop ( #24789 )
2 years ago
Claire
9189e90ff2
Add fallback redirection when getting a webfinger query `LOCAL_DOMAIN@LOCAL_DOMAIN` ( #23600 )
...
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
2 years ago
Claire
6693a4fe7c
Change lists to be able to include accounts with pending follow requests ( #19727 )
2 years ago
Claire
32a030dd74
Rewrite import feature ( #21054 )
2 years ago
Matt Jankowski
d00e45a7d3
Fix Rails/I18nLocaleAssignment cop ( #24693 )
2 years ago
Nick Schonning
a3393d0d07
Autofix Rubocop RSpec/MatchArray ( #24050 )
2 years ago
Nick Schonning
90beba57d8
Autofix Rubocop Rails/ResponseParsedBody ( #24051 )
2 years ago
Claire
276c39361b
Fix anonymous visitors getting a session cookie on first visit ( #24584 )
2 years ago
Matt Jankowski
0a5f0a8b20
Remove instance variables from helper usage ( #24203 )
2 years ago
Claire
58a1b2e330
Fix caching logic with regards to Accept-Language, Cookie, and Signature ( #24604 )
2 years ago
Eugen Rochko
e98c86050a
Refactor `Cache-Control` and `Vary` definitions ( #24347 )
2 years ago
Robert R George
4db8230194
Add trend management to admin API ( #24257 )
2 years ago
Matt Jankowski
36eeb70d53
Spec coverage on Settings/ controllers specs ( #24221 )
2 years ago
Eugen Rochko
a9b5598c97
Change user settings to be stored in a more optimal way ( #23630 )
...
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
Eugen Rochko
9bda933740
Change media upload limits and remove client-side resizing ( #23726 )
2 years ago
Christian Schmidt
bd047acc35
Replace `Status#translatable?` with language matrix in separate endpoint ( #24037 )
2 years ago
Claire
a232a1feb8
Fix misleading error code when receiving invalid WebAuthn credentials ( #23568 )
2 years ago
Matt Jankowski
688287c59d
Coverage improvement round-out following up previous work ( #23987 )
2 years ago
Matt Jankowski
c599e289d8
Fix spec for api/v1/statuses/translations ( #23956 )
2 years ago
Matt Jankowski
42ddc45133
Admin controllers specs ( #23917 )
2 years ago
Matt Jankowski
ad585fb195
Specs api v1 controllers ( #23930 )
2 years ago
Matt Jankowski
6a57c42316
Settings controllers specs ( #23915 )
2 years ago
Claire
3f52e717fa
Add tests for moderation actions without custom text ( #23184 )
2 years ago
Claire
c2a046ded1
Fix “Remove all followers from the selected domains” being more destructive than it claims ( #23805 )
2 years ago
Nick Schonning
6bd7003799
Fix mispelled spec filenames ( #23834 )
2 years ago
Nick Schonning
84cc805cae
Enable Style/FrozenStringLiteralComment for specs ( #23790 )
2 years ago
Nick Schonning
0cfdd1a401
Enable Rubocop Style/StringConcatenation defaults ( #23792 )
2 years ago
Nick Schonning
35d032500b
Autofix Rubocop Security/IoMethods ( #23757 )
2 years ago
Nick Schonning
717683d1c3
Autofix Rubocop remaining Layout rules ( #23679 )
2 years ago
Nick Schonning
5116347eb7
Autofix Rubocop RSpec/BeEq ( #23740 )
2 years ago
Nick Schonning
bf785df9fe
Audofix Rubocop Style/WordArray ( #23739 )
2 years ago
Nick Schonning
4552685f6b
Autofix Rubocop RSpec/LeadingSubject ( #23670 )
2 years ago
Nick Schonning
4ea1e0fceb
Enable Rubocop RSpec/ExpectActual ( #23720 )
2 years ago
Nick Schonning
38a1d8bb85
Autofix Rubocop RSpec/ImplicitSubject ( #23721 )
2 years ago
Nick Schonning
5179c47087
Autofix Rubocops RSpec/ScatteredLet ( #23725 )
2 years ago
Nick Schonning
aef0051fd0
Enable Rubocop HTTP status rules ( #23717 )
2 years ago
Nick Schonning
bd1d57c230
Autofix Rubocop RSpec/EmptyLineAfterSubject ( #23719 )
2 years ago
Nick Schonning
65ba0d92ef
Enable Rubocop RSpec/NotToNot ( #23723 )
2 years ago
Nick Schonning
a2fdb388eb
Autofix Rubocop RSpec/ReturnFromStub ( #23724 )
2 years ago
Nick Schonning
21bf326356
Autofix Rubocop Rails/Pluck ( #23730 )
2 years ago
Nick Schonning
81ad6c2e39
Autofix Rubocop Style/StringLiterals ( #23695 )
2 years ago
Nick Schonning
3680e032b4
Autofix Rubocop RSpec/EmptyLineAfterFinalLet ( #23707 )
2 years ago
Nick Schonning
167709f6b0
Autofix Rubocop Style/BlockDelimiters ( #23706 )
2 years ago
Nick Schonning
5069769cbe
Autofix Rubocop Style/TrailingCommaInHashLiteral ( #23693 )
2 years ago
Nick Schonning
b4cbfff3eb
Autofix Rubocop RSpec/ExcessiveDocstringSpacing ( #23666 )
2 years ago
Nick Schonning
a7db0b41cd
Autofix Rubocop Lint/ParenthesesAsGroupedExpression ( #23682 )
2 years ago
Nick Schonning
c0a645f647
Autofix Rubocop RSpec/ExampleWording ( #23667 )
2 years ago
Nick Schonning
634368c491
Autofix Rubocop Lint/SymbolConversion ( #23683 )
2 years ago
Nick Schonning
6d42820e5d
Autofix Rubocop Lint/AmbiguousOperator ( #23680 )
2 years ago
Nick Schonning
ac59d6f19f
Enable Rubocop Style/NumericLiterals ( #23647 )
2 years ago
Nick Schonning
669f6d2c0a
Run rubocop formatting except line length ( #23632 )
2 years ago
Nick Schonning
68b1071f86
Autofix Rubocop RSpec/BeNil ( #23653 )
2 years ago
Claire
d6930b3847
Add API parameter to safeguard unexpect mentions in new posts ( #18350 )
2 years ago
Varun Sharma
45e2936c89
Add tests to indicate inclusion of self replies in statuses endpoint ( #23266 )
2 years ago
Claire
20a479ff7c
Change `POST /settings/applications/:id` to regenerate token on scopes change ( #23359 )
...
Fixes #23096
2 years ago
Claire
448be26b34
Add missing `policy` attribute to `WebPushSubscriptionSerializer` ( #23210 )
...
* Add missing `policy` attribute to `WebPushSubscriptionSerializer`
Fixes #23145
* Add tests
2 years ago
Claire
68dcbcb7bf
Add more specific error messages to HTTP signature verification ( #21617 )
...
* Return specific error on failure to parse Date header
* Add error message when preferredUsername is not set
* Change error report to be JSON and include more details
* Change error report to differentiate unknown account and failed refresh
* Add tests
2 years ago
Claire
343e1fe8e9
Add confirmation screen when handling reports ( #22375 )
...
* Add confirmation screen on moderation actions
* Add flash notice when a report has been processed
* Refactor tests
* Add tests
2 years ago
Claire
fcc4c9b34a
Change domain block CSV parsing to be more robust and handle more lists ( #21470 )
...
* Change domain block CSV parsing to be more robust and handle more lists
* Add some tests
* Improve domain block import validation and reporting
2 years ago
Claire
21a1a8ee88
Fix crash when marking statuses as sensitive while some statuses are deleted ( #22134 )
...
* Do not offer to mark statuses as sensitive if there is no undeleted status with media attachments
* Fix crash when marking statuses as sensitive while some statuses are deleted
Fixes #21910
* Fix multiple strikes being created for a single report when selecting “Mark as sensitive”
* Add tests
2 years ago
Claire
8556a649d5
Fix changing domain block severity not undoing individual account effects ( #22135 )
...
* Fix changing domain block severity not undoing individual account effects
Fixes #22133
* Add tests
2 years ago
Francis Murillo
5fb1c3e934
Revoke all authorized applications on password reset ( #21325 )
...
* Clear sessions on password change
* Rename User::clear_sessions to revoke_access for a clearer meaning
* Add reset paassword controller test
* Use User.find instead of User.find_for_authentication for reset password test
* Use redirect and render for better test meaning in reset password
Co-authored-by: Effy Elden <effy@effy.space>
2 years ago
Meisam
6cdbc345f4
Validate nodeinfo response by schema ( #21395 )
...
* add json-schema to :test in Gemfile
* Create node_info_2.0_schema.json
* test match_response_schema
* Create match_response_schema.rb
* Update nodeinfo_controller_spec.rb
* Rename spec/support/node_info_2.0_schema.json to spec/support/schema/node_info_2.0_schema.json
* Update match_response_schema.rb
* cleanup
* additionally validate the json schema itself
disable throwing errors
test the schema matcher
* rename nodeinfo schema to nodeinfo_2.0
* use Rails.root.join to construct the path
* prettify json
* sync Gemfile.lock
2 years ago
Francis Murillo
f6492a7c4d
Log admin approve and reject account ( #22088 )
...
* Log admin approve and reject account
* Add unit tests for approve and reject logging
2 years ago
Claire
69137f4a90
Fix irreversible and whole_word parameters handling in /api/v1/filters ( #21988 )
...
Fixes #21965
2 years ago
Claire
51a33ce77a
Fix not being able to follow more than one hashtag ( #21285 )
...
Fixes regression from #20860
2 years ago
Rose
4f15fd0ba1
Fix style for hashes ( #20518 )
...
* Fix style for hashes
Make the style for hashes consistent.
* New style
More consistency
2 years ago
lenore gilbert
c373148b3d
Support for import/export of instance-level domain blocks/allows for 4.x w/ additional fixes ( #20597 )
...
* Allow import/export of instance-level domain blocks/allows (#1754 )
* Allow import/export of instance-level domain blocks/allows.
Fixes #15095
* Pacify circleci
* Address simple code review feedback
* Add headers to exported CSV
* Extract common import/export functionality to
AdminExportControllerConcern
* Add additional fields to instance-blocked domain export
* Address review feedback
* Split instance domain block/allow import/export into separate pages/controllers
* Address code review feedback
* Pacify DeepSource
* Work around Paperclip::HasAttachmentFile for Rails 6
* Fix deprecated API warning in export tests
* Remove after_commit workaround
(cherry picked from commit 94e98864e3
)
* Add confirmation page when importing blocked domains (#1773 )
* Move glitch-soc-specific strings to glitch-soc-specific locale files
* Add confirmation page when importing blocked domains
(cherry picked from commit b91196f4b7
)
* Fix authorization check in domain blocks controller
(cherry picked from commit 7527937758
)
* Fix error strings for domain blocks and email-domain blocks
Corrected issue with non-error message used for Mastodon:NotPermittedError in Domain Blocks
Corrected issue Domain Blocks using the Email Domain Blocks message on ActionContoller::ParameterMissing
Corrected issue with Email Domain Blocks using the not_permitted string from "custom emojii's"
* Ran i18n-tasks normalize to address test failure
* Removed unused admin.export_domain_blocks.not_permitted string
Removing unused string as indicated by Check i18n
* Fix tests
(cherry picked from commit 9094c2f52c
)
* Fix domain block export not exporting blocks with only media rejection
(cherry picked from commit 26ff48ee48
)
* Fix various issues with domain block import
- stop using Paperclip for processing domain allow/block imports
- stop leaving temporary files
- better error handling
- assume CSV files are UTF-8-encoded
(cherry picked from commit cad824d8f501b95377e4f0a957e5a00d517a1902)
Co-authored-by: Levi Bard <taktaktaktaktaktaktaktaktaktak@gmail.com>
Co-authored-by: Claire <claire.github-309c@sitedethib.com>
2 years ago
trwnh
b59ce0a60f
Move V2 Filter methods under /api/v2 prefix ( #20622 )
...
* Move V2 Filter methods under /api/v2 prefix
* move over the tests too
2 years ago
Eugen Rochko
552d69ad96
Fix error when invalid domain name is submitted ( #19474 )
...
Fix #19175
2 years ago
Claire
1dca08b76f
Fix admin action logs page ( #19649 )
...
* Add tests
* Fix crash when trying to display orphaned action logs
* Add migration for older admin action logs
2 years ago
Eugen Rochko
40c7f3e830
Fix account action type validation ( #19476 )
...
* Fix account action type validation
Fix #19143
* Fix #19145
* Fix code style issues
2 years ago
Eugen Rochko
1ae508bf2f
Change unauthenticated search to not support pagination in REST API ( #19326 )
...
- Only exact search matches for queries with < 5 characters
- Do not support queries with `offset` (pagination)
- Return HTTP 401 on truthy `resolve` instead of overriding to false
2 years ago
Eugen Rochko
7c152acb2c
Change settings area to be separated into categories in admin UI ( #19407 )
...
And update all descriptions
2 years ago
Eugen Rochko
839f893168
Change public accounts pages to mount the web UI ( #19319 )
...
* Change public accounts pages to mount the web UI
* Fix handling of remote usernames in routes
- When logged in, serve web app
- When logged out, redirect to permalink
- Fix `app-body` class not being set sometimes due to name conflict
* Fix missing `multiColumn` prop
* Fix failing test
* Use `discoverable` attribute to control indexing directives
* Fix `<ColumnLoading />` not using `multiColumn`
* Add `noindex` to accounts in REST API
* Change noindex directive to not be rendered by default before a route is mounted
* Add loading indicator for detailed status in web UI
* Fix missing indicator appearing while account is loading in web UI
2 years ago
Eugen Rochko
1bd00036c2
Change about page to be mounted in the web UI ( #19345 )
2 years ago
Eugen Rochko
93f340a4bf
Remove setting that disables account deletes ( #17683 )
2 years ago
Eugen Rochko
58d5b28cb0
Remove previous landing page ( #19300 )
2 years ago