6185efbc3c
Admin mailer spec coverage improvement ( #23863 )
2 years ago
9ee83a9f3b
Add policies and serializers groups to simplecov output ( #23897 )
2 years ago
4bb39ac3c3
Fix single-record invalid condition on PollVote ( #23810 )
2 years ago
19614ba247
Rename ActivityPub Serializer Specs ( #23844 )
2 years ago
20b80c62ff
Change auto-deletion throttling constants to better scale with server size ( #23320 )
2 years ago
6bd7003799
Fix mispelled spec filenames ( #23834 )
2 years ago
3ed1b9ebb6
Fix rack:attack flaky tests and test end of throttle period ( #23799 )
2 years ago
8fd3fc404d
Autofix Rubocop Rails/RootPathnameMethods ( #23760 )
2 years ago
84cc805cae
Enable Style/FrozenStringLiteralComment for specs ( #23790 )
2 years ago
0cfdd1a401
Enable Rubocop Style/StringConcatenation defaults ( #23792 )
2 years ago
35d032500b
Autofix Rubocop Security/IoMethods ( #23757 )
2 years ago
2c3c734bcc
Autofix Rubocop Style/SymbolProc ( #23742 )
2 years ago
717683d1c3
Autofix Rubocop remaining Layout rules ( #23679 )
2 years ago
5116347eb7
Autofix Rubocop RSpec/BeEq ( #23740 )
2 years ago
bf785df9fe
Audofix Rubocop Style/WordArray ( #23739 )
2 years ago
4552685f6b
Autofix Rubocop RSpec/LeadingSubject ( #23670 )
2 years ago
4ea1e0fceb
Enable Rubocop RSpec/ExpectActual ( #23720 )
2 years ago
38a1d8bb85
Autofix Rubocop RSpec/ImplicitSubject ( #23721 )
2 years ago
5179c47087
Autofix Rubocops RSpec/ScatteredLet ( #23725 )
2 years ago
aef0051fd0
Enable Rubocop HTTP status rules ( #23717 )
2 years ago
bd1d57c230
Autofix Rubocop RSpec/EmptyLineAfterSubject ( #23719 )
2 years ago
dbc6d7b276
Autofix Rubocop Lint/UnusedBlockArgument ( #23712 )
2 years ago
65ba0d92ef
Enable Rubocop RSpec/NotToNot ( #23723 )
2 years ago
a2fdb388eb
Autofix Rubocop RSpec/ReturnFromStub ( #23724 )
2 years ago
21bf326356
Autofix Rubocop Rails/Pluck ( #23730 )
2 years ago
e0e63b73ee
Autofix Rubocop RSpec/EmptyLineAfterHook ( #23718 )
2 years ago
81ad6c2e39
Autofix Rubocop Style/StringLiterals ( #23695 )
2 years ago
ac3561098e
Autofix Rubocop RSpec/LetBeforeExamples ( #23671 )
2 years ago
1a02101100
Autofix Rubocop Style/EmptyLambdaParameter ( #23705 )
2 years ago
3680e032b4
Autofix Rubocop RSpec/EmptyLineAfterFinalLet ( #23707 )
2 years ago
167709f6b0
Autofix Rubocop Style/BlockDelimiters ( #23706 )
2 years ago
c0d7c855b3
Autofix Rubocop RSpec/Capybara/FeatureMethods ( #23708 )
2 years ago
08289a38fa
Autofix Rubocop Style/TrailingCommaInArrayLiteral ( #23692 )
2 years ago
5069769cbe
Autofix Rubocop Style/TrailingCommaInHashLiteral ( #23693 )
2 years ago
b4cbfff3eb
Autofix Rubocop RSpec/ExcessiveDocstringSpacing ( #23666 )
2 years ago
c38bd17657
Autofix Rubocop Style/TrailingCommaInArguments ( #23694 )
2 years ago
e2a3ebb271
Autofix Rubocop Style/IfUnlessModifier ( #23697 )
2 years ago
d65b2c1924
Apply Rubocop Style/RedundantConstantBase ( #23463 )
2 years ago
a7db0b41cd
Autofix Rubocop Lint/ParenthesesAsGroupedExpression ( #23682 )
2 years ago
e5cf23cf3a
Enable Rubocop RSpec/HooksBeforeExamples ( #23668 )
2 years ago
efd424506a
Autofix Rubocop Style/RedundantPercentQ ( #23651 )
2 years ago
c0a645f647
Autofix Rubocop RSpec/ExampleWording ( #23667 )
2 years ago
7a3d4c3d4b
Enable Rubocop RSpec/MultipleDescribes ( #23672 )
2 years ago
54318dcd6d
Autofix Rubocop RSpec/ClassCheck ( #23685 )
2 years ago
634368c491
Autofix Rubocop Lint/SymbolConversion ( #23683 )
2 years ago
6d42820e5d
Autofix Rubocop Lint/AmbiguousOperator ( #23680 )
2 years ago
ac59d6f19f
Enable Rubocop Style/NumericLiterals ( #23647 )
2 years ago
669f6d2c0a
Run rubocop formatting except line length ( #23632 )
2 years ago
6ed6c41724
Autofix Rubocop RSpec/EmptyLineAfterExample ( #23661 )
2 years ago
68b1071f86
Autofix Rubocop RSpec/BeNil ( #23653 )
2 years ago
936204b9ea
Autofix Rubocop Style/NestedParenthesizedCalls ( #23646 )
2 years ago
37914c8757
Autofix Rubocop Style/MethodCallWithoutArgsParentheses ( #23645 )
2 years ago
66f715550e
Add `memorial` attribute to REST API ( #23591 )
2 years ago
d6930b3847
Add API parameter to safeguard unexpect mentions in new posts ( #18350 )
2 years ago
45e2936c89
Add tests to indicate inclusion of self replies in statuses endpoint ( #23266 )
2 years ago
c55568c75a
Add tests for `REST::AccountSerializer` ( #23319 )
2 years ago
0c9eac80d8
Fix unbounded recursion in post discovery ( #23506 )
...
* Add a limit to how many posts can get fetched as a result of a single request
* Add tests
* Always pass `request_id` when processing `Announce` activities
---------
Co-authored-by: nametoolong <nametoolong@users.noreply.github.com>
2 years ago
0592937264
Apply Rubocop Rails/WhereNot ( #23448 )
...
* Apply Rubocop Rails/WhereNot
* Update spec for where.not
2 years ago
1487fcde93
Apply Rubocop Style/ExpandPathArguments ( #23450 )
2 years ago
ed570050c6
Autofix Rails/EagerEvaluationLogMessage ( #23429 )
...
* Autofix Rails/EagerEvaluationLogMessage
* Update spec for debug block syntax
2 years ago
9edefc779f
Fix `UserCleanupScheduler` crash when an unconfirmed account has a moderation note ( #23318 )
...
* Fix `UserCleanupScheduler` crash when an unconfirmed account has a moderation note
* Add tests
2 years ago
20a479ff7c
Change `POST /settings/applications/:id` to regenerate token on scopes change ( #23359 )
...
Fixes #23096
2 years ago
13a2abacc8
Add `roles` attribute to Account entities in REST API ( #23255 )
2 years ago
a5a00d7f7a
Fix email with empty domain name labels passing validation ( #23246 )
...
* Fix email with empty domain name labels passing validation
`EmailMxValidator` would allow empty labels because `Resolv::DNS` is
particularly lenient about them, but the email would be invalid and
unusable.
* Add tests
2 years ago
6883fddb19
Fix account activation being triggered before email confirmation ( #23245 )
...
* Add tests
* Fix account activation being triggered before email confirmation
Fixes #23098
2 years ago
f2a6e71bb6
Suppress AddressFamilyError in link verification ( #23204 )
...
* Suppress AddressFamilyError
* clarify comment
2 years ago
448be26b34
Add missing `policy` attribute to `WebPushSubscriptionSerializer` ( #23210 )
...
* Add missing `policy` attribute to `WebPushSubscriptionSerializer`
Fixes #23145
* Add tests
2 years ago
68dcbcb7bf
Add more specific error messages to HTTP signature verification ( #21617 )
...
* Return specific error on failure to parse Date header
* Add error message when preferredUsername is not set
* Change error report to be JSON and include more details
* Change error report to differentiate unknown account and failed refresh
* Add tests
2 years ago
343e1fe8e9
Add confirmation screen when handling reports ( #22375 )
...
* Add confirmation screen on moderation actions
* Add flash notice when a report has been processed
* Refactor tests
* Add tests
2 years ago
4b92e59f4f
Add support for editing media description and focus point of already-posted statuses ( #20878 )
...
* Add backend support for editing media attachments of existing posts
* Allow editing media attachments of already-posted toots
* Add tests
2 years ago
fcc4c9b34a
Change domain block CSV parsing to be more robust and handle more lists ( #21470 )
...
* Change domain block CSV parsing to be more robust and handle more lists
* Add some tests
* Improve domain block import validation and reporting
2 years ago
21a1a8ee88
Fix crash when marking statuses as sensitive while some statuses are deleted ( #22134 )
...
* Do not offer to mark statuses as sensitive if there is no undeleted status with media attachments
* Fix crash when marking statuses as sensitive while some statuses are deleted
Fixes #21910
* Fix multiple strikes being created for a single report when selecting “Mark as sensitive”
* Add tests
2 years ago
15b88a83ab
Fix sanitizer parsing link text as HTML when stripping unsupported links ( #22558 )
2 years ago
0c689b9d01
fix: allow verification when page size exceeds 1MB (using HTML5 parser) ( #22879 )
...
* fix: allow verification when page size exceeds 1MB
Truncates the page after 1MB instead
Closes #15316
* switch to HTML5 parser, fix rubocop errors
* undo rubocop fixes
Co-authored-by: Chris Zubak-Skees <chriszs@gmail.com>
2 years ago
18fb01ef7c
Fix possible race conditions when suspending/unsuspending accounts ( #22363 )
...
* Fix possible race conditions when suspending/unsuspending accounts
* Fix tests
Tests were assuming SuspensionWorker and UnsuspensionWorker would do the
suspending/unsuspending themselves, but this has changed.
2 years ago
fdd1facba1
Fix home TL could contain post from who blocked me ( #22849 )
...
* Fix home tl contains post from who blocked me
* Add test
* Fix feed_manager's build_crutches
blocked_by was not includes status' owner
* Add test for status from I blocked
* Fix typo
2 years ago
115ab2869b
Fix ・ detection in hashtag regex to construct hashtag correctly ( #22888 )
...
* Fix ・ detection in hashtag regex to construct hashtag correctly
* Fixed rubocop liniting issues
* More rubocop linting fix
2 years ago
70415714f1
Add follow request banner on account header ( #20785 )
...
* Add requested_by to relationship maps
* Display whether an account has requested to follow you on their profile
2 years ago
8556a649d5
Fix changing domain block severity not undoing individual account effects ( #22135 )
...
* Fix changing domain block severity not undoing individual account effects
Fixes #22133
* Add tests
2 years ago
d412147d02
Save avatar or header correctly even if other one fails ( #18465 )
...
* Save avatar or header correctly if other one fails
* Fix test
2 years ago
1f5740e65c
Use Rails tag API to build RSS feed for spoilers and polls ( #20163 )
...
* Use Rails tag API to build RSS feed for spoilers and polls
While the previous method did not contain a bug or a potential issue,
the tag API can be very resilient against future problems and reduces the
amount of manual management of the escape status of the content.
I've added tests to ensure that the formatting is broken and still
escapes control characters correctly.
* this seems cleaner and passes
* Incorporate feedback by moving the br to its own line and using the tag helper over the string constant for the br tag itself
* whoops, tag helper doesn't use a self-closing tag
2 years ago
baecdf2882
Fix typo in application_helper_spec.rb ( #20981 )
...
enviroment -> environment
2 years ago
5fb1c3e934
Revoke all authorized applications on password reset ( #21325 )
...
* Clear sessions on password change
* Rename User::clear_sessions to revoke_access for a clearer meaning
* Add reset paassword controller test
* Use User.find instead of User.find_for_authentication for reset password test
* Use redirect and render for better test meaning in reset password
Co-authored-by: Effy Elden <effy@effy.space>
2 years ago
6cdbc345f4
Validate nodeinfo response by schema ( #21395 )
...
* add json-schema to :test in Gemfile
* Create node_info_2.0_schema.json
* test match_response_schema
* Create match_response_schema.rb
* Update nodeinfo_controller_spec.rb
* Rename spec/support/node_info_2.0_schema.json to spec/support/schema/node_info_2.0_schema.json
* Update match_response_schema.rb
* cleanup
* additionally validate the json schema itself
disable throwing errors
test the schema matcher
* rename nodeinfo schema to nodeinfo_2.0
* use Rails.root.join to construct the path
* prettify json
* sync Gemfile.lock
2 years ago
b59fb28e90
Fix 500 error when trying to migrate to an invalid address ( #21462 )
...
* Fix 500 error when trying to migrate to an invalid address
* Add tests
2 years ago
f6492a7c4d
Log admin approve and reject account ( #22088 )
...
* Log admin approve and reject account
* Add unit tests for approve and reject logging
2 years ago
c8849d6cee
Fix unbounded recursion in account discovery ( #22025 )
...
* Fix trying to fetch posts from other users when fetching featured posts
* Rate-limit discovery of new subdomains
* Put a limit on recursively discovering new accounts
2 years ago
69137f4a90
Fix irreversible and whole_word parameters handling in /api/v1/filters ( #21988 )
...
Fixes #21965
2 years ago
625216d8e1
Fix attachments of edited statuses not being fetched ( #21565 )
...
* Fix attachments of edited statuses not being fetched
* Fix tests
2 years ago
51a33ce77a
Fix not being able to follow more than one hashtag ( #21285 )
...
Fixes regression from #20860
2 years ago
69378eac99
Don't allow URLs that contain non-normalized paths to be verified ( #20999 )
...
* Don't allow URLs that contain non-normalized paths to be verified
This stops things like https://example.com/otheruser/../realuser where
"/otheruser" appears to be the verified URL, but the actual URL being
verified is "/realuser" due to the "/../".
Also fix a test to use 'https', so it is testing the right thing, now
that since #20304 https is required.
* missing do
2 years ago
4f15fd0ba1
Fix style for hashes ( #20518 )
...
* Fix style for hashes
Make the style for hashes consistent.
* New style
More consistency
2 years ago
c373148b3d
Support for import/export of instance-level domain blocks/allows for 4.x w/ additional fixes ( #20597 )
...
* Allow import/export of instance-level domain blocks/allows (#1754 )
* Allow import/export of instance-level domain blocks/allows.
Fixes #15095
* Pacify circleci
* Address simple code review feedback
* Add headers to exported CSV
* Extract common import/export functionality to
AdminExportControllerConcern
* Add additional fields to instance-blocked domain export
* Address review feedback
* Split instance domain block/allow import/export into separate pages/controllers
* Address code review feedback
* Pacify DeepSource
* Work around Paperclip::HasAttachmentFile for Rails 6
* Fix deprecated API warning in export tests
* Remove after_commit workaround
(cherry picked from commit 94e98864e3#1773 )
* Move glitch-soc-specific strings to glitch-soc-specific locale files
* Add confirmation page when importing blocked domains
(cherry picked from commit b91196f4b775279377589094c2f52c26ff48ee48
2 years ago
daf6f3453e
Handle links with no href in VerifyLinkService ( #20741 )
...
Before this change, the following error would cause VerifyAccountLinksWorker to fail:
NoMethodError: undefined method `downcase' for nil:NilClass
[PROJECT_ROOT]/app/services/verify_link_service.rb:31 :in `block in link_back_present?`
2 years ago
21fd25a269
Fix rate limiting for paths with formats ( #20675 )
2 years ago
b59ce0a60f
Move V2 Filter methods under /api/v2 prefix ( #20622 )
...
* Move V2 Filter methods under /api/v2 prefix
* move over the tests too
2 years ago
552d69ad96
Fix error when invalid domain name is submitted ( #19474 )
...
Fix #19175
2 years ago
b31afc6294
Fix error when passing unknown filter param in REST API ( #20626 )
...
Fix #19156
2 years ago
147d8bd8fc
Support UTF-8 Characters in Domains During CSV Import ( #20592 )
...
* Support UTF-8 Characters in Domains During Import
* Update Changelong
2 years ago
c2231539c7
Test blank account field verifiability ( #20458 )
...
* Test blank account field verifiability
This change tests the need for #20428 , which ensures that we guard against a situation in which `at_xpath` returns `nil`.
* Test verifiability of blank fields for remote account profiles
This adds a counterpart test for remote account profiles' fields' verifiability when those fields are blank. I previously added the same test for local accounts.
2 years ago
Matt Jankowski
Nick Schonning
Claire
Varun Sharma
Markus Unterwaditzer
Markus Unterwaditzer
Jeong Arm
Partho Ghosh
Neil Matatall
Ikko Ashimine
Francis Murillo
Meisam
David Leadbeater
Rose
lenore gilbert
Joshua Wood
Eugen Rochko
trwnh
Hampton Lintorn-Catlin
Emily Strickland