From ebd299413c6132818ad2528df002a8539b0af30b Mon Sep 17 00:00:00 2001 From: kibigo! Date: Mon, 26 Jun 2017 15:22:03 -0700 Subject: [PATCH] Disable links on collapsed toots --- app/javascript/mastodon/components/status.js | 2 +- .../mastodon/components/status_content.js | 15 +++++++++++++-- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/app/javascript/mastodon/components/status.js b/app/javascript/mastodon/components/status.js index 199f1b8aff..cbbd831e72 100644 --- a/app/javascript/mastodon/components/status.js +++ b/app/javascript/mastodon/components/status.js @@ -272,7 +272,7 @@ class StatusUnextended extends ImmutablePureComponent { - + {isCollapsed ? null : media} diff --git a/app/javascript/mastodon/components/status_content.js b/app/javascript/mastodon/components/status_content.js index 9b93961eff..bcbff55154 100644 --- a/app/javascript/mastodon/components/status_content.js +++ b/app/javascript/mastodon/components/status_content.js @@ -16,6 +16,7 @@ export default class StatusContent extends React.PureComponent { static propTypes = { status: ImmutablePropTypes.map.isRequired, expanded: PropTypes.bool, + collapsed: PropTypes.bool, onExpandedToggle: PropTypes.func, onHeightUpdate: PropTypes.func, onClick: PropTypes.func, @@ -40,6 +41,7 @@ export default class StatusContent extends React.PureComponent { } else if (link.textContent[0] === '#' || (link.previousSibling && link.previousSibling.textContent && link.previousSibling.textContent[link.previousSibling.textContent.length - 1] === '#')) { link.addEventListener('click', this.onHashtagClick.bind(this, link.text), false); } else { + link.addEventListener('click', this.onLinkClick.bind(this), false); link.setAttribute('target', '_blank'); link.setAttribute('rel', 'noopener'); link.setAttribute('title', link.href); @@ -53,10 +55,18 @@ export default class StatusContent extends React.PureComponent { } } + onLinkClick = (e) => { + if (e.button === 0 && this.props.collapsed) { + e.preventDefault(); + if (this.props.onClick) this.props.onClick(); + } + } + onMentionClick = (mention, e) => { if (e.button === 0) { e.preventDefault(); - this.context.router.history.push(`/accounts/${mention.get('id')}`); + if (!this.props.collapsed) this.context.router.history.push(`/accounts/${mention.get('id')}`); + else if (this.props.onClick) this.props.onClick(); } } @@ -65,7 +75,8 @@ export default class StatusContent extends React.PureComponent { if (e.button === 0) { e.preventDefault(); - this.context.router.history.push(`/timelines/tag/${hashtag}`); + if (!this.props.collapsed) this.context.router.history.push(`/timelines/tag/${hashtag}`); + else if (this.props.onClick) this.props.onClick(); } }