From e9ebe097ec45a1afb28372dab4fce5d0b252a060 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jo=C3=ABl=20Quenneville?= Date: Fri, 28 Apr 2017 18:21:35 -0400 Subject: [PATCH] Add tests to the Feed model (#2594) This adds a test for the `Feed#get` method. While the data transformations in `Feed#get` may seem redundant, they are important to maintain the order from Redis. The tests I wrote will fail if someone tries to refactor away this "redundancy" (as I tried to do in the first iteration of this change). --- spec/models/feed_spec.rb | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/spec/models/feed_spec.rb b/spec/models/feed_spec.rb index 19ddeef7f1..96c4770731 100644 --- a/spec/models/feed_spec.rb +++ b/spec/models/feed_spec.rb @@ -2,6 +2,20 @@ require 'rails_helper' RSpec.describe Feed, type: :model do describe '#get' do - pending + it "gets statuses with ids in the range, maintining the order from Redis" do + account = Fabricate(:account) + Fabricate(:status, account: account, id: 1) + Fabricate(:status, account: account, id: 2) + Fabricate(:status, account: account, id: 3) + Fabricate(:status, account: account, id: 10) + redis = double(zrevrangebyscore: [["val2", 2.0], ["val1", 1.0], ["val3", 3.0], ["deleted", 4.0]]) + allow(Redis).to receive(:current).and_return(redis) + + feed = Feed.new("type", account) + results = feed.get(3) + + expect(results.map(&:id)).to eq [2, 1, 3] + expect(results.first.attributes.keys).to eq ["id", "updated_at"] + end end end