From d548faf69321260ab4c2a16759ca77773189126a Mon Sep 17 00:00:00 2001
From: Eugen Rochko <eugen@zeonfederated.com>
Date: Tue, 2 May 2023 10:26:39 +0200
Subject: [PATCH] Fix n+1 query in settings migration (#24783)

---
 .../20230215074423_move_user_settings.rb      | 29 ++++++++++---------
 1 file changed, 16 insertions(+), 13 deletions(-)

diff --git a/db/migrate/20230215074423_move_user_settings.rb b/db/migrate/20230215074423_move_user_settings.rb
index dd230b3e84..2fac886bd6 100644
--- a/db/migrate/20230215074423_move_user_settings.rb
+++ b/db/migrate/20230215074423_move_user_settings.rb
@@ -59,26 +59,29 @@ class MoveUserSettings < ActiveRecord::Migration[6.1]
   end
 
   def up
-    User.find_each do |user|
-      previous_settings = LegacySetting.where(thing_type: 'User', thing_id: user.id).index_by(&:var)
+    User.find_in_batches do |users|
+      previous_settings_for_batch = LegacySetting.where(thing_type: 'User', thing_id: users.map(&:id)).group_by(&:thing_id)
 
-      user_settings = {}
+      users.each do |user|
+        previous_settings = previous_settings_for_batch[user.id]&.index_by(&:var) || {}
+        user_settings     = {}
 
-      MAPPING.each do |legacy_key, new_key|
-        value = previous_settings[legacy_key]&.value
+        MAPPING.each do |legacy_key, new_key|
+          value = previous_settings[legacy_key]&.value
 
-        next if value.blank?
+          next if value.blank?
 
-        if value.is_a?(Hash)
-          value.each do |nested_key, nested_value|
-            user_settings[MAPPING[legacy_key][nested_key.to_sym]] = nested_value
+          if value.is_a?(Hash)
+            value.each do |nested_key, nested_value|
+              user_settings[MAPPING[legacy_key][nested_key.to_sym]] = nested_value
+            end
+          else
+            user_settings[new_key] = value
           end
-        else
-          user_settings[new_key] = value
         end
-      end
 
-      user.update_column('settings', Oj.dump(user_settings)) # rubocop:disable Rails/SkipsModelValidations
+        user.update_column('settings', Oj.dump(user_settings)) # rubocop:disable Rails/SkipsModelValidations
+      end
     end
   end