Don't create attachments if remote file cannot be fetched

8 years ago · d2029a8845
parent 8d767b477f
commit d2029a8845
2 changed files with 1 additions and 3 deletions
--- a/app/models/media_attachment.rb
+++ b/app/models/media_attachment.rb
@ -22,8 +22,6 @@ class MediaAttachment < ApplicationRecord

  def file_remote_url=(url)
    self.file = URI.parse(url)
-  rescue OpenURI::HTTPError => e
-    Rails.logger.debug "Error fetching remote attachment: #{e}"
  end

  def image?
--- a/app/services/process_feed_service.rb
+++ b/app/services/process_feed_service.rb
@ -173,7 +173,7 @@ class ProcessFeedService < BaseService
        begin
          media.file_remote_url = link['href']
          media.save
-        rescue Paperclip::Errors::NotIdentifiedByImageMagickError
+        rescue OpenURI::HTTPError, Paperclip::Errors::NotIdentifiedByImageMagickError
          next
        end
      end