Avoid race conditions when creating backups (#10234)

Under load, multiple backups for a single user could be planned, which
is very expensive.
This commit is contained in:
ThibG 2019-03-11 00:50:31 +01:00 committed by Eugen Rochko
parent 11ce444b8b
commit cdf5a7f854

View file

@ -13,11 +13,25 @@ class Settings::ExportsController < Settings::BaseController
end end
def create def create
authorize :backup, :create? raise Mastodon::NotPermittedError unless user_signed_in?
backup = nil
RedisLock.acquire(lock_options) do |lock|
if lock.acquired?
authorize :backup, :create?
backup = current_user.backups.create!
else
raise Mastodon::RaceConditionError
end
end
backup = current_user.backups.create!
BackupWorker.perform_async(backup.id) BackupWorker.perform_async(backup.id)
redirect_to settings_export_path redirect_to settings_export_path
end end
def lock_options
{ redis: Redis.current, key: "backup:#{current_user.id}" }
end
end end