Fix unique username constraint for local users not being enforced in database (#14099)
This should not be an issue in practice because of the Rails-level uniqueness check, but local accounts having a NULL domain means the uniqueness constraint did not apply to them (since no two NULL values are considered equal).main
parent
75a2b8f815
commit
c6904c0d37
@ -0,0 +1,15 @@
|
|||||||
|
class AddFixedLowercaseIndexToAccounts < ActiveRecord::Migration[5.2]
|
||||||
|
disable_ddl_transaction!
|
||||||
|
|
||||||
|
def up
|
||||||
|
rename_index :accounts, 'index_accounts_on_username_and_domain_lower', 'old_index_accounts_on_username_and_domain_lower' unless index_name_exists?(:accounts, 'old_index_accounts_on_username_and_domain_lower')
|
||||||
|
add_index :accounts, "lower (username), COALESCE(lower(domain), '')", name: 'index_accounts_on_username_and_domain_lower', unique: true, algorithm: :concurrently
|
||||||
|
remove_index :accounts, name: 'old_index_accounts_on_username_and_domain_lower'
|
||||||
|
end
|
||||||
|
|
||||||
|
def down
|
||||||
|
add_index :accounts, 'lower (username), lower(domain)', name: 'old_index_accounts_on_username_and_domain_lower', unique: true, algorithm: :concurrently
|
||||||
|
remove_index :accounts, name: 'index_accounts_on_username_and_domain_lower'
|
||||||
|
rename_index :accounts, 'old_index_accounts_on_username_and_domain_lower', 'index_accounts_on_username_and_domain_lower'
|
||||||
|
end
|
||||||
|
end
|
Loading…
Reference in new issue