From a9b2368115adce467d00391d8343782f22e1df03 Mon Sep 17 00:00:00 2001 From: Claire Date: Thu, 28 Apr 2022 17:15:11 +0200 Subject: [PATCH] Add some missing indexes on foreign keys (#18157) --- .../20220428112511_add_index_statuses_on_account_id.rb | 7 +++++++ .../20220428112727_add_index_statuses_pins_on_status_id.rb | 7 +++++++ ...20428114454_add_index_reports_on_assigned_account_id.rb | 7 +++++++ ...4902_add_index_reports_on_action_taken_by_account_id.rb | 7 +++++++ db/schema.rb | 7 ++++++- 5 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 db/migrate/20220428112511_add_index_statuses_on_account_id.rb create mode 100644 db/migrate/20220428112727_add_index_statuses_pins_on_status_id.rb create mode 100644 db/migrate/20220428114454_add_index_reports_on_assigned_account_id.rb create mode 100644 db/migrate/20220428114902_add_index_reports_on_action_taken_by_account_id.rb diff --git a/db/migrate/20220428112511_add_index_statuses_on_account_id.rb b/db/migrate/20220428112511_add_index_statuses_on_account_id.rb new file mode 100644 index 0000000000..87a601b728 --- /dev/null +++ b/db/migrate/20220428112511_add_index_statuses_on_account_id.rb @@ -0,0 +1,7 @@ +class AddIndexStatusesOnAccountId < ActiveRecord::Migration[6.1] + disable_ddl_transaction! + + def change + add_index :statuses, [:account_id], name: :index_statuses_on_account_id, algorithm: :concurrently + end +end diff --git a/db/migrate/20220428112727_add_index_statuses_pins_on_status_id.rb b/db/migrate/20220428112727_add_index_statuses_pins_on_status_id.rb new file mode 100644 index 0000000000..26a5430876 --- /dev/null +++ b/db/migrate/20220428112727_add_index_statuses_pins_on_status_id.rb @@ -0,0 +1,7 @@ +class AddIndexStatusesPinsOnStatusId < ActiveRecord::Migration[6.1] + disable_ddl_transaction! + + def change + add_index :status_pins, [:status_id], name: :index_status_pins_on_status_id, algorithm: :concurrently + end +end diff --git a/db/migrate/20220428114454_add_index_reports_on_assigned_account_id.rb b/db/migrate/20220428114454_add_index_reports_on_assigned_account_id.rb new file mode 100644 index 0000000000..c260c9732a --- /dev/null +++ b/db/migrate/20220428114454_add_index_reports_on_assigned_account_id.rb @@ -0,0 +1,7 @@ +class AddIndexReportsOnAssignedAccountId < ActiveRecord::Migration[6.1] + disable_ddl_transaction! + + def change + add_index :reports, [:assigned_account_id], name: :index_reports_on_assigned_account_id, algorithm: :concurrently, where: 'assigned_account_id IS NOT NULL' + end +end diff --git a/db/migrate/20220428114902_add_index_reports_on_action_taken_by_account_id.rb b/db/migrate/20220428114902_add_index_reports_on_action_taken_by_account_id.rb new file mode 100644 index 0000000000..aed88cd80a --- /dev/null +++ b/db/migrate/20220428114902_add_index_reports_on_action_taken_by_account_id.rb @@ -0,0 +1,7 @@ +class AddIndexReportsOnActionTakenByAccountId < ActiveRecord::Migration[6.1] + disable_ddl_transaction! + + def change + add_index :reports, [:action_taken_by_account_id], name: :index_reports_on_action_taken_by_account_id, algorithm: :concurrently, where: 'action_taken_by_account_id IS NOT NULL' + end +end diff --git a/db/schema.rb b/db/schema.rb index c92f2d1c55..a58f424003 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 2022_03_16_233212) do +ActiveRecord::Schema.define(version: 2022_04_28_114902) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" @@ -784,6 +784,8 @@ ActiveRecord::Schema.define(version: 2022_03_16_233212) do t.datetime "action_taken_at" t.bigint "rule_ids", array: true t.index ["account_id"], name: "index_reports_on_account_id" + t.index ["action_taken_by_account_id"], name: "index_reports_on_action_taken_by_account_id", where: "(action_taken_by_account_id IS NOT NULL)" + t.index ["assigned_account_id"], name: "index_reports_on_assigned_account_id", where: "(assigned_account_id IS NOT NULL)" t.index ["target_account_id"], name: "index_reports_on_target_account_id" end @@ -860,6 +862,7 @@ ActiveRecord::Schema.define(version: 2022_03_16_233212) do t.datetime "created_at", default: -> { "now()" }, null: false t.datetime "updated_at", default: -> { "now()" }, null: false t.index ["account_id", "status_id"], name: "index_status_pins_on_account_id_and_status_id", unique: true + t.index ["status_id"], name: "index_status_pins_on_status_id" end create_table "status_stats", force: :cascade do |t| @@ -896,6 +899,7 @@ ActiveRecord::Schema.define(version: 2022_03_16_233212) do t.boolean "trendable" t.bigint "ordered_media_attachment_ids", array: true t.index ["account_id", "id", "visibility", "updated_at"], name: "index_statuses_20190820", order: { id: :desc }, where: "(deleted_at IS NULL)" + t.index ["account_id"], name: "index_statuses_on_account_id" t.index ["deleted_at"], name: "index_statuses_on_deleted_at", where: "(deleted_at IS NOT NULL)" t.index ["id", "account_id"], name: "index_statuses_local_20190824", order: { id: :desc }, where: "((local OR (uri IS NULL)) AND (deleted_at IS NULL) AND (visibility = 0) AND (reblog_of_id IS NULL) AND ((NOT reply) OR (in_reply_to_account_id = account_id)))" t.index ["id", "account_id"], name: "index_statuses_public_20200119", order: { id: :desc }, where: "((deleted_at IS NULL) AND (visibility = 0) AND (reblog_of_id IS NULL) AND ((NOT reply) OR (in_reply_to_account_id = account_id)))" @@ -1236,4 +1240,5 @@ ActiveRecord::Schema.define(version: 2022_03_16_233212) do ORDER BY (sum(t0.rank)) DESC; SQL add_index "follow_recommendations", ["account_id"], name: "index_follow_recommendations_on_account_id", unique: true + end