Disable PuSH for blocked domains
This commit is contained in:
		
							parent
							
								
									0fd73264c8
								
							
						
					
					
						commit
						94a6dfab3a
					
				
					 2 changed files with 7 additions and 3 deletions
				
			
		| 
						 | 
					@ -4,6 +4,7 @@ class Pubsubhubbub::SubscribeService < BaseService
 | 
				
			||||||
  def call(account, callback, secret, lease_seconds)
 | 
					  def call(account, callback, secret, lease_seconds)
 | 
				
			||||||
    return ['Invalid topic URL',        422] if account.nil?
 | 
					    return ['Invalid topic URL',        422] if account.nil?
 | 
				
			||||||
    return ['Invalid callback URL',     422] unless !callback.blank? && callback =~ /\A#{URI.regexp(%w(http https))}\z/
 | 
					    return ['Invalid callback URL',     422] unless !callback.blank? && callback =~ /\A#{URI.regexp(%w(http https))}\z/
 | 
				
			||||||
 | 
					    return ['Callback URL not allowed', 403] if DomainBlock.blocked?(Addressable::URI.parse(callback).host)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    subscription = Subscription.where(account: account, callback_url: callback).first_or_create!(account: account, callback_url: callback)
 | 
					    subscription = Subscription.where(account: account, callback_url: callback).first_or_create!(account: account, callback_url: callback)
 | 
				
			||||||
    Pubsubhubbub::ConfirmationWorker.perform_async(subscription.id, 'subscribe', secret, lease_seconds)
 | 
					    Pubsubhubbub::ConfirmationWorker.perform_async(subscription.id, 'subscribe', secret, lease_seconds)
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -13,8 +13,11 @@ class Pubsubhubbub::DistributionWorker
 | 
				
			||||||
    account  = stream_entry.account
 | 
					    account  = stream_entry.account
 | 
				
			||||||
    renderer = AccountsController.renderer.new(method: 'get', http_host: Rails.configuration.x.local_domain, https: Rails.configuration.x.use_https)
 | 
					    renderer = AccountsController.renderer.new(method: 'get', http_host: Rails.configuration.x.local_domain, https: Rails.configuration.x.use_https)
 | 
				
			||||||
    payload  = renderer.render(:show, assigns: { account: account, entries: [stream_entry] }, formats: [:atom])
 | 
					    payload  = renderer.render(:show, assigns: { account: account, entries: [stream_entry] }, formats: [:atom])
 | 
				
			||||||
 | 
					    # domains  = account.followers_domains
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    Subscription.where(account: account).active.select('id').find_each do |subscription|
 | 
					    Subscription.where(account: account).active.select('id, callback_url').find_each do |subscription|
 | 
				
			||||||
 | 
					      host = Addressable::URI.parse(subscription.callback_url).host
 | 
				
			||||||
 | 
					      next if DomainBlock.blocked?(host) # || !domains.include?(host)
 | 
				
			||||||
      Pubsubhubbub::DeliveryWorker.perform_async(subscription.id, payload)
 | 
					      Pubsubhubbub::DeliveryWorker.perform_async(subscription.id, payload)
 | 
				
			||||||
    end
 | 
					    end
 | 
				
			||||||
  rescue ActiveRecord::RecordNotFound
 | 
					  rescue ActiveRecord::RecordNotFound
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in a new issue