diff --git a/app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.js b/app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.js
index 582bb0d39c..a6186010b4 100644
--- a/app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.js
+++ b/app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.js
@@ -199,12 +199,13 @@ class EmojiPickerMenu extends React.PureComponent {
};
}
- handleClick = emoji => {
+ handleClick = (emoji, event) => {
if (!emoji.native) {
emoji.native = emoji.colons;
}
-
- this.props.onClose();
+ if (!event.ctrlKey) {
+ this.props.onClose();
+ }
this.props.onPick(emoji);
}
diff --git a/app/javascript/mastodon/features/ui/components/compose_panel.js b/app/javascript/mastodon/features/ui/components/compose_panel.js
index c7821f473a..3d0c48c7a9 100644
--- a/app/javascript/mastodon/features/ui/components/compose_panel.js
+++ b/app/javascript/mastodon/features/ui/components/compose_panel.js
@@ -1,16 +1,36 @@
import React from 'react';
+import { connect } from 'react-redux';
+import PropTypes from 'prop-types';
import SearchContainer from 'mastodon/features/compose/containers/search_container';
import ComposeFormContainer from 'mastodon/features/compose/containers/compose_form_container';
import NavigationContainer from 'mastodon/features/compose/containers/navigation_container';
import LinkFooter from './link_footer';
+import { changeComposing } from 'mastodon/actions/compose';
-const ComposePanel = () => (
-
-
-
-
-
-
-);
+export default @connect()
+class ComposePanel extends React.PureComponent {
-export default ComposePanel;
+ static propTypes = {
+ dispatch: PropTypes.func.isRequired,
+ };
+
+ onFocus = () => {
+ this.props.dispatch(changeComposing(true));
+ }
+
+ onBlur = () => {
+ this.props.dispatch(changeComposing(false));
+ }
+
+ render() {
+ return (
+
+
+
+
+
+
+ );
+ }
+
+}
diff --git a/app/javascript/mastodon/features/ui/index.js b/app/javascript/mastodon/features/ui/index.js
index 81ffad22ed..d21ecf2088 100644
--- a/app/javascript/mastodon/features/ui/index.js
+++ b/app/javascript/mastodon/features/ui/index.js
@@ -254,6 +254,7 @@ class UI extends React.PureComponent {
dispatch(synchronouslySubmitMarkers());
if (isComposing && (hasComposingText || hasMediaAttachments)) {
+ e.preventDefault();
// Setting returnValue to any string causes confirmation dialog.
// Many browsers no longer display this text to users,
// but we set user-friendly message for other browsers, e.g. Edge.
diff --git a/app/javascript/styles/mastodon/forms.scss b/app/javascript/styles/mastodon/forms.scss
index 0e5b00e8f1..7a0b2f9a39 100644
--- a/app/javascript/styles/mastodon/forms.scss
+++ b/app/javascript/styles/mastodon/forms.scss
@@ -587,7 +587,7 @@ code {
&.alert {
border: 1px solid rgba($error-value-color, 0.5);
- background: rgba($error-value-color, 0.25);
+ background: rgba($error-value-color, 0.1);
color: $error-value-color;
}
diff --git a/app/models/concerns/domain_normalizable.rb b/app/models/concerns/domain_normalizable.rb
index c00b3142fa..fb84058fc2 100644
--- a/app/models/concerns/domain_normalizable.rb
+++ b/app/models/concerns/domain_normalizable.rb
@@ -4,7 +4,7 @@ module DomainNormalizable
extend ActiveSupport::Concern
included do
- before_save :normalize_domain
+ before_validation :normalize_domain
end
private
diff --git a/app/models/domain_block.rb b/app/models/domain_block.rb
index f0a5bd296b..2b18e01fad 100644
--- a/app/models/domain_block.rb
+++ b/app/models/domain_block.rb
@@ -50,11 +50,13 @@ class DomainBlock < ApplicationRecord
def rule_for(domain)
return if domain.blank?
- uri = Addressable::URI.new.tap { |u| u.host = domain.gsub(/[\/]/, '') }
+ uri = Addressable::URI.new.tap { |u| u.host = domain.strip.gsub(/[\/]/, '') }
segments = uri.normalized_host.split('.')
variants = segments.map.with_index { |_, i| segments[i..-1].join('.') }
where(domain: variants).order(Arel.sql('char_length(domain) desc')).first
+ rescue Addressable::URI::InvalidURIError, IDN::Idna::IdnaError
+ nil
end
end