me/glitchier-soc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix regression from #3592 - validation condition nesting (#3644)

Browse source
This commit is contained in:
Eugen Rochko 2017-06-08 19:10:48 +02:00 committed by GitHub
parent cd5c9d67e8
commit 67330ceec7
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
app/models/account.rb
View file

@ -54,16 +54,12 @@ class Account < ApplicationRecord
validates :username, presence: true
# Remote user validations
with_options unless: :local? do
validates :username, uniqueness: { scope: :domain, case_sensitive: true }, if: :username_changed?
end
validates :username, uniqueness: { scope: :domain, case_sensitive: true }, if: -> { !local? && username_changed? }
# Local user validations
with_options if: :local? do
validates :username, format: { with: /\A[a-z0-9_]+\z/i }, uniqueness: { scope: :domain, case_sensitive: false }, length: { maximum: 30 }, unreserved: true, if: :username_changed?
validates :display_name, length: { maximum: 30 }, if: :display_name_changed?
validates :note, length: { maximum: 160 }, if: :note_changed?
end
validates :username, format: { with: /\A[a-z0-9_]+\z/i }, uniqueness: { scope: :domain, case_sensitive: false }, length: { maximum: 30 }, unreserved: true, if: -> { local? && username_changed? }
validates :display_name, length: { maximum: 30 }, if: -> { local? && display_name_changed? }
validates :note, length: { maximum: 160 }, if: -> { local? && note_changed? }
# Timelines
has_many :stream_entries, inverse_of: :account, dependent: :destroy