me/glitchier-soc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Do not hide NSFW media/CW'd text in OpenGraph tags (#6479)

Browse source 
Reasoning: HTML title tag affects everyone. But OpenGraph only affects
when somebody is deliberately sharing the content, usually in an
environment where such content is expected. Hiding the content in
OpenGraph tags results in deceitful previews which inhibit the
shareability of the post.

Example: Somebody writes a clever post about politics but kindly
puts a "uspol" content warning on it. Mastodon users are thankful,
but sharing this post on another platform results in non-Mastodon
users believing the entire contents of the post is "uspol" and not
clicking through/reading and re-sharing.
This commit is contained in:
Eugen Rochko 2018-02-16 04:40:53 +01:00 committed by GitHub
parent 1cf9467613
commit 5a5920f1bd
2 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/views/stream_entries/_og_description.html.haml
View file

@ -1,4 +1 @@
- if activity.is_a?(Status) && activity.spoiler_text? = opengraph 'og:description', [activity.spoiler_text, activity.text].reject(&:blank?).join("\n\n")
= opengraph 'og:description', activity.spoiler_text
- else
= opengraph 'og:description', activity.content

2
app/views/stream_entries/_og_image.html.haml
View file

@ -1,4 +1,4 @@
- if activity.is_a?(Status) && activity.non_sensitive_with_media? - if activity.is_a?(Status) && activity.media_attachments.any?
- activity.media_attachments.each do |media| - activity.media_attachments.each do |media|
- if media.image? - if media.image?
= opengraph 'og:image', full_asset_url(media.file.url(:original)) = opengraph 'og:image', full_asset_url(media.file.url(:original))