me/glitchier-soc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Reports spec for media attachments, clean up method (#2660)

Browse source 
* Add coverage for Report#media_attachments

* Direct query on media attachment
This commit is contained in:
Matt Jankowski 2017-04-30 12:15:49 -04:00 committed by Eugen Rochko
parent b83bc0ae64
commit 5259319cf5
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/models/report.rb
View file

@ -13,10 +13,6 @@ class Report < ApplicationRecord
end
def media_attachments
media_attachments = []
statuses.each do |s|
media_attachments.concat s.media_attachments
end
media_attachments
MediaAttachment.where(status_id: status_ids)
end
end

11
spec/models/report_spec.rb
View file

@ -10,4 +10,15 @@ describe Report do
expect(report.statuses).to eq [status]
end
end
describe 'media_attachments' do
it 'returns media attachments from statuses' do
status = Fabricate(:status)
media_attachment = Fabricate(:media_attachment, status: status)
_other_media_attachment = Fabricate(:media_attachment)
report = Fabricate(:report, status_ids: [status.id])
expect(report.media_attachments).to eq [media_attachment]
end
end
end