Language detection refactor (#2099)
* Extract detect_language to separate class * Use default locale, not just en * Add spec to confirm that whatlanguage cant identify empty string * Allow account locale to override default in language detector * PostStatusService supplies an account to detect languageth-downstream
parent
9026426b4d
commit
4591c7dbdb
@ -0,0 +1,20 @@
|
||||
# frozen_string_literal: true
|
||||
|
||||
class LanguageDetector
|
||||
attr_reader :text, :account
|
||||
|
||||
def initialize(text, account = nil)
|
||||
@text = text
|
||||
@account = account
|
||||
end
|
||||
|
||||
def to_iso_s
|
||||
WhatLanguage.new(:all).language_iso(text) || default_locale.to_sym
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
def default_locale
|
||||
account&.user&.locale || I18n.default_locale
|
||||
end
|
||||
end
|
@ -0,0 +1,71 @@
|
||||
# frozen_string_literal: true
|
||||
|
||||
require 'rails_helper'
|
||||
|
||||
describe LanguageDetector do
|
||||
describe 'to_iso_s' do
|
||||
it 'detects english language' do
|
||||
string = 'Hello and welcome to mastadon'
|
||||
result = described_class.new(string).to_iso_s
|
||||
|
||||
expect(result).to eq :en
|
||||
end
|
||||
|
||||
it 'detects spanish language' do
|
||||
string = 'Obtener un Hola y bienvenidos a Mastadon'
|
||||
result = described_class.new(string).to_iso_s
|
||||
|
||||
expect(result).to eq :es
|
||||
end
|
||||
|
||||
describe 'when language cant be detected' do
|
||||
it 'confirm language engine cant detect' do
|
||||
result = WhatLanguage.new(:all).language_iso('')
|
||||
expect(result).to be_nil
|
||||
end
|
||||
|
||||
describe 'with an account' do
|
||||
it 'uses the account locale when present' do
|
||||
user = double(:user, locale: 'fr')
|
||||
account = double(:account, user: user)
|
||||
result = described_class.new('', account).to_iso_s
|
||||
|
||||
expect(result).to eq :fr
|
||||
end
|
||||
|
||||
it 'uses default locale when account is present but has no locale' do
|
||||
user = double(:user, locale: nil)
|
||||
account = double(:accunt, user: user)
|
||||
result = described_class.new('', account).to_iso_s
|
||||
|
||||
expect(result).to eq :en
|
||||
end
|
||||
end
|
||||
|
||||
describe 'with an `en` default locale' do
|
||||
it 'uses the default locale' do
|
||||
string = ''
|
||||
result = described_class.new(string).to_iso_s
|
||||
|
||||
expect(result).to eq :en
|
||||
end
|
||||
end
|
||||
|
||||
describe 'with a non-`en` default locale' do
|
||||
around(:each) do |example|
|
||||
before = I18n.default_locale
|
||||
I18n.default_locale = :ja
|
||||
example.run
|
||||
I18n.default_locale = before
|
||||
end
|
||||
|
||||
it 'uses the default locale' do
|
||||
string = ''
|
||||
result = described_class.new(string).to_iso_s
|
||||
|
||||
expect(result).to eq :ja
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
Loading…
Reference in new issue