me/glitchier-soc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix AP serialization error when thread is missing (#4970)

Browse source 
`Status#reply?` may returns true even if the thread is missing.
e.g. the replied status was deleted or couldn't be fetched.

Then it raises NoMethodError on various AP json serialization.

This issue won't happen on Atom serialization because it checks thread
existence using `StreamEntry#threaded?` instead.
This commit is contained in:
unarist 2017-09-16 22:00:36 +09:00 committed by Eugen Rochko
parent eda52774d0
commit 23671fbffc
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/serializers/activitypub/note_serializer.rb
View file

@ -27,7 +27,7 @@ class ActivityPub::NoteSerializer < ActiveModel::Serializer
end
def in_reply_to
return unless object.reply?
return unless object.reply? && !object.thread.nil?
if object.thread.uri.nil? || object.thread.uri.start_with?('http')
ActivityPub::TagManager.instance.uri_for(object.thread)
@ -67,7 +67,7 @@ class ActivityPub::NoteSerializer < ActiveModel::Serializer
end
def in_reply_to_atom_uri
return unless object.reply?
return unless object.reply? && !object.thread.nil?
::TagManager.instance.uri_for(object.thread)
end