Fix Command-enter tooting
metaKey is only set correctly on keyDown, not keyUp, so this swaps to using that
This commit is contained in:
		
							parent
							
								
									251b04298e
								
							
						
					
					
						commit
						1da73ecade
					
				
					 2 changed files with 10 additions and 3 deletions
				
			
		| 
						 | 
					@ -38,7 +38,8 @@ const AutosuggestTextarea = React.createClass({
 | 
				
			||||||
    onSuggestionsClearRequested: React.PropTypes.func.isRequired,
 | 
					    onSuggestionsClearRequested: React.PropTypes.func.isRequired,
 | 
				
			||||||
    onSuggestionsFetchRequested: React.PropTypes.func.isRequired,
 | 
					    onSuggestionsFetchRequested: React.PropTypes.func.isRequired,
 | 
				
			||||||
    onChange: React.PropTypes.func.isRequired,
 | 
					    onChange: React.PropTypes.func.isRequired,
 | 
				
			||||||
    onKeyUp: React.PropTypes.func
 | 
					    onKeyUp: React.PropTypes.func,
 | 
				
			||||||
 | 
					    onKeyDown: React.PropTypes.func
 | 
				
			||||||
  },
 | 
					  },
 | 
				
			||||||
 | 
					
 | 
				
			||||||
  getInitialState () {
 | 
					  getInitialState () {
 | 
				
			||||||
| 
						 | 
					@ -108,6 +109,12 @@ const AutosuggestTextarea = React.createClass({
 | 
				
			||||||
 | 
					
 | 
				
			||||||
        break;
 | 
					        break;
 | 
				
			||||||
    }
 | 
					    }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    if (e.defaultPrevented || !this.props.onKeyDown) {
 | 
				
			||||||
 | 
					      return;
 | 
				
			||||||
 | 
					    }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    this.props.onKeyDown(e);
 | 
				
			||||||
  },
 | 
					  },
 | 
				
			||||||
 | 
					
 | 
				
			||||||
  onBlur () {
 | 
					  onBlur () {
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -49,7 +49,7 @@ const ComposeForm = React.createClass({
 | 
				
			||||||
    this.props.onChange(e.target.value);
 | 
					    this.props.onChange(e.target.value);
 | 
				
			||||||
  },
 | 
					  },
 | 
				
			||||||
 | 
					
 | 
				
			||||||
  handleKeyUp (e) {
 | 
					  handleKeyDown (e) {
 | 
				
			||||||
    if (e.keyCode === 13 && (e.ctrlKey || e.metaKey)) {
 | 
					    if (e.keyCode === 13 && (e.ctrlKey || e.metaKey)) {
 | 
				
			||||||
      this.props.onSubmit();
 | 
					      this.props.onSubmit();
 | 
				
			||||||
    }
 | 
					    }
 | 
				
			||||||
| 
						 | 
					@ -115,7 +115,7 @@ const ComposeForm = React.createClass({
 | 
				
			||||||
          value={this.props.text}
 | 
					          value={this.props.text}
 | 
				
			||||||
          onChange={this.handleChange}
 | 
					          onChange={this.handleChange}
 | 
				
			||||||
          suggestions={this.props.suggestions}
 | 
					          suggestions={this.props.suggestions}
 | 
				
			||||||
          onKeyUp={this.handleKeyUp}
 | 
					          onKeyDown={this.handleKeyDown}
 | 
				
			||||||
          onSuggestionsFetchRequested={this.onSuggestionsFetchRequested}
 | 
					          onSuggestionsFetchRequested={this.onSuggestionsFetchRequested}
 | 
				
			||||||
          onSuggestionsClearRequested={this.onSuggestionsClearRequested}
 | 
					          onSuggestionsClearRequested={this.onSuggestionsClearRequested}
 | 
				
			||||||
          onSuggestionSelected={this.onSuggestionSelected}
 | 
					          onSuggestionSelected={this.onSuggestionSelected}
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
		Reference in a new issue