Improve IntersectionObserverArticle perf (#5152)

th-downstream
Nolan Lawson 7 years ago committed by Eugen Rochko
parent 8f344b7bb0
commit 1660e53726

@ -58,26 +58,31 @@ export default class IntersectionObserverArticle extends React.Component {
}
handleIntersection = (entry) => {
const { onHeightChange, saveHeightKey, id } = this.props;
if (this.node && this.node.children.length !== 0) {
// save the height of the fully-rendered element
this.height = getRectFromEntry(entry).height;
this.entry = entry;
if (onHeightChange && saveHeightKey) {
onHeightChange(saveHeightKey, id, this.height);
}
scheduleIdleTask(this.calculateHeight);
this.setState(this.updateStateAfterIntersection);
}
this.setState((prevState) => {
if (prevState.isIntersecting && !entry.isIntersecting) {
updateStateAfterIntersection = (prevState) => {
if (prevState.isIntersecting && !this.entry.isIntersecting) {
scheduleIdleTask(this.hideIfNotIntersecting);
}
return {
isIntersecting: entry.isIntersecting,
isIntersecting: this.entry.isIntersecting,
isHidden: false,
};
});
}
calculateHeight = () => {
const { onHeightChange, saveHeightKey, id } = this.props;
// save the height of the fully-rendered element (this is expensive
// on Chrome, where we need to fall back to getBoundingClientRect)
this.height = getRectFromEntry(this.entry).height;
if (onHeightChange && saveHeightKey) {
onHeightChange(saveHeightKey, id, this.height);
}
}
hideIfNotIntersecting = () => {

Loading…
Cancel
Save