2017-06-07 21:09:25 +03:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'rails_helper'
|
|
|
|
|
|
|
|
class FakeService; end
|
|
|
|
|
|
|
|
describe Api::BaseController do
|
|
|
|
controller do
|
|
|
|
def success
|
|
|
|
head 200
|
|
|
|
end
|
|
|
|
|
|
|
|
def error
|
|
|
|
FakeService.new
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
Change unconfirmed user login behaviour (#11375)
Allow access to account settings, 2FA, authorized applications, and
account deletions to unconfirmed and pending users, as well as
users who had their accounts disabled. Suspended users cannot update
their e-mail or password or delete their account.
Display account status on account settings page, for example, when
an account is frozen, limited, unconfirmed or pending review.
After sign up, login users straight away and show a simple page that
tells them the status of their account with links to account settings
and logout, to reduce onboarding friction and allow users to correct
wrongly typed e-mail addresses.
Move the final sign-up step of SSO integrations to be the same
as above to reduce code duplication.
2019-07-22 11:48:50 +03:00
|
|
|
describe 'forgery protection' do
|
2017-06-07 21:09:25 +03:00
|
|
|
before do
|
|
|
|
routes.draw { post 'success' => 'api/base#success' }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not protect from forgery' do
|
|
|
|
ActionController::Base.allow_forgery_protection = true
|
|
|
|
post 'success'
|
2018-04-21 22:35:07 +03:00
|
|
|
expect(response).to have_http_status(200)
|
2017-06-07 21:09:25 +03:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
Change unconfirmed user login behaviour (#11375)
Allow access to account settings, 2FA, authorized applications, and
account deletions to unconfirmed and pending users, as well as
users who had their accounts disabled. Suspended users cannot update
their e-mail or password or delete their account.
Display account status on account settings page, for example, when
an account is frozen, limited, unconfirmed or pending review.
After sign up, login users straight away and show a simple page that
tells them the status of their account with links to account settings
and logout, to reduce onboarding friction and allow users to correct
wrongly typed e-mail addresses.
Move the final sign-up step of SSO integrations to be the same
as above to reduce code duplication.
2019-07-22 11:48:50 +03:00
|
|
|
describe 'non-functional accounts handling' do
|
|
|
|
let(:user) { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
|
|
|
|
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'read') }
|
|
|
|
|
|
|
|
controller do
|
|
|
|
before_action :require_user!
|
|
|
|
end
|
|
|
|
|
|
|
|
before do
|
|
|
|
routes.draw { post 'success' => 'api/base#success' }
|
|
|
|
allow(controller).to receive(:doorkeeper_token) { token }
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http forbidden for unconfirmed accounts' do
|
|
|
|
user.update(confirmed_at: nil)
|
|
|
|
post 'success'
|
|
|
|
expect(response).to have_http_status(403)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http forbidden for pending accounts' do
|
|
|
|
user.update(approved: false)
|
|
|
|
post 'success'
|
|
|
|
expect(response).to have_http_status(403)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http forbidden for disabled accounts' do
|
|
|
|
user.update(disabled: true)
|
|
|
|
post 'success'
|
|
|
|
expect(response).to have_http_status(403)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns http forbidden for suspended accounts' do
|
|
|
|
user.account.suspend!
|
|
|
|
post 'success'
|
|
|
|
expect(response).to have_http_status(403)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
describe 'error handling' do
|
2017-06-07 21:09:25 +03:00
|
|
|
ERRORS_WITH_CODES = {
|
|
|
|
ActiveRecord::RecordInvalid => 422,
|
|
|
|
Mastodon::ValidationError => 422,
|
|
|
|
ActiveRecord::RecordNotFound => 404,
|
2017-07-20 02:59:07 +03:00
|
|
|
Mastodon::UnexpectedResponseError => 503,
|
2017-06-07 21:09:25 +03:00
|
|
|
HTTP::Error => 503,
|
|
|
|
OpenSSL::SSL::SSLError => 503,
|
|
|
|
Mastodon::NotPermittedError => 403,
|
|
|
|
}
|
|
|
|
|
|
|
|
before do
|
|
|
|
routes.draw { get 'error' => 'api/base#error' }
|
|
|
|
end
|
|
|
|
|
|
|
|
ERRORS_WITH_CODES.each do |error, code|
|
|
|
|
it "Handles error class of #{error}" do
|
|
|
|
expect(FakeService).to receive(:new).and_raise(error)
|
|
|
|
|
|
|
|
get 'error'
|
|
|
|
expect(response).to have_http_status(code)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|