2020-05-03 17:30:36 +03:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
|
|
|
require 'rails_helper'
|
|
|
|
|
|
|
|
RSpec.describe ActivityPub::RepliesController, type: :controller do
|
|
|
|
let(:status) { Fabricate(:status, visibility: parent_visibility) }
|
2022-02-07 18:06:43 +02:00
|
|
|
let(:remote_account) { Fabricate(:account, domain: 'foobar.com') }
|
|
|
|
let(:remote_reply_id) { 'https://foobar.com/statuses/1234' }
|
|
|
|
let(:remote_querier) { nil }
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-03-06 23:51:40 +02:00
|
|
|
shared_examples 'cacheable response' do
|
2020-07-22 12:44:02 +03:00
|
|
|
it 'does not set cookies' do
|
|
|
|
expect(response.cookies).to be_empty
|
|
|
|
expect(response.headers['Set-Cookies']).to be nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'does not set sessions' do
|
2020-11-08 01:28:39 +02:00
|
|
|
response
|
2020-07-22 12:44:02 +03:00
|
|
|
expect(session).to be_empty
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'returns public Cache-Control header' do
|
|
|
|
expect(response.headers['Cache-Control']).to include 'public'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
shared_examples 'common behavior' do
|
|
|
|
context 'when status is private' do
|
|
|
|
let(:parent_visibility) { :private }
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it 'returns http not found' do
|
|
|
|
expect(response).to have_http_status(404)
|
|
|
|
end
|
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'when status is direct' do
|
|
|
|
let(:parent_visibility) { :direct }
|
2020-11-08 01:28:39 +02:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it 'returns http not found' do
|
|
|
|
expect(response).to have_http_status(404)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2020-11-08 01:28:39 +02:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
shared_examples 'disallowed access' do
|
|
|
|
context 'when status is public' do
|
|
|
|
let(:parent_visibility) { :public }
|
2020-11-08 01:28:39 +02:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it 'returns http not found' do
|
|
|
|
expect(response).to have_http_status(404)
|
2020-11-08 01:28:39 +02:00
|
|
|
end
|
2022-02-07 18:06:43 +02:00
|
|
|
end
|
2020-11-08 01:28:39 +02:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it_behaves_like 'common behavior'
|
|
|
|
end
|
2020-11-08 01:28:39 +02:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
shared_examples 'allowed access' do
|
|
|
|
context 'when account is permanently suspended' do
|
|
|
|
let(:parent_visibility) { :public }
|
2020-11-08 01:28:39 +02:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
before do
|
|
|
|
status.account.suspend!
|
|
|
|
status.account.deletion_request.destroy
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it 'returns http gone' do
|
|
|
|
expect(response).to have_http_status(410)
|
|
|
|
end
|
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'when account is temporarily suspended' do
|
|
|
|
let(:parent_visibility) { :public }
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
before do
|
|
|
|
status.account.suspend!
|
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it 'returns http forbidden' do
|
|
|
|
expect(response).to have_http_status(403)
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
2022-02-07 18:06:43 +02:00
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'when status is public' do
|
|
|
|
let(:parent_visibility) { :public }
|
|
|
|
let(:json) { body_as_json }
|
|
|
|
let(:page_json) { json[:first] }
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it 'returns http success' do
|
|
|
|
expect(response).to have_http_status(200)
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it 'returns application/activity+json' do
|
|
|
|
expect(response.media_type).to eq 'application/activity+json'
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
|
|
|
|
2022-03-06 23:51:40 +02:00
|
|
|
it_behaves_like 'cacheable response'
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'without only_other_accounts' do
|
|
|
|
it "returns items with thread author's replies" do
|
|
|
|
expect(page_json).to be_a Hash
|
|
|
|
expect(page_json[:items]).to be_an Array
|
|
|
|
expect(page_json[:items].size).to eq 1
|
|
|
|
expect(page_json[:items].all? { |item| item[:to].include?(ActivityPub::TagManager::COLLECTIONS[:public]) || item[:cc].include?(ActivityPub::TagManager::COLLECTIONS[:public]) }).to be true
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'when there are few self-replies' do
|
|
|
|
it 'points next to replies from other people' do
|
|
|
|
expect(page_json).to be_a Hash
|
|
|
|
expect(Addressable::URI.parse(page_json[:next]).query.split('&')).to include('only_other_accounts=true', 'page=true')
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
2022-02-07 18:06:43 +02:00
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'when there are many self-replies' do
|
|
|
|
before do
|
|
|
|
10.times { Fabricate(:status, account: status.account, thread: status, visibility: :public) }
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it 'points next to other self-replies' do
|
|
|
|
expect(page_json).to be_a Hash
|
|
|
|
expect(Addressable::URI.parse(page_json[:next]).query.split('&')).to include('only_other_accounts=false', 'page=true')
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
2022-02-07 18:06:43 +02:00
|
|
|
end
|
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'with only_other_accounts' do
|
|
|
|
let(:only_other_accounts) { 'true' }
|
2020-06-04 20:03:31 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it 'returns items with other public or unlisted replies' do
|
|
|
|
expect(page_json).to be_a Hash
|
|
|
|
expect(page_json[:items]).to be_an Array
|
|
|
|
expect(page_json[:items].size).to eq 3
|
|
|
|
end
|
2020-06-04 20:03:31 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it 'only inlines items that are local and public or unlisted replies' do
|
|
|
|
inlined_replies = page_json[:items].select { |x| x.is_a?(Hash) }
|
|
|
|
public_collection = ActivityPub::TagManager::COLLECTIONS[:public]
|
|
|
|
expect(inlined_replies.all? { |item| item[:to].include?(public_collection) || item[:cc].include?(public_collection) }).to be true
|
|
|
|
expect(inlined_replies.all? { |item| ActivityPub::TagManager.instance.local_uri?(item[:id]) }).to be true
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it 'uses ids for remote toots' do
|
|
|
|
remote_replies = page_json[:items].select { |x| !x.is_a?(Hash) }
|
|
|
|
expect(remote_replies.all? { |item| item.is_a?(String) && !ActivityPub::TagManager.instance.local_uri?(item) }).to be true
|
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'when there are few replies' do
|
|
|
|
it 'does not have a next page' do
|
|
|
|
expect(page_json).to be_a Hash
|
|
|
|
expect(page_json[:next]).to be_nil
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'when there are many replies' do
|
|
|
|
before do
|
|
|
|
10.times { Fabricate(:status, thread: status, visibility: :public) }
|
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it 'points next to other replies' do
|
|
|
|
expect(page_json).to be_a Hash
|
|
|
|
expect(Addressable::URI.parse(page_json[:next]).query.split('&')).to include('only_other_accounts=true', 'page=true')
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2022-02-07 18:06:43 +02:00
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it_behaves_like 'common behavior'
|
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
before do
|
|
|
|
stub_const 'ActivityPub::RepliesController::DESCENDANTS_LIMIT', 5
|
2022-09-21 23:45:57 +03:00
|
|
|
allow(controller).to receive(:signed_request_actor).and_return(remote_querier)
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
Fabricate(:status, thread: status, visibility: :public)
|
|
|
|
Fabricate(:status, thread: status, visibility: :public)
|
|
|
|
Fabricate(:status, thread: status, visibility: :private)
|
|
|
|
Fabricate(:status, account: status.account, thread: status, visibility: :public)
|
|
|
|
Fabricate(:status, account: status.account, thread: status, visibility: :private)
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
Fabricate(:status, account: remote_account, thread: status, visibility: :public, uri: remote_reply_id)
|
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
describe 'GET #index' do
|
|
|
|
subject(:response) { get :index, params: { account_username: status.account.username, status_id: status.id, only_other_accounts: only_other_accounts } }
|
|
|
|
let(:only_other_accounts) { nil }
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'with no signature' do
|
|
|
|
it_behaves_like 'allowed access'
|
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'with signature' do
|
|
|
|
let(:remote_querier) { Fabricate(:account, domain: 'example.com') }
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it_behaves_like 'allowed access'
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'when signed request account is blocked' do
|
|
|
|
before do
|
|
|
|
status.account.block!(remote_querier)
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it_behaves_like 'disallowed access'
|
|
|
|
end
|
2020-05-03 17:30:36 +03:00
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
context 'when signed request account is domain blocked' do
|
|
|
|
before do
|
|
|
|
status.account.block_domain!(remote_querier.domain)
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
|
|
|
|
2022-02-07 18:06:43 +02:00
|
|
|
it_behaves_like 'disallowed access'
|
2020-05-03 17:30:36 +03:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|